[Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures

[Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

Due to recent reorganization, fixincludes is now built unconditionally. 
Previously, it was not built for machines that did not need it, including
Windows.  Since fixincludes does not (and has never) built on native Windows,
this breaks bootstrap for these hosts.

-- 
           Summary: [4.0 Regression] Bootstrap broken by fixincludes
                    failures
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aaronavay62 at aaronwl dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-05 02:19 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02731.html>


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bonzini at gnu dot org
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-05 02:24 -------
Really fixinclude should just be fixed instead of working around the issue. See PR 14316.
The reason why fixinclude should be fixed instead of working around the issue is because really not 
running it will make some targets not work correctly.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |minor
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-10-05 02:24:52
               date|                            |
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-05 02:46 -------
I agree, but it in the meantime, it would be nice for mainline to bootstrap. 
Since fixincludes has never built on Windows, this isn't a regression, but
bootstrap failing definitely is.  When fixincludes has been fixed, presumably
after libiberty gets whatever changes needed to make collect2 work, mingw32 can
be removed from the list of targets to not build fixincludes for.

I don't know what the reason for disabling fixincludes on the other targets is,
though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[bonzini at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bonzini at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-14 08:58 -------
Needs a configury maintainer.  Bruce Korb said he's fine with it.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-14 09:17 -------
I think fixincludes is very close to building on Windows, and so probably should
not be disabled after all for this target, since its needed in some
configurations.  Presumably the other targets still should be disabled.

All that is needed to make it build is resolution to PR 17991, a patch to enable
two-process fixincludes for i?86-*-mingw32*, and a patch that does the
equivilent of <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg01393.html>.  I will
probably resubmit a version of the latter tomorrow that addresses the comments
here <http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01045.html>.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[ericw at evcohs dot com]

------- Additional Comments From ericw at evcohs dot com  2004-10-14 16:21 -------
See related bug #17462.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ericw at evcohs dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-20 08:21 -------
Subject: Bug 17832

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aaronwl@gcc.gnu.org	2004-10-20 08:21:10

Modified files:
	fixincludes    : ChangeLog fixincl.c fixlib.h procopen.c 

Log message:
	PR bootstrap/17832
	
	* fixincl.c (SIGCHLD): Remove definition.
	(initialize): Remove SIGIOT and SIGPIPE checks.
	(create_file): Fix mkdir() for Win32.
	(internal_fix): Use dup2() instead of fcntl().
	
	* fixlib.h (SIGQUIT): Define if undefined.
	(SIGIOT): Same.
	(SIGPIPE): Same.
	(SIGALRM): Same.
	(SIGKILL): Same.
	
	* procopen.c (chain_open): Use dup2() instead of fcntl().

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/ChangeLog.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixincl.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixlib.h.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/procopen.c.diff?cvsroot=gcc&r1=1.1&r2=1.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-20 08:39 -------
One more patch left to be reviewed, besides PR17991:
<http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01618.html>.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-21 09:52 -------
Aaron, I'm assigning the PR to you because it is very close to being fixed, and
I think it is easier if it is assigned to the author of the patch.  I hope you
don't mind.

PR17991 is still assigned to me and it covers the bugs in moving fixincludes to
the toplevel (hopefully the outstanding patch will be reviewed soon).


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bonzini at gcc dot gnu dot  |aaronavay62 at aaronwl dot
                   |org                         |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-21 21:28 -------
Well, I was a little confused earlier, and perhaps I still am.  Should
fixincludes be built on target=mingw bootstraps?  I don't think so; as far as I
know, its only needed for crosses.  But perhaps there might be some good reason
to enable it anyway?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |18107
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-22 05:21 -------
*** Bug 17462 has been marked as a duplicate of this bug. ***

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-26 21:40 -------
This is fixed now right?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-26 21:51 -------
Sorry, I missed putting the PR tag in the commit log.  However, no, this bug
really should not be closed yet.  That patch just disabled building fixincludes.
 The real patch that needs to be committed is in #8, which will make fixincludes
build appropriately when its needed, such as in *-mingw32's case, when
crosscompiling.  It needs to be reviewed by Bruce Korb, I think.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[bonzini at gcc dot gnu dot org]

-- 
Bug 17832 depends on bug 17991, which changed state.

Bug 17991 Summary: [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-27 20:14 -------
Subject: Bug 17832

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aaronwl@gcc.gnu.org	2004-10-27 20:13:58

Modified files:
	fixincludes    : ChangeLog fixfixes.c 

Log message:
	PR bootstrap/17832
	
	* fixfixes.c (main): Check for _PC_NAME_MAX.
	----------------------------------------------------------------------

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/ChangeLog.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixfixes.c.diff?cvsroot=gcc&r1=1.2&r2=1.3



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832

[Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-27 20:17 -------
Fixed on mainline.  I think this is the end of fixincludes problems for Windows.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832