[Bug c/17880] New: -Wsequence-point doesn't warn inside if, while, do conditions, for beg/cond/end expressions etc.

[Bug c/17880] New: -Wsequence-point doesn't warn inside if, while, do conditions, for beg/cond/end expressions etc.

[jakub at gcc dot gnu dot org]

/* { dg-do compile } */
/* { dg-options "-Wsequence-point" } */

int
foo (int x)
{
  unsigned int a = x;
  int b;
  b = (a += 5) > a;  /* { dg-warning "undefined" "sequence point warning" } */
  b = (a += 5) + a == 10;  /* { dg-warning "undefined" "sequence point warning" }
*/
  b = (a -= 5) > a;  /* { dg-warning "undefined" "sequence point warning" } */
  b = (a -= 5) + a == 10;  /* { dg-warning "undefined" "sequence point warning" }
*/
  b = a-- > a;  /* { dg-warning "undefined" "sequence point warning" } */
  b = a-- + a == 10;  /* { dg-warning "undefined" "sequence point warning" } */
  b = ++a > a;  /* { dg-warning "undefined" "sequence point warning" } */
  b = ++a + a == 10;  /* { dg-warning "undefined" "sequence point warning" } */
  if ((a += 5) > a) return -1;  /* { dg-warning "undefined" "sequence point
warning" } */
  if ((a += 5) + a == 10) return -1;  /* { dg-warning "undefined" "sequence point
warning" } */
  if ((a -= 5) > a) return -1;  /* { dg-warning "undefined" "sequence point
warning" } */
  if ((a -= 5) + a == 10) return -1;  /* { dg-warning "undefined" "sequence point
warning" } */
  if (a-- > a) return -1;  /* { dg-warning "undefined" "sequence point warning" }
*/
  if (a-- + a == 10) return -1;  /* { dg-warning "undefined" "sequence point
warning" } */
  if (++a > a) return -1;  /* { dg-warning "undefined" "sequence point warning" }
*/
  if (++a + a == 10) return -1;  /* { dg-warning "undefined" "sequence point
warning" } */
  do {} while ((a += 5) > a);  /* { dg-warning "undefined" "sequence point
warning" } */
  while ((a += 5) > a);  /* { dg-warning "undefined" "sequence point warning" }
*/
  for (b = (a += 5) > a;;);  /* { dg-warning "undefined" "sequence point warning"
} */
  for (; (a += 5) > a;);  /* { dg-warning "undefined" "sequence point warning" }
*/
  for (;; b = (a += 5) > a);  /* { dg-warning "undefined" "sequence point
warning" } */
  return 0;
}

While it is certainly possible to call verify_sequence_points for each condition
etc. from c-parse.in and parse.y, I think much better would be to move this
warning to say c_genericize, walk over all statements and call
verify_sequence_points where needed.

-- 
           Summary: -Wsequence-point doesn't warn inside if, while, do
                    conditions, for beg/cond/end expressions etc.
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,jsm at polyomino dot org
                    dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17880

[Bug c/17880] -Wsequence-point doesn't warn inside if, while, do conditions, for beg/cond/end expressions etc.

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-10-07 10:09 -------
Notice, this is also related to PR 16202, which shows other cases where 
Wsequence-point is not working.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17880

[Bug c/17880] -Wsequence-point doesn't warn inside if, while, do conditions, for beg/cond/end expressions etc.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-07 12:19 -------
Cofirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2004-10-07 12:19:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17880

[Bug c/17880] -Wsequence-point doesn't warn inside if, while, do conditions, for beg/cond/end expressions etc.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-12 17:04 -------
Note for the C++ front-end at this point we don't warn for the last for statement but we do for C, I 
have a fix for the problem (I fixed while fixing another problem).

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17880

[Bug c/17880] -Wsequence-point doesn't warn inside if, while, do conditions, for beg/cond/end expressions etc.

[manu at gcc dot gnu dot org]

------- Comment #4 from manu at gcc dot gnu dot org  2008-08-09 12:38 -------
Subject: Bug 17880

Author: manu
Date: Sat Aug  9 12:37:32 2008
New Revision: 138904

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=138904
Log:
2008-08-09  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>

        PR c/17880
        * c-typeck.c (digest_init): Call verify_sequence_points from here.
        (c_finish_return): Likewise.
        (c_start_case): Likewise.
        * c-common.c (warn_for_collisions_1): Use explicit location in
        warning.
        * c-parser.c (c_parser_condition): New. Call
        verify_sequence_points.
        (c_parser_paren_condition): Call c_parser_condition.
        (c_parser_for_statement): Call c_parser_condition.
testsuite/
        * gcc.dg/sequence-pt-pr17880.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/sequence-pt-pr17880.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-common.c
    trunk/gcc/c-parser.c
    trunk/gcc/c-typeck.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17880