[Bug other/17991] New: [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[Bug other/17991] New: [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[aaronavay62 at aaronwl dot com]

This patch appears to have broken two-process fixincludes: 
<http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02301.html>.  When attempting to 
link applyfix.exe, link fails because pz_mn_name_pat is undefined.

The two-process mode is only used for MS-DOS and BeOS, which is probably why 
noone noticed.  I noticed because it appears that, other than this and some 
other soon-to-be-fixed problems, two process fixincludes also works for 
Windows.

The problem is that mn_name_pat was made into an environment variable, which 
are only defined in fixincl.c, which is only included in the fixincl 
executable.  However, it is used in fixlib.c, which is included in the 
applyfix executable in a two-process build.

As I'm not really familiar with fixincludes, I can't say how this should be 
fixed.  It can be worked around by copying the environment variable 
definitions and initializations from fixincl.c to the SEPARATE_FIX_PROC 
section of fixfixes.c, but I'm not sure this is appropriate as applyfix 
doesn't need any of these environment variables otherwise.  Perhaps just this 
single environment variable could be defined.

-- 
           Summary: [4.0 Regression] Two-process fixincludes broken:
                    pz_mn_name_pat undefined
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aaronavay62 at aaronwl dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i?86-*-mingw32, i?86-*-msdosdjgpp, *-*-beos*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[aaronavay62 at aaronwl dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[aaronavay62 at aaronwl dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |17832
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bonzini at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bonzini at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-10-14 08:16:04
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-14 11:46 -------
http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01173.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[pavenis at latnet dot lv]

------- Additional Comments From pavenis at latnet dot lv  2004-10-14 14:41 -------
For DJGPP I created one more .c file in fixincludes directory: 
------------------------------------------------ 
#include "fixlib.h" 
 
#define _ENV_(v,m,n,t)   tCC* v = NULL; 
ENV_TABLE 
#undef _ENV_ 
------------------------------------------------ 
and added corresponding obj file to FIXOBJ in Makefile.in. 
 
That fixed the problem 
 
Andris 
 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavenis at latnet dot lv


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-15 07:58 -------
Subject: Bug 17991

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bonzini@gcc.gnu.org	2004-10-15 07:58:39

Modified files:
	fixincludes    : ChangeLog Makefile.in config.h.in configure 
	                 configure.ac fixfixes.c fixincl.c fixlib.c 
	                 fixlib.h 
Added files:
	fixincludes    : fixopts.c 

Log message:
	2004-08-14  Paolo Bonzini  <bonzini@gnu.org>
	
	PR other/17991
	
	* Makefile.in (ALLOBJ, TESTOBJ, FIXOBJ): Add fixopts.o.
	Update copyright year.
	* fixfixes.c (main): Call initialize_opts from fixopts.c.
	* fixincl.c (initialize): Call initialize_opts from fixopts.c,
	do not include code for parsing options (environment vars).
	(fix_with_system): Use a search path for applyfix, so that you
	can run the test suite with two-process fixincludes.
	* fixopts.c: New file.
	* configure.ac: Add --enable-twoprocess.  Export ac_exeext
	to config.h.  Default to --enable-twoprocess for MinGW32.
	* config.h.in: Regenerate.
	* configure: Regenerate.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixopts.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/ChangeLog.diff?cvsroot=gcc&r1=1.8&r2=1.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/Makefile.in.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/config.h.in.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/configure.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/configure.ac.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixfixes.c.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixincl.c.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixlib.c.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixlib.h.diff?cvsroot=gcc&r1=1.1&r2=1.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-15 08:00 -------
Aaron, please check it now.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-16 00:35 -------
Something isn't right with the patch.  The ChangeLog mentions a function
fix_with_system() that does not appear to exist.  The build fails because
z_applyfix_prog's initializer doesn't match its type, and fixing that generates
some other warnings expecting z_applyfix_prog to be a string rather than an
array of strings.  Is part of it missing?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[aaronavay62 at aaronwl dot com]

------- Additional Comments From aaronavay62 at aaronwl dot com  2004-10-19 19:25 -------
Yes, this fixes the problems.  Thanks!  Two-process fixincludes now builds.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-20 06:54 -------
Bruce, will you please take a look?  It is pretty obvious but I do not want to
step over you.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkorb at gnu dot org
             Status|WAITING                     |ASSIGNED
   Last reconfirmed|2004-10-14 08:16:04         |2004-10-20 06:54:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-27 07:54 -------
I'm going to commit this as obvious in a few hours unless someone screams.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bkorb at veritas dot com]

------- Additional Comments From bkorb at veritas dot com  2004-10-27 13:46 -------
Subject: Re:  [4.0 Regression] Two-process fixincludes
    broken: pz_mn_name_pat undefined

bonzini at gcc dot gnu dot org wrote:
> 
> ------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-27 07:54 -------
> I'm going to commit this as obvious in a few hours unless someone screams.
> 
> --
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991
> 
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.

I'm sorry I didn't see this.  It is _very_ obvious.  If the few
hours haven't elapsed yet, then please wait no longer.  Thanks! - Bruce


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-27 14:43 -------
Subject: Bug 17991

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bonzini@gcc.gnu.org	2004-10-27 14:42:57

Modified files:
	fixincludes    : ChangeLog configure configure.ac fixincl.c 

Log message:
	2004-10-27  Paolo Bonzini  <bonzini@gnu.org>
	
	PR other/17991
	
	* configure.ac: Fix typo.
	* configure: Regenerate.
	* fixincl.c (fix_with_system): tSCC is not a pointer.  Fix.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/ChangeLog.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/configure.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/configure.ac.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixincl.c.diff?cvsroot=gcc&r1=1.3&r2=1.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991

[Bug other/17991] [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined

[bonzini at gcc dot gnu dot org]

------- Additional Comments From bonzini at gcc dot gnu dot org  2004-10-27 14:44 -------
Fixed by the above commit.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991