public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hugo at hugovil dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/18035] New: target "gcc-no-fixedincludes" in Makefile doesn't check for proper return value of sub-make Date: Sat, 16 Oct 2004 16:19:00 -0000 [thread overview] Message-ID: <20041016161942.18035.hugo@hugovil.com> (raw) When I run these commands to install gcc (in a separate build directory): ----------------- make prefix=/mnt/hvlinux/static install-no-fixedincludes 1> make.log 2>&1 echo "Return value of Make = ${?}" ----------------- the return value is zero. But if I check the log (make.log), I can see that there was an error in one of the sub-make called. The reason is that the shell code in the "gcc-no-fixedincludes" target doesn't check if the sub-make return value is valid, and continues anyway whatever the return code is. The value returned by the sub-make command is 2 in my case. Here is the part of the Makefile that causes that: ------------------------ # Install the gcc headers files, but not the fixed include files, # which Cygnus is not allowed to distribute. This rule is very # dependent on the workings of the gcc Makefile.in. .PHONY: gcc-no-fixedincludes gcc-no-fixedincludes: @if [ -f ./gcc/Makefile ]; then \ rm -rf gcc/tmp-include; \ mv gcc/include gcc/tmp-include 2>/dev/null; \ mkdir gcc/include; \ cp $(srcdir)/gcc/gsyslimits.h gcc/include/syslimits.h; \ touch gcc/stmp-fixinc gcc/include/fixed; \ rm -f gcc/stmp-headers gcc/stmp-int-hdrs; \ r=`${PWD_COMMAND}`; export r; \ s=`cd $(srcdir); ${PWD_COMMAND}` ; export s; \ $(SET_LIB_PATH) \ (cd ./gcc && \ $(MAKE) $(GCC_FLAGS_TO_PASS) install); \ echo "return-code-test: error=$${?}"; \ rm -rf gcc/include; \ mv gcc/tmp-include gcc/include 2>/dev/null; \ else true; fi -------------------- -- Summary: target "gcc-no-fixedincludes" in Makefile doesn't check for proper return value of sub-make Product: gcc Version: 3.4.2 Status: UNCONFIRMED Severity: normal Priority: P2 Component: c AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: hugo at hugovil dot com CC: gcc-bugs at gcc dot gnu dot org GCC build triplet: 3.4.2 GCC host triplet: i686-pc-linux-gnu GCC target triplet: i686-pc-linux-gnu http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18035
next reply other threads:[~2004-10-16 16:19 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-10-16 16:19 hugo at hugovil dot com [this message] 2004-10-16 16:20 ` [Bug c/18035] " hugo at hugovil dot com 2004-10-16 16:25 ` [Bug bootstrap/18035] " pinskia at gcc dot gnu dot org 2004-10-16 16:28 ` pinskia at gcc dot gnu dot org 2004-10-16 18:00 ` hugo at hugovil dot com 2004-10-22 2:58 ` hugo at hugovil dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20041016161942.18035.hugo@hugovil.com \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).