public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/17407] New: ICE in int_mode_for_mode
@ 2004-09-10 20:43 steven at gcc dot gnu dot org
2004-09-10 20:57 ` [Bug middle-end/17407] [4.0 Regression] " pinskia at gcc dot gnu dot org
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: steven at gcc dot gnu dot org @ 2004-09-10 20:43 UTC (permalink / raw)
To: gcc-bugs
$ gcc --version
gcc (GCC) 3.5.0 20040909 (experimental)
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ cat t.i
typedef struct libxml_xpathCallback {
void *ns_uri;
} libxml_xpathCallback;
typedef libxml_xpathCallback libxml_xpathCallbackArray[];
libxml_xpathCallbackArray *libxml_xpathCallbacks;
void
foo (void)
{
if ((*libxml_xpathCallbacks)[3].ns_uri != ((void *)0)) ;
}
$ gcc t.i
t.i: In function `foo':
t.i:12: internal compiler error: in int_mode_for_mode, at stor-layout.c:253
Happens on at least ia64 and amd64
--
Summary: ICE in int_mode_for_mode
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Keywords: ice-on-valid-code
Severity: normal
Priority: P2
Component: middle-end
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: steven at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
@ 2004-09-10 20:57 ` pinskia at gcc dot gnu dot org
2004-09-11 20:30 ` steven at gcc dot gnu dot org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-09-10 20:57 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-09-10 20:57 -------
Hmm, this does not happen on x86 at least with "3.5.0 20040909" (my build failed last night I have to
figure out why still).
--
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |critical
Summary|ICE in int_mode_for_mode |[4.0 Regression] ICE in
| |int_mode_for_mode
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
2004-09-10 20:57 ` [Bug middle-end/17407] [4.0 Regression] " pinskia at gcc dot gnu dot org
@ 2004-09-11 20:30 ` steven at gcc dot gnu dot org
2004-09-18 14:17 ` roger at eyesopen dot com
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: steven at gcc dot gnu dot org @ 2004-09-11 20:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From steven at gcc dot gnu dot org 2004-09-11 20:30 -------
Now only happens on ia64 for me.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
GCC target triplet| |ia64
Last reconfirmed|0000-00-00 00:00:00 |2004-09-11 20:30:15
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
2004-09-10 20:57 ` [Bug middle-end/17407] [4.0 Regression] " pinskia at gcc dot gnu dot org
2004-09-11 20:30 ` steven at gcc dot gnu dot org
@ 2004-09-18 14:17 ` roger at eyesopen dot com
2004-09-18 14:41 ` roger at eyesopen dot com
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: roger at eyesopen dot com @ 2004-09-18 14:17 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From roger at eyesopen dot com 2004-09-18 14:17 -------
I'm getting out of my depth, but I thought I'd submit my analysis so far.
The failure on ia64 is from calling int_mode_for_mode with VOIDmode. This
erroneous call is from extract_bit_field which is called from expand_real
with op0 == (mem/s (reg/f:DI 340 [ libxml_xpathCallbacks.0 ]) [0 S0 A8])
You'll notice that the MEM has no mode, resulting in the problematic VOIDmode.
My obvious question (and why I'm out of my depth) is are MEMs required to
have a mode?
This MEM is created INDIRECT_REF section of expand_expr, where we call
gen_rtx_MEM with VOIDmode, because TYPE_MODE (type) returned VOIDmode for
type:
<array_type 0x200000000048e300
type <record_type 0x200000000048e220 libxml_xpathCallback type_0 DI
size <integer_cst 0x20000000000b4ab0 constant invariant 64>
unit size <integer_cst 0x20000000000b4ae0 constant invariant 8>
align 64 symtab 0 alias set -1
fields <field_decl 0x200000000048e060 ns_uri type <pointer_type 0x200000
00000c6ae0>
unsigned DI file /home/roger/pr17407.c line 2 size <integer_cst 0x20
000000000b4ab0 64> unit size <integer_cst 0x20000000000b4ae0 8>
align 64 offset_align 128
offset <integer_cst 0x20000000000b4330 constant invariant 0>
bit offset <integer_cst 0x20000000000b56e0 constant invariant 0> con
text <record_type 0x200000000048dea0 libxml_xpathCallback> arguments <integer_cs
t 0x20000000000b4330 0>>>
VOID
align 8 symtab 0 alias set -1>
At this point tmode is also VOIDmode.
It really isn't clear to me where best to fix the problem. The conditional
tests prior to the call of extract_bit_field at around line 7129 of expr.c
look daunting. Perhaps extract_bit_field is supposed to be able to handle
VOIDmode arguments, and should guard its call to int_mode_for_mode?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (2 preceding siblings ...)
2004-09-18 14:17 ` roger at eyesopen dot com
@ 2004-09-18 14:41 ` roger at eyesopen dot com
2004-10-15 1:00 ` pinskia at gcc dot gnu dot org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: roger at eyesopen dot com @ 2004-09-18 14:41 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From roger at eyesopen dot com 2004-09-18 14:41 -------
Still thinking, shouldn't the TYPE_MODE of an array type usually be BLKmode?
The function build_array_type doesn't appear to initialize the TYPE_MODE field,
so it remains VOIDmode. expand_expr has plenty of code to deal with BLKmode
MEMs, but rarely checks for VOIDmode. Indeed, int_mode_for_mode doesn't ICE
if passed BLKmode instead of VOIDmode.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (3 preceding siblings ...)
2004-09-18 14:41 ` roger at eyesopen dot com
@ 2004-10-15 1:00 ` pinskia at gcc dot gnu dot org
2004-10-21 2:07 ` [Bug c/17407] " pinskia at gcc dot gnu dot org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-15 1:00 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-15 01:00 -------
We don't call layout_type on the array type, why?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (4 preceding siblings ...)
2004-10-15 1:00 ` pinskia at gcc dot gnu dot org
@ 2004-10-21 2:07 ` pinskia at gcc dot gnu dot org
2004-10-21 2:44 ` pinskia at gcc dot gnu dot org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-21 2:07 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-21 02:07 -------
This is a C front-end problem where we don't call layout_type on the array, having it call layout_type on
the type, makes this work.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |pinskia at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Component|middle-end |c
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (5 preceding siblings ...)
2004-10-21 2:07 ` [Bug c/17407] " pinskia at gcc dot gnu dot org
@ 2004-10-21 2:44 ` pinskia at gcc dot gnu dot org
2004-10-21 3:07 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-21 2:44 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-21 02:44 -------
Here is the patch if you need it sooner:
Index: c-decl.c
===============================================================
====
RCS file: /cvs/gcc/gcc/gcc/c-decl.c,v
retrieving revision 1.602
diff -u -p -r1.602 c-decl.c
--- c-decl.c 14 Oct 2004 23:20:57 -0000 1.602
+++ c-decl.c 21 Oct 2004 02:10:02 -0000
@@ -4129,19 +4128,17 @@ grokdeclarator (const struct c_declarato
if (size_varies)
C_TYPE_VARIABLE_SIZE (type) = 1;
+ /* We can never complete an array type which is the
+ target of a pointer, so go ahead and lay it out. */
+ layout_type (type);
/* The GCC extension for zero-length arrays differs from
ISO flexible array members in that sizeof yields
zero. */
if (size && integer_zerop (size))
{
- layout_type (type);
TYPE_SIZE (type) = bitsize_zero_node;
TYPE_SIZE_UNIT (type) = size_zero_node;
}
- else if (declarator->kind == cdk_pointer)
- /* We can never complete an array type which is the
- target of a pointer, so go ahead and lay it out. */
- layout_type (type);
if (decl_context != PARM
&& (array_ptr_quals != TYPE_UNQUALIFIED
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug c/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (6 preceding siblings ...)
2004-10-21 2:44 ` pinskia at gcc dot gnu dot org
@ 2004-10-21 3:07 ` pinskia at gcc dot gnu dot org
2004-10-23 18:19 ` [Bug middle-end/17407] " pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-21 3:07 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-21 03:07 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01799.html>.
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (7 preceding siblings ...)
2004-10-21 3:07 ` pinskia at gcc dot gnu dot org
@ 2004-10-23 18:19 ` pinskia at gcc dot gnu dot org
2004-10-23 19:05 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-23 18:19 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-23 18:19 -------
I am testing a better patch which fixes this problem in the middle-end in build_array_type instead of in
the front-end where I thought the problem was. I am also fixing a C++ template related array problem
which also needs this patch so I fix it for both things at the same time.
--
What |Removed |Added
----------------------------------------------------------------------------
Component|c |middle-end
Keywords|patch |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (8 preceding siblings ...)
2004-10-23 18:19 ` [Bug middle-end/17407] " pinskia at gcc dot gnu dot org
@ 2004-10-23 19:05 ` pinskia at gcc dot gnu dot org
2004-10-25 13:27 ` cvs-commit at gcc dot gnu dot org
2004-10-25 13:28 ` pinskia at gcc dot gnu dot org
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-23 19:05 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-23 19:05 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01986.html> which reverts the fix for
PR middle-end/12920 and fixes PR middle-end/12920 right and also fixes PR c++/18121.
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (9 preceding siblings ...)
2004-10-23 19:05 ` pinskia at gcc dot gnu dot org
@ 2004-10-25 13:27 ` cvs-commit at gcc dot gnu dot org
2004-10-25 13:28 ` pinskia at gcc dot gnu dot org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-25 13:27 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-10-25 13:27 -------
Subject: Bug 17407
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: pinskia@gcc.gnu.org 2004-10-25 13:27:33
Modified files:
gcc : ChangeLog c-decl.c tree.c
gcc/cp : ChangeLog decl.c
gcc/testsuite : ChangeLog
Added files:
gcc/testsuite/g++.dg/template: array8.C
gcc/testsuite/gcc.c-torture/compile: pr17407.c
Log message:
2004-10-25 Andrew Pinski <pinskia@physics.uc.edu>
PR middle-end/17407
* c-decl.c (grokdeclarator) <case cdk_array>: Remove the call
layout_type as it is already done by build_array_type.
* tree.c (build_array_type): Layout the type even
2004-10-25 Andrew Pinski <pinskia@physics.uc.edu>
PR c++/18121
* decl.c (grokdeclarator) <case cdk_array>: Remove the call
layout_type as it is already done by create_array_type_for_decl.
2004-10-25 Andrew Pinski <pinskia@physics.uc.edu>
PR middle-end/17407
* gcc.c-torture/compile/pr17407.c: New test.
PR c++/18121
* g++.dg/template/array8.C: New test.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.6006&r2=2.6007
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&r1=1.603&r2=1.604
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree.c.diff?cvsroot=gcc&r1=1.439&r2=1.440
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4452&r2=1.4453
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl.c.diff?cvsroot=gcc&r1=1.1317&r2=1.1318
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4492&r2=1.4493
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/array8.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/compile/pr17407.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug middle-end/17407] [4.0 Regression] ICE in int_mode_for_mode
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
` (10 preceding siblings ...)
2004-10-25 13:27 ` cvs-commit at gcc dot gnu dot org
@ 2004-10-25 13:28 ` pinskia at gcc dot gnu dot org
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-25 13:28 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-25 13:28 -------
Fixed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17407
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2004-10-25 13:28 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-10 20:43 [Bug middle-end/17407] New: ICE in int_mode_for_mode steven at gcc dot gnu dot org
2004-09-10 20:57 ` [Bug middle-end/17407] [4.0 Regression] " pinskia at gcc dot gnu dot org
2004-09-11 20:30 ` steven at gcc dot gnu dot org
2004-09-18 14:17 ` roger at eyesopen dot com
2004-09-18 14:41 ` roger at eyesopen dot com
2004-10-15 1:00 ` pinskia at gcc dot gnu dot org
2004-10-21 2:07 ` [Bug c/17407] " pinskia at gcc dot gnu dot org
2004-10-21 2:44 ` pinskia at gcc dot gnu dot org
2004-10-21 3:07 ` pinskia at gcc dot gnu dot org
2004-10-23 18:19 ` [Bug middle-end/17407] " pinskia at gcc dot gnu dot org
2004-10-23 19:05 ` pinskia at gcc dot gnu dot org
2004-10-25 13:27 ` cvs-commit at gcc dot gnu dot org
2004-10-25 13:28 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).