[Bug fortran/14993] New: [gfortran] RAN (extension) intrinsic not supported

[Bug fortran/14993] New: [gfortran] RAN (extension) intrinsic not supported

[pinskia at gcc dot gnu dot org]

Even though the RAN is an extension, it is stopping me to compile some fortran 90 code
which I got from someone.


        module Global
        implicit none
        save
        integer :: iseed
        end module Global
        subroutine update(ntimes)
        use Global
        implicit none
        integer i,ntimes
        i = ran(iseed)
        return
        end

-- 
           Summary: [gfortran] RAN (extension) intrinsic not supported
           Product: gcc
           Version: tree-ssa
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-17 16:08 -------
Really everywhere I looked, the other compilers suggest that RAN is not an intrinsic but a 
function.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[gfortran] RAN (extension)  |[gfortran] RAN (extension)
                   |intrinsic not supported     |intrinsic/function not
                   |                            |supported
   Target Milestone|---                         |tree-ssa


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-26 13:08 -------
Confirmed, this is an alpha extension to the language.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-26 13:08:51
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-05-14 14:53 -------
So what does RAN(iseed) do? Return a random integer? I think it would be
straightforward to implement, but I'm not sure I know what it is meant to do
precisely.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[sgk at troutmask dot apl dot washington dot edu]

------- Additional Comments From sgk at troutmask dot apl dot washington dot edu  2004-05-30 21:02 -------
Are there any further details on what RAN() is suppose to do?
I've implemented G77's irand() function, and I suspect we can
map RAN() to irand().  If there is no additional info, this
bug report should be closed.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-30 21:06 -------
Read http://docs.hp.com/cgi-bin/doc3k/B3150190021.12118/219

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[sgk at troutmask dot apl dot washington dot edu]

------- Additional Comments From sgk at troutmask dot apl dot washington dot edu  2004-05-30 21:51 -------
Well, I read the URL.  It is identical to the RAND() I implemented.

http://gcc.gnu.org/ml/gcc-patches/2004-05/msg02016.html

Add a "make_alias("ran");" to intrinsic.c after the declaration
of "rand".

Now, back to your code snippet.  "i = ran(iseed)" should
set i = 0 for all values of iseed.

   RAN is a general random number generator of the multiplicative
   congruential type.  The result is a floating-point number that is
   uniformly distributed in the range between 0.0 inclusive and 1.0,
   exclusive.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-30 22:04 -------
According to the URL which I gave:
RAN stores a value in ISEED and uses it later to calculate the next
random number.  RAN uses the following algorithm to calculate the value
and update the seed:

     SEED = MOD(69069 * SEED + 1,2 ** 32)

SEED is a 32-bit number whose high-order 24 bits are converted to a
floating-point number and stored in Y. RAN returns Y and stores the new
seed in ISEED.

Which is slightly different than what you implemented, 
   rand_seed = GFC_RAND_A * rand_seed % GFC_RAND_M; what you implemented
what it says is the defintion:
     SEED = (69069 * SEED + 1)%(2 ** 32)

I think my example was just to show RAN was not implemented as I was trying to compile someone's 
else code.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] [gfortran] RAN (extension) intrinsic/function not supported

[sgk at troutmask dot apl dot washington dot edu]

------- Additional Comments From sgk at troutmask dot apl dot washington dot edu  2004-05-31 03:00 -------
I think we can make an alias to my implementation, once Paul
and I work out the details.  The "+ 1" in "69069 * seed + 1" is
need to guard against a pathalogical seed=0.  I guard against
this problem in srand() by explicitly checking for seed=0. Yes, my
implementation will probably generate a different sequence of
random numbers in comparison to RAN(), but if someone is using
RAN() or RAND() then they don't really care about the randomness
in their random numbers.

The PRNG in RANDOM_NUMBER is a good PRNG and the PRNG in rand()
sucks.  Do we really need another, slightly different, sucky
PRNG in gfortran.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-07-17 08:30 -------
Steve that seems like a good patch, maybe adding a way to turn on/off the intrinsic would be nice (aka 
with pedantic for now or something like that).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sgk at troutmask dot apl dot
                   |                            |washington dot edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[sgk at troutmask dot apl dot washington dot edu]

------- Additional Comments From sgk at troutmask dot apl dot washington dot edu  2004-07-17 16:12 -------
Andrew, I don't know how to enclose RAN() in an option.  Reading through
intrinsic.c, gfortran builds tables of intrinsic function and subroutine
names.  Currently, we can't mark a member of a table for inclusion/exclusion
by an option.  Although I agree with you on the use of an option, I think
this would require a massive rewrite of intrinsic.c.  Frankly, I lack the
skill to do such a rewrite before 3.5 is released.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-08-31 19:21 -------
(In reply to comment #11)
> Andrew, I don't know how to enclose RAN() in an option.  Reading through
> intrinsic.c, gfortran builds tables of intrinsic function and subroutine
> names.  Currently, we can't mark a member of a table for inclusion/exclusion
> by an option.  Although I agree with you on the use of an option, I think
> this would require a massive rewrite of intrinsic.c.  Frankly, I lack the
> skill to do such a rewrite before 3.5 is released.

What we could do is add an option, say -fno-nonstandard-intrinsics, and then
conditionalize the add_sym calls for all nonstandard intrinsics on this flag not
being set, i.e.
if (!gfc_option.only_standard)
  {
    add_sym ("fancyintrinsic");
    add_sym ("fancyintrinsic2");
  }
add_sym ("standardintrinsic");
etc.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[sgk at troutmask dot apl dot washington dot edu]

------- Additional Comments From sgk at troutmask dot apl dot washington dot edu  2004-08-31 20:17 -------
Subject: Re:  RAN (extension) intrinsic/function not supported

On Tue, Aug 31, 2004 at 07:21:51PM -0000, tobi at gcc dot gnu dot org wrote:
> 
> ------- Additional Comments From tobi at gcc dot gnu dot org  2004-08-31 19:21 -------
> (In reply to comment #11)
> > Andrew, I don't know how to enclose RAN() in an option.  Reading through
> > intrinsic.c, gfortran builds tables of intrinsic function and subroutine
> > names.  Currently, we can't mark a member of a table for inclusion/exclusion
> > by an option.  Although I agree with you on the use of an option, I think
> > this would require a massive rewrite of intrinsic.c.  Frankly, I lack the
> > skill to do such a rewrite before 3.5 is released.
> 
> What we could do is add an option, say -fno-nonstandard-intrinsics, and
> then conditionalize the add_sym calls for all nonstandard intrinsics on
> this flag not being set, i.e.
> if (!gfc_option.only_standard)
>   {
>     add_sym ("fancyintrinsic");
>     add_sym ("fancyintrinsic2");
>   }
> add_sym ("standardintrinsic");
> etc.
> 

Where are you doing this?  AFAIK, the list of intrinsics is constructed
when gfortran is compiled not when you execute gfortran.  At runtime
we need to be able to regenerate the expected list of intrinsics from
the master.  To me, this means we need to tag each specific and generic
intrinsic procedure with a standard.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-09-27 14:04 -------
The standard dependence thing has been solved by Janne in PR 17590 and the
attached patch. It is still waiting for review, though. Once this is in, it
should be possible to submit this patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |17590
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

-- 
Bug 14993 depends on bug 17590, which changed state.

Bug 17590 Summary: Standard conformance should take intrinsics into account.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17590

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[jblomqvi at cc dot hut dot fi]

-- 
Bug 14993 depends on bug 17590, which changed state.

Bug 17590 Summary: Standard conformance should take intrinsics into account.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17590

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[pbrook at gcc dot gnu dot org]

-- 
Bug 14993 depends on bug 17590, which changed state.

Bug 17590 Summary: Standard conformance should take intrinsics into account.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17590

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[sgk at troutmask dot apl dot washington dot edu]

------- Additional Comments From sgk at troutmask dot apl dot washington dot edu  2004-11-22 01:08 -------
This bug report can be closed.  Both the alias for RAN and Janne's
handling of specifying the requisite standard have been in the 
gfortran tree for quite sometime.

-- 
steve

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993

[Bug fortran/14993] RAN (extension) intrinsic/function not supported

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-22 01:09 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14993