public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/14521] New: Inconsistent quoting in new warning
@ 2004-03-11 5:26 dickrp at ece dot northwestern dot edu
2004-03-11 5:31 ` [Bug c++/14521] " dickrp at ece dot northwestern dot edu
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: dickrp at ece dot northwestern dot edu @ 2004-03-11 5:26 UTC (permalink / raw)
To: gcc-bugs
--
Summary: Inconsistent quoting in new warning
Product: gcc
Version: 3.4.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: c++
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: dickrp at ece dot northwestern dot edu
CC: gcc-bugs at gcc dot gnu dot org
GCC build triplet: i686-pc-linux-gnu
GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c++/14521] Inconsistent quoting in new warning
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
@ 2004-03-11 5:31 ` dickrp at ece dot northwestern dot edu
2004-03-11 5:54 ` [Bug middle-end/14521] " pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: dickrp at ece dot northwestern dot edu @ 2004-03-11 5:31 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From dickrp at ece dot northwestern dot edu 2004-03-11 05:30 -------
The inlining warnings are inconsistent with other diagnostic messages.
Normally, quoting is done like `this'. In the inlining warnings, it is done
like 'this'. This complicates build automation scripts.
Example:
RVector.cct:4: warning: inlining failed in call to 'T&
rstd::RVector<T>::operator[](long int) [with T = rstd::RawGraph::edge_index]':
--param large-function-growth limit reached while inlining the caller
Graph.cc:19: warning: called from here
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/14521] Inconsistent quoting in new warning
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
2004-03-11 5:31 ` [Bug c++/14521] " dickrp at ece dot northwestern dot edu
@ 2004-03-11 5:54 ` pinskia at gcc dot gnu dot org
2004-03-11 9:53 ` jsm at polyomino dot org dot uk
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-03-11 5:54 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-03-11 05:54 -------
Confirmed, the recomened way for GCC quoting is for `', the inlinner should also follow this.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |hubicka at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Component|c++ |middle-end
Ever Confirmed| |1
Keywords| |diagnostic
Last reconfirmed|0000-00-00 00:00:00 |2004-03-11 05:54:06
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/14521] Inconsistent quoting in new warning
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
2004-03-11 5:31 ` [Bug c++/14521] " dickrp at ece dot northwestern dot edu
2004-03-11 5:54 ` [Bug middle-end/14521] " pinskia at gcc dot gnu dot org
@ 2004-03-11 9:53 ` jsm at polyomino dot org dot uk
2004-10-31 21:58 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jsm at polyomino dot org dot uk @ 2004-03-11 9:53 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From jsm at polyomino dot org dot uk 2004-03-11 09:53 -------
Subject: Re: Inconsistent quoting in new warning
On Thu, 11 Mar 2004, pinskia at gcc dot gnu dot org wrote:
> Confirmed, the recomened way for GCC quoting is for `', the inlinner
> should also follow this.
I'd hope that actually this sort of inconsistency can be fixed by
implementing the sort of scheme at
<http://gcc.gnu.org/ml/gcc-bugs/2004-03/msg00303.html> and predecessors
rather than by adding more uses of grave accents as quotes.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/14521] Inconsistent quoting in new warning
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
` (2 preceding siblings ...)
2004-03-11 9:53 ` jsm at polyomino dot org dot uk
@ 2004-10-31 21:58 ` cvs-commit at gcc dot gnu dot org
2004-10-31 22:04 ` roger at eyesopen dot com
2004-10-31 22:06 ` pinskia at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-31 21:58 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-10-31 21:58 -------
Subject: Bug 14521
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: sayle@gcc.gnu.org 2004-10-31 21:58:10
Modified files:
gcc : ChangeLog tree-inline.c tree-optimize.c
tree-ssa.c
Log message:
PR middle-end/14521
* tree-inline.c (inline_forbidden_p_1): Use %qF instead of '%F'
for consistent quoting in diagnostic messages.
(expand_call_inline): Likewise.
* tree-optimize.c (tree_rest_of_compilation): Likewise.
* tree-ssa.c (warn_uninitialized_var): Likewise.
(warn_uninitialized_phi): Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.6114&r2=2.6115
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-inline.c.diff?cvsroot=gcc&r1=1.147&r2=1.148
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-optimize.c.diff?cvsroot=gcc&r1=2.58&r2=2.59
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-ssa.c.diff?cvsroot=gcc&r1=2.52&r2=2.53
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/14521] Inconsistent quoting in new warning
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
` (3 preceding siblings ...)
2004-10-31 21:58 ` cvs-commit at gcc dot gnu dot org
@ 2004-10-31 22:04 ` roger at eyesopen dot com
2004-10-31 22:06 ` pinskia at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: roger at eyesopen dot com @ 2004-10-31 22:04 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From roger at eyesopen dot com 2004-10-31 22:04 -------
I'm marking this as FIXED/RESOLVED for mainline. The consensus appears to be
that it's not worth the churn of translation files to do anything about this
non-regression on the gcc-3_4-branch. i.e. its a WONTFIX for gcc 3.4.4.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/14521] Inconsistent quoting in new warning
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
` (4 preceding siblings ...)
2004-10-31 22:04 ` roger at eyesopen dot com
@ 2004-10-31 22:06 ` pinskia at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-31 22:06 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14521
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2004-10-31 22:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-11 5:26 [Bug c++/14521] New: Inconsistent quoting in new warning dickrp at ece dot northwestern dot edu
2004-03-11 5:31 ` [Bug c++/14521] " dickrp at ece dot northwestern dot edu
2004-03-11 5:54 ` [Bug middle-end/14521] " pinskia at gcc dot gnu dot org
2004-03-11 9:53 ` jsm at polyomino dot org dot uk
2004-10-31 21:58 ` cvs-commit at gcc dot gnu dot org
2004-10-31 22:04 ` roger at eyesopen dot com
2004-10-31 22:06 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).