[Bug preprocessor/15167] New: Internal compiler error with "#pragma once"

[Bug preprocessor/15167] New: Internal compiler error with "#pragma once"

[Roland dot Meub at Tenovis dot com]

Compiling sources with "#pragma once" with header files in subdirectories may
lead to an internal compiler error in the preprocessor.

(I have stripped my sources down to show this problem)

scenario:
1. The test.cpp includes a header file "a.h", located in the subdirectory "inc".
2. "inc/a.h" includes a header file "b.h" in the base directory.
3. "b.h" uses "#pragma once" and includes "c.h" in the base directory.
4. "c.h" includes "b.h" in the base direcotry
   (recursive include prevented with #ifndef/#define)
5. test.cpp includes an other header file "d.h" in the base directory.
6. "d.h" includes also "b.h"
   This is the point, where the ICE occures.

here is my compile command and the resulting output
(I've used "-H" to show the includes)

gcc -I. -E -o test.i test.cpp -H
. inc/a.h
.. ./b.h
... ./c.h
. d.h
In file included from test.cpp:0:
<internal>:0: interner Compiler-Fehler: Speicherzugriffsfehler
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

I've also found out, that a changed search path with "-I- -I."
prevents the ICE

sample command with output:
gcc -I. -E -o test.i test.cpp -H -I- -I.
. ./inc/a.h
.. ./b.h
... ./c.h
. ./d.h

-- 
           Summary: Internal compiler error with "#pragma once"
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: Roland dot Meub at Tenovis dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i386-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
            Summary|Internal compiler error with|[3.4/3.5 Regression]
                   |"#pragma once"              |Internal compiler error with
                   |                            |"#pragma once"
   Target Milestone|---                         |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[Roland dot Meub at Tenovis dot com]

------- Additional Comments From Roland dot Meub at Tenovis dot com  2004-04-27 12:00 -------
Created an attachment (id=6171)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6171&action=view)
described source structure

since this is a preprocessor problem, i was not able to submit the preprocessor
output.
I have therefore addatched a archive of my source structure

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-27 12:48 -------
Confirmed.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-27 13:29 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-27 13:29:45
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[ossama at dre dot vanderbilt dot edu]

------- Additional Comments From ossama at dre dot vanderbilt dot edu  2004-04-28 16:55 -------
I get similar errors when compiling the latest CVS HEAD branch ACE sources:

$ /usr/local/gcc-3.4/bin/g++ -v  -W -Wall -Wpointer-arith -O -g -pipe  -pedantic
-Wno-long-long -Wuninitialized -Wwrite-strings -Wcast-align
-D_REENTRANT -DACE_HAS_AIO_CALLS -D_GNU_SOURCE -Wundef  
-I/home/ossama/work/head/ACE_wrappers -DACE_HAS_EXCEPTIONS -DACE_NO_INLINE
-DACE_BUILD_DLL -DACE_OS_BUILD_DLL  -c -fPIC -o .shobj/OS_NS_Thread.o
OS_NS_Thread.cpp
Reading specs from /usr/local/gcc-3.4/lib/gcc/i686-pc-linux-gnu/3.4.0/specs
Configured with: ./configure --prefix=/usr/local/gcc-3.4 --enable-shared
--enable-threads=posix --enable-__cxa_atexit
Thread model: posix
gcc version 3.4.0
 /usr/local/gcc-3.4/libexec/gcc/i686-pc-linux-gnu/3.4.0/cc1plus -quiet -v
-I/home/ossama/work/head/ACE_wrappers -D_GNU_SOURCE -D_REENTRANT
-DACE_HAS_AIO_CALLS -D_GNU_SOURCE -DACE_HAS_EXCEPTIONS -DACE_NO_INLINE
-DACE_BUILD_DLL -DACE_OS_BUILD_DLL OS_NS_Thread.cpp -quiet -dumpbase
OS_NS_Thread.cpp -mtune=pentiumpro -auxbase-strip .shobj/OS_NS_Thread.o -g -O -W
-Wall -Wpointer-arith -pedantic -Wno-long-long -Wuninitialized -Wwrite-strings
-Wcast-align -Wundef -version -fPIC -o -
|
 as -V -Qy -o .shobj/OS_NS_Thread.o -
ignoring nonexistent directory
"/usr/local/gcc-3.4/lib/gcc/i686-pc-linux-gnu/3.4.0/../../../../i686-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /home/ossama/work/head/ACE_wrappers
 /usr/local/gcc-3.4/lib/gcc/i686-pc-linux-gnu/3.4.0/../../../../include/c++/3.4.0
 /usr/local/gcc-3.4/lib/gcc/i686-pc-linux-gnu/3.4.0/../../../../include/c++/3.4.0/i686-pc-linux-gnu
 /usr/local/gcc-3.4/lib/gcc/i686-pc-linux-gnu/3.4.0/../../../../include/c++/3.4.0/backward
 /usr/local/include
 /usr/local/gcc-3.4/include
 /usr/local/gcc-3.4/lib/gcc/i686-pc-linux-gnu/3.4.0/include
 /usr/include
End of search list.
GNU C++ version 3.4.0 (i686-pc-linux-gnu)
        compiled by GNU C version 3.2.2 20030222 (Red Hat Linux 3.2.2-5).
GGC heuristics: --param ggc-min-expand=64 --param ggc-min-heapsize=64160
GNU assembler version 2.13.90.0.18 (i386-redhat-linux) using BFD version
2.13.90.0.18 20030206
In file included from /home/ossama/work/head/ACE_wrappers/ace/OS_NS_Thread.h:31,
                from OS_NS_Thread.cpp:1:
/home/ossama/work/head/ACE_wrappers/ace/os_include/os_pthread.h:24: internal
compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


Similarly, I was not able to produce preprocessed output that triggered the problem.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[ossama at dre dot vanderbilt dot edu]

------- Additional Comments From ossama at dre dot vanderbilt dot edu  2004-04-28 16:57 -------
I neglected to mention that the problem only occurs when #pragma once is enabled
in ACE.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[chucky at outmax dot org]

------- Additional Comments From chucky at outmax dot org  2004-06-15 14:34 -------
I want to tell that this is REALLY a big bug : this disallow me to use 
inheritance in a normal situation in my master thesis because G++ eats all the 
CPU and the memory (RAM + SWAP) before saying "internal error", simply because 
there is lots of includes in my project. 
 
Please correct this as soon as possible... 
 
I haven't found where to vote for this bug but I am seeking ! 
 
Thank you for your help ! 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-15 14:40 -------
#pragma once has a work around, use #ifdef wrappers around the header file.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-06-22 08:08 -------
Postponed until GCC 3.4.2.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.1                       |3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-08-29 18:11 -------
Postponed until GCC 3.4.3.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/3.5 Regression] Internal compiler error with "#pragma once"

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-08-29 18:14 -------
Postponed until GCC 3.4.3.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.2                       |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-11 05:22 -------
f->buffer is NULL at the point of the crash.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|3.4.1 4.0                   |3.4.1 4.0.0
      Known to work|                            |3.3.3
   Last reconfirmed|2004-04-27 13:29:45         |2004-10-11 05:22:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-13 11:31 -------
*** Bug 17944 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |micis at gmx dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-11-01 00:46 -------
Postponed until GCC 3.4.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.3                       |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-12 04:54 -------
Someone should really look into this more than I have since this is a really bad preprocessor regression.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-02 18:54 -------
Investigating, but this is not pretty.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-05 18:48 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00344.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[neil at gcc dot gnu dot org]

------- Additional Comments From neil at gcc dot gnu dot org  2004-12-06 02:26 -------
Eric - can you try your testcase on GCC sources as of around the beginning of
August 2003?

This is when I completely rewrote the whole file lookup mechanism, and contrary
to Zack's claims it did work 100% correctly, to the best of my knowledge, and
would always get links, both hard and soft, correct with #pragma once correct no
matter how contorted or renamed the file was.  Then only issue in that code was
the -remap bug that has since been fixed.

However, since that date, various people have hacked at the code who probably
didn't understand it.  Zack did various "optimizations" and Apple added a bunch
of stuff for obfuscated include file lookup and line number stuff.  I think it
is very likely it was broken along the way.

If it was broken back around 5th August 2003 I will look into this, as it was my
new code.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-06 07:11 -------
> Eric - can you try your testcase on GCC sources as of around the beginning of
> August 2003?

You can't reasonably ask this.  It is your duty as a cpplib maintainer to do
this kind of work.  I honestly have no time to do it myself.

> This is when I completely rewrote the whole file lookup mechanism, and
> contrary to Zack's claims it did work 100% correctly, to the best of my
> knowledge, and would always get links, both hard and soft, correct with
> #pragma once correct no matter how contorted or renamed the file was.  Then
> only issue in that code was the -remap bug that has since been fixed.

Yes, the code doesn't look particularly broken to me.  Does your original code
reset buffer_valid when the buffer is freed?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-09 07:07 -------
Revised patch at http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00604.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-15 13:31 -------
Subject: Bug 15167

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	ebotcazou@gcc.gnu.org	2004-12-15 13:31:29

Modified files:
	libcpp         : ChangeLog files.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg/cpp: pragma-once-1b.h pragma-once-1.c 
	                          pragma-once-1c.h pragma-once-1d.h 
	gcc/testsuite/gcc.dg/cpp/inc: pragma-once-1a.h 

Log message:
	PR preprocessor/15167
	* files.c (destroy_cpp_file): New function.
	(should_stack_file): Make a new file if the
	compared file is still stacked.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&r1=1.44&r2=1.45
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/files.c.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4761&r2=1.4762
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1b.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1c.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1d.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pragma-once-1a.h.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-15 13:41 -------
Subject: Bug 15167

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	ebotcazou@gcc.gnu.org	2004-12-15 13:41:28

Modified files:
	gcc            : ChangeLog cppfiles.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg/cpp: pragma-once-1b.h pragma-once-1.c 
	                          pragma-once-1c.h pragma-once-1d.h 
	gcc/testsuite/gcc.dg/cpp/inc: pragma-once-1a.h 

Log message:
	PR preprocessor/15167
	* cppfiles.c (destroy_cpp_file): New function.
	(should_stack_file): Make a new file if the
	compared file is still stacked.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.736&r2=2.2326.2.737
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cppfiles.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.198.4.3&r2=1.198.4.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.325&r2=1.3389.2.326
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1b.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1c.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1d.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pragma-once-1a.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-15 13:43 -------
See http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00604.html


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167