public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug AWT/18312] New: Component.createImage() doesn't clear bitmap
@ 2004-11-05 19:51 sven at physto dot se
  2004-11-05 19:52 ` [Bug AWT/18312] " sven at physto dot se
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: sven at physto dot se @ 2004-11-05 19:51 UTC (permalink / raw)
  To: gcc-bugs

An image created with Component.createImage() is supposed to be filled with the
default component background gray.

Currently, it simply mallocs the pixmap data without initializing it, which is
also a mild security flaw.

Suggested fix is to do a fillRect() after creating the graphics context in
GtkComponentPeer.java.

An (faster) alternative would be to do a memset in the c method
Java_gnu_java_awt_peer_gtk_GdkGraphics_initState__II.

-- 
           Summary: Component.createImage() doesn't clear bitmap
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: AWT
        AssignedTo: fitzsim at redhat dot com
        ReportedBy: sven at physto dot se
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18312


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug AWT/18312] Component.createImage() doesn't clear bitmap
  2004-11-05 19:51 [Bug AWT/18312] New: Component.createImage() doesn't clear bitmap sven at physto dot se
@ 2004-11-05 19:52 ` sven at physto dot se
  2004-11-05 20:05 ` fitzsim at redhat dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sven at physto dot se @ 2004-11-05 19:52 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From sven at physto dot se  2004-11-05 19:52 -------
Created an attachment (id=7481)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=7481&action=view)
Suggested patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18312


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug AWT/18312] Component.createImage() doesn't clear bitmap
  2004-11-05 19:51 [Bug AWT/18312] New: Component.createImage() doesn't clear bitmap sven at physto dot se
  2004-11-05 19:52 ` [Bug AWT/18312] " sven at physto dot se
@ 2004-11-05 20:05 ` fitzsim at redhat dot com
  2004-11-10 22:13 ` sven at physto dot se
  2004-12-01  0:38 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: fitzsim at redhat dot com @ 2004-11-05 20:05 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From fitzsim at redhat dot com  2004-11-05 20:05 -------
This looks good.  Please commit.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-11-05 20:05:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18312


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug AWT/18312] Component.createImage() doesn't clear bitmap
  2004-11-05 19:51 [Bug AWT/18312] New: Component.createImage() doesn't clear bitmap sven at physto dot se
  2004-11-05 19:52 ` [Bug AWT/18312] " sven at physto dot se
  2004-11-05 20:05 ` fitzsim at redhat dot com
@ 2004-11-10 22:13 ` sven at physto dot se
  2004-12-01  0:38 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: sven at physto dot se @ 2004-11-10 22:13 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From sven at physto dot se  2004-11-10 22:12 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18312


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug AWT/18312] Component.createImage() doesn't clear bitmap
  2004-11-05 19:51 [Bug AWT/18312] New: Component.createImage() doesn't clear bitmap sven at physto dot se
                   ` (2 preceding siblings ...)
  2004-11-10 22:13 ` sven at physto dot se
@ 2004-12-01  0:38 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-12-01  0:38 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-01 00:37 -------
All of these are all fixed in 4.0.0 by the merge of the gui branch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18312


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-12-01  0:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-05 19:51 [Bug AWT/18312] New: Component.createImage() doesn't clear bitmap sven at physto dot se
2004-11-05 19:52 ` [Bug AWT/18312] " sven at physto dot se
2004-11-05 20:05 ` fitzsim at redhat dot com
2004-11-10 22:13 ` sven at physto dot se
2004-12-01  0:38 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).