[Bug c++/18370] New: cp_parser_initializer_list uninit variable problems

[Bug c++/18370] New: cp_parser_initializer_list uninit variable problems

[dcb314 at hotmail dot com]

I just tried to compile this code on a i686 Linux box with valgrind 2.2

int p1[ 10 ] =
{
	0, 0, 0, 0, 2, 0, 2, 0, 2, 3,
};

The compiler said
[dcb@localhost src]$ ~/valgrind/results.220/bin/valgrind --tool=memcheck
--trace-children=yes -q ~/gnu/gcc343/results/bin/g++  -Wno-deprecated -c
gcc343bug.cc
==30646== Conditional jump or move depends on uninitialised value(s)
==30646==    at 0x80E6AF0: cp_parser_initializer_list (parser.c:11646)
==30646==    by 0x80E69A1: cp_parser_initializer_clause (parser.c:11581)
==30646==    by 0x80F058B: cp_parser_init_declarator (parser.c:11486)
==30646==    by 0x80EAC01: cp_parser_simple_declaration (parser.c:6524)
[dcb@localhost src]$

The compiler source code is

      initializer = cp_parser_initializer_clause (parser,
                          &clause_non_constant_p);
      if (clause_non_constant_p)

Suggest that variable clause_non_constant_p hasn't been initialised 
by routine cp_parser_initializer_clause.

-- 
           Summary: cp_parser_initializer_list uninit variable problems
           Product: gcc
           Version: 3.4.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dcb314 at hotmail dot com
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: i686-linux-pc-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] cp_parser_initializer_list uninit variable problems

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-08 12:37 -------
Hmm, we always set it:
static tree
cp_parser_initializer_list (cp_parser* parser, bool* non_constant_p)
{ 
  tree initializers = NULL_TREE;
  
  /* Assume all of the expressions are constant.  */
  *non_constant_p = false;

Must be a different variable/line which you quoted that is giving the problem.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] cp_parser_initializer_list uninit variable problems

[dcb314 at hotmail dot com]

------- Additional Comments From dcb314 at hotmail dot com  2004-11-08 17:41 -------
>Must be a different variable/line which you quoted that is giving the problem.

You might be correct, but valgrind always reports accurate line numbers.

The bug still seems to be file parser.c, line 11646.

Might be worth another look.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4/4.0 Regression] cp_parser_initializer_list uninit variable problems

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-08 18:23 -------
Confirmed, I was looking at the wrong variable.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |accepts-invalid, rejects-
                   |                            |valid
   Last reconfirmed|0000-00-00 00:00:00         |2004-11-08 18:23:40
               date|                            |
            Summary|cp_parser_initializer_list  |[3.4/4.0 Regression]
                   |uninit variable problems    |cp_parser_initializer_list
                   |                            |uninit variable problems
   Target Milestone|---                         |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4/4.0 Regression] cp_parser_initializer_list uninit variable problems

[nathan at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |nathan at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4/4.0 Regression] cp_parser_initializer_list uninit variable problems

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-25 19:47 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2005-01/msg01828.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4/4.0 Regression] cp_parser_initializer_list uninit variable problems

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-26 18:59 -------
Subject: Bug 18370

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	amylaar@gcc.gnu.org	2005-01-26 18:59:04

Modified files:
	gcc/cp         : ChangeLog 

Log message:
	Add bug number:
	PR c++/18370
	* parse.c (cp_parser_initializer_clause): Initialize *non_constant_p.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4596&r2=1.4597



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4 Regression] cp_parser_initializer_list uninit variable problems

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-26 20:50 -------
Fixed on the mainline now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.0.0
            Summary|[3.4/4.0 Regression]        |[3.4 Regression]
                   |cp_parser_initializer_list  |cp_parser_initializer_list
                   |uninit variable problems    |uninit variable problems


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4 Regression] cp_parser_initializer_list uninit variable problems

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-27 12:55 -------
Subject: Bug 18370

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	amylaar@gcc.gnu.org	2005-01-27 12:54:40

Modified files:
	gcc/cp         : ChangeLog parser.c 

Log message:
	gcc:
	* real.c (do_add): Initialize signalling and canonical members.
	
	* real.c (real_from_integer): Zero out destination.
	gcc/cp:
	PR c++/18370
	* parser.c (cp_parser_initializer_clause): Initialize *non_constant_p.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.192&r2=1.3892.2.193
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.157.2.49&r2=1.157.2.50



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4 Regression] cp_parser_initializer_list uninit variable problems

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-27 12:57 -------
Subject: Bug 18370

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	amylaar@gcc.gnu.org	2005-01-27 12:57:43

Modified files:
	gcc            : ChangeLog real.c 

Log message:
	gcc:
	* real.c (do_add): Initialize signalling and canonical members.
	
	* real.c (real_from_integer): Zero out destination.
	gcc/cp:
	PR c++/18370
	* parser.c (cp_parser_initializer_clause): Initialize *non_constant_p.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.784&r2=2.2326.2.785
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/real.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.135.4.6&r2=1.135.4.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370

[Bug c++/18370] [3.4 Regression] cp_parser_initializer_list uninit variable problems

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-27 13:25 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18370