[Bug middle-end/18535] New: fix_irreducible_loops could be improved

[Bug middle-end/18535] New: fix_irreducible_loops could be improved

[pinskia at gcc dot gnu dot org]

If get_loop_exit_edges would return a VEC (edges) instead of a malloced array, we could improve the 
else stament of when we get the edges to be just an assigment of the SUCCS so we don't have an extra 
setting loop in this case.

The code in quesiton:
      if (bb->loop_father->header == bb)
        edges = get_loop_exit_edges (bb->loop_father, &n_edges);
      else  
        {
          n_edges = EDGE_COUNT (bb->succs);
          edges = xmalloc (n_edges * sizeof (edge));
          FOR_EACH_EDGE (e, ei, bb->succs)
            edges[ei.index] = e;
        } 
(we do not write to edges after this).
See how we just set the edges array to the edge.

-- 
           Summary: fix_irreducible_loops could be improved
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Keywords: compile-time-hog
          Severity: enhancement
          Priority: P2
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18535

[Bug middle-end/18535] fix_irreducible_loops could be improved

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-20 18:42 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-11-20 18:42:08
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18535

[Bug middle-end/18535] fix_irreducible_loops could be improved

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2007-07-09 05:42 -------
This function was removed by:
2006-08-30  Zdenek Dvorak <dvorakz@suse.cz>

        PR rtl-optimization/27735
        * cfgloopmanip.c (fix_loop_placements, fix_bb_placements, unloop):
        Add new argument to keep track of whether an irreducible region
        was affected.  All callers changed.
        (fix_irreducible_loops): Removed.
        (remove_path): Call mark_irreducible_loops if EDGE_IRREDUCIBLE_LOOP
        flags were invalidated.


So closing as fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18535