public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl at lucon dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/17982] [4.0 regression] asm declaration ignored due to conflict with previous rename
Date: Tue, 23 Nov 2004 21:13:00 -0000 [thread overview]
Message-ID: <20041123211352.16925.qmail@sourceware.org> (raw)
In-Reply-To: <20041013220543.17982.schwab@suse.de>
------- Additional Comments From hjl at lucon dot org 2004-11-23 21:13 -------
Does this patch
--- gcc/c-pragma.c.rename 2004-11-09 12:03:42.000000000 -0800
+++ gcc/c-pragma.c 2004-11-23 13:03:26.020304351 -0800
@@ -473,8 +473,11 @@ maybe_apply_renaming_pragma (tree decl,
return asmname;
/* If the DECL_ASSEMBLER_NAME is already set, it does not change,
- but we may warn about a rename that conflicts. */
- if (DECL_ASSEMBLER_NAME_SET_P (decl))
+ but we may warn about a rename that conflicts.
+ FIXME: the DECL_ASSEMBLER_NAME can be set to DECL_NAME (decl)
+ without renaming pragma nor asm declaration involved. */
+ if (DECL_ASSEMBLER_NAME_SET_P (decl)
+ && DECL_ASSEMBLER_NAME (decl) != DECL_NAME (decl))
{
const char *oldname = IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl));
oldname = targetm.strip_name_encoding (oldname);
make any senses? At least, it works with my testcases. -O0 and -O1 still
complain with
[hjl@gnu-4 gcc]$ ./xgcc -B./ -c x.i
x.i:8: warning: foo renamed after being referenced in assembly
[hjl@gnu-4 gcc]$
It may be OK since foo has been referenced in assembly. But I am not sure
about languanges other than C.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17982
next prev parent reply other threads:[~2004-11-23 21:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-13 22:05 [Bug target/17982] New: " schwab at suse dot de
2004-10-13 23:03 ` [Bug target/17982] " pinskia at gcc dot gnu dot org
2004-10-13 23:04 ` pinskia at gcc dot gnu dot org
2004-10-13 23:18 ` pinskia at gcc dot gnu dot org
2004-10-13 23:22 ` pinskia at gcc dot gnu dot org
2004-10-13 23:29 ` zack at codesourcery dot com
2004-10-13 23:49 ` pinskia at gcc dot gnu dot org
2004-11-09 15:47 ` schwab at suse dot de
2004-11-23 19:13 ` hjl at lucon dot org
2004-11-23 19:18 ` hjl at lucon dot org
2004-11-23 19:22 ` [Bug middle-end/17982] " pinskia at gcc dot gnu dot org
2004-11-23 21:13 ` hjl at lucon dot org [this message]
2004-11-23 22:20 ` zack at codesourcery dot com
2004-11-23 23:42 ` hjl at lucon dot org
2004-11-24 2:01 ` hjl at lucon dot org
2004-11-27 0:30 ` neroden at gcc dot gnu dot org
2004-11-27 20:25 ` zack at codesourcery dot com
2004-11-27 20:45 ` hjl at lucon dot org
2004-11-28 20:16 ` zack at codesourcery dot com
2004-11-28 22:48 ` schwab at suse dot de
2004-11-29 16:38 ` zack at codesourcery dot com
2004-11-29 17:07 ` schwab at suse dot de
2004-11-29 17:15 ` zack at codesourcery dot com
2004-11-29 18:47 ` hjl at lucon dot org
2004-12-08 19:13 ` cvs-commit at gcc dot gnu dot org
2004-12-08 20:01 ` pinskia at gcc dot gnu dot org
2004-12-08 22:04 ` [Bug middle-end/17982] stop calling assemble_external before final assembly output time zack at gcc dot gnu dot org
2004-12-08 22:05 ` zack at gcc dot gnu dot org
2005-04-05 1:54 ` pinskia at gcc dot gnu dot org
2005-07-05 2:10 ` pinskia at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041123211352.16925.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).