[Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator
@ 2004-02-13  5:47 pinskia at gcc dot gnu dot org
  2004-02-13  5:47 ` [Bug c++/14136] " pinskia at gcc dot gnu dot org
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-02-13  5:47 UTC (permalink / raw)
  To: gcc-bugs

Compile the following code you will recieve double the error message:
struct A1 {
  typedef A1 A2;
  ~A2();
};
tt.cc:3: error: typedef-name `A1::A2' used as destructor declarator
tt.cc:3: error: typedef-name `A1::A2' used as destructor declarator

It worked in 3.5.0 20040204 but not in 3.5.0 20040212

found when running my testcase library.

-- 
           Summary: [3.4?/3.5 Regression] double error message for typename
                    used as destructor declarator
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: minor
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [3.4?/3.5 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
@ 2004-02-13  5:47 ` pinskia at gcc dot gnu dot org
  2004-02-20 12:55 ` [Bug c++/14136] [3.5 " reichelt at gcc dot gnu dot org
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-02-13  5:47 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [3.5 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
  2004-02-13  5:47 ` [Bug c++/14136] " pinskia at gcc dot gnu dot org
@ 2004-02-20 12:55 ` reichelt at gcc dot gnu dot org
  2004-02-20 13:27 ` reichelt at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-02-20 12:55 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-02-20 12:55:43
               date|                            |
            Summary|[3.4?/3.5 Regression] double|[3.5 Regression] double
                   |error message for typename  |error message for typename
                   |used as destructor          |used as destructor
                   |declarator                  |declarator
   Target Milestone|3.4.0                       |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [3.5 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
  2004-02-13  5:47 ` [Bug c++/14136] " pinskia at gcc dot gnu dot org
  2004-02-20 12:55 ` [Bug c++/14136] [3.5 " reichelt at gcc dot gnu dot org
@ 2004-02-20 13:27 ` reichelt at gcc dot gnu dot org
  2004-02-20 13:43 ` giovannibajo at libero dot it
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-02-20 13:27 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2004-02-20 13:27 -------
Giovanni, the duplicate diagnostic appeared with your patch

http://gcc.gnu.org/ml/gcc-cvs/2004-02/msg00256.html

Could you please have a look?


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |giovannibajo at gcc dot gnu
                   |dot org                     |dot org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [3.5 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-02-20 13:27 ` reichelt at gcc dot gnu dot org
@ 2004-02-20 13:43 ` giovannibajo at libero dot it
  2004-11-27  0:00 ` [Bug c++/14136] [4.0 " pinskia at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: giovannibajo at libero dot it @ 2004-02-20 13:43 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From giovannibajo at libero dot it  2004-02-20 13:43 -------
Sure.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|giovannibajo at gcc dot gnu |giovannibajo at libero dot
                   |dot org                     |it


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2004-02-20 13:43 ` giovannibajo at libero dot it
@ 2004-11-27  0:00 ` pinskia at gcc dot gnu dot org
  2004-11-27  2:31 ` reichelt at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-11-27  0:00 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-27 00:00 -------
Any news it has been 9 months since you said you would look into it.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2004-11-27  0:00 ` [Bug c++/14136] [4.0 " pinskia at gcc dot gnu dot org
@ 2004-11-27  2:31 ` reichelt at gcc dot gnu dot org
  2004-11-30  0:42 ` reichelt at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-11-27  2:31 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2004-11-27 02:31 -------
The following patch fixes the error message for me.
I haven't done bootstrapping and regtesting, though.

Index: parser.c
===================================================================
RCS file: /usr/local/gcc/CVS/gcc-cvs/gcc/gcc/cp/parser.c,v
retrieving revision 1.276
diff -u -p -r1.276 parser.c
--- parser.c	3 Nov 2004 02:48:37 -0000	1.276
+++ parser.c	27 Nov 2004 07:07:14 -0000
@@ -3234,7 +3234,8 @@ cp_parser_unqualified_id (cp_parser* par
 	   identifier in the declarator for a destructor declaration.  */
 	if (declarator_p
 	    && !DECL_IMPLICIT_TYPEDEF_P (type_decl)
-	    && !DECL_SELF_REFERENCE_P (type_decl))
+	    && !DECL_SELF_REFERENCE_P (type_decl)
+	    && !cp_parser_committed_to_tentative_parse (parser))
 	  error ("typedef-name %qD used as destructor declarator",
 		 type_decl);
 
===================================================================


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2004-11-27  2:31 ` reichelt at gcc dot gnu dot org
@ 2004-11-30  0:42 ` reichelt at gcc dot gnu dot org
  2004-12-02 14:05 ` reichelt at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-11-30  0:42 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2004-11-30 00:42 -------
Btw, the patch passed bootstrap and regtesting.
But I have yet to find out how to make a proper testcase that checks for a
duplicate error message. I'd then modify g++.dg/parse/dtor2.C accordingly.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2004-11-30  0:42 ` reichelt at gcc dot gnu dot org
@ 2004-12-02 14:05 ` reichelt at gcc dot gnu dot org
  2004-12-15 17:46 ` reichelt at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-12-02 14:05 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2004-12-02 14:05 -------
Patch here:
http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00156.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|giovannibajo at libero dot  |reichelt at gcc dot gnu dot
                   |it                          |org
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2004-12-02 14:05 ` reichelt at gcc dot gnu dot org
@ 2004-12-15 17:46 ` reichelt at gcc dot gnu dot org
  2005-01-03 17:03 ` cvs-commit at gcc dot gnu dot org
  2005-01-03 17:04 ` reichelt at gcc dot gnu dot org
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-12-15 17:46 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2004-12-15 17:46 -------
Updated patch here:
http://gcc.gnu.org/ml/gcc-patches/2004-12/msg01138.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2004-12-15 17:46 ` reichelt at gcc dot gnu dot org
@ 2005-01-03 17:03 ` cvs-commit at gcc dot gnu dot org
  2005-01-03 17:04 ` reichelt at gcc dot gnu dot org
  10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-01-03 17:03 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-03 17:03 -------
Subject: Bug 14136

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	reichelt@gcc.gnu.org	2005-01-03 17:03:02

Modified files:
	gcc/cp         : ChangeLog parser.c 

Log message:
	PR c++/14136
	* parser.c (cp_parser_unqualified_id): Do not issue error message
	for typedef-name as destructor declarator when performing an
	uncommitted tentative parse.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4566&r2=1.4567
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.299&r2=1.300



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug c++/14136] [4.0 Regression] double error message for typename used as destructor declarator
  2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2005-01-03 17:03 ` cvs-commit at gcc dot gnu dot org
@ 2005-01-03 17:04 ` reichelt at gcc dot gnu dot org
  10 siblings, 0 replies; 12+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2005-01-03 17:04 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From reichelt at gcc dot gnu dot org  2005-01-03 17:04 -------
Fixed on mainline.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14136


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2005-01-03 17:04 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-13  5:47 [Bug c++/14136] New: [3.4?/3.5 Regression] double error message for typename used as destructor declarator pinskia at gcc dot gnu dot org
2004-02-13  5:47 ` [Bug c++/14136] " pinskia at gcc dot gnu dot org
2004-02-20 12:55 ` [Bug c++/14136] [3.5 " reichelt at gcc dot gnu dot org
2004-02-20 13:27 ` reichelt at gcc dot gnu dot org
2004-02-20 13:43 ` giovannibajo at libero dot it
2004-11-27  0:00 ` [Bug c++/14136] [4.0 " pinskia at gcc dot gnu dot org
2004-11-27  2:31 ` reichelt at gcc dot gnu dot org
2004-11-30  0:42 ` reichelt at gcc dot gnu dot org
2004-12-02 14:05 ` reichelt at gcc dot gnu dot org
2004-12-15 17:46 ` reichelt at gcc dot gnu dot org
2005-01-03 17:03 ` cvs-commit at gcc dot gnu dot org
2005-01-03 17:04 ` reichelt at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).