[Bug c/17610] New: Empty #include statement halts gcc

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug c/17610] New: Empty #include statement halts gcc
@ 2004-09-22 14:32 chappich at techfak dot uni-bielefeld dot de
  2004-09-22 18:14 ` [Bug preprocessor/17610] " pinskia at gcc dot gnu dot org
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: chappich at techfak dot uni-bielefeld dot de @ 2004-09-22 14:32 UTC (permalink / raw)
  To: gcc-bugs

The gcc binary halts if the source code contains an empty '#include' statement.
Prior versions, e.g. 3.3.1, used to print "empty file name in #include".

This can be easily reproduced with a one-line source file containing nothing
more than '#include ""'.

-- 
           Summary: Empty #include statement halts gcc
           Product: gcc
           Version: 3.4.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: chappich at techfak dot uni-bielefeld dot de
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
@ 2004-09-22 18:14 ` pinskia at gcc dot gnu dot org
  2004-09-22 21:18 ` [Bug preprocessor/17610] [3.4/4.0 Regression] " pinskia at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-09-22 18:14 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-22 18:13 -------
This might be correct behavior but unexpected, it reads from the stdio for empty include file names.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |preprocessor


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
  2004-09-22 18:14 ` [Bug preprocessor/17610] " pinskia at gcc dot gnu dot org
@ 2004-09-22 21:18 ` pinskia at gcc dot gnu dot org
  2004-09-22 21:56   ` Neil Booth
  2004-09-22 21:56 ` neil at daikokuya dot co dot uk
                   ` (6 subsequent siblings)
  8 siblings, 1 reply; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-09-22 21:18 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-22 21:18 -------
Confirmed, but I really would like a preprocessor person to say if this is expected behavior.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-09-22 21:18:20
               date|                            |
            Summary|Empty #include statement    |[3.4/4.0 Regression] Empty
                   |halts gcc                   |#include statement halts gcc
   Target Milestone|---                         |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 21:18 ` [Bug preprocessor/17610] [3.4/4.0 Regression] " pinskia at gcc dot gnu dot org
@ 2004-09-22 21:56   ` Neil Booth
  0 siblings, 0 replies; 11+ messages in thread
From: Neil Booth @ 2004-09-22 21:56 UTC (permalink / raw)
  To: pinskia at gcc dot gnu dot org; +Cc: gcc-bugs

pinskia at gcc dot gnu dot org wrote:-

> 
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-22 21:18 -------
> Confirmed, but I really would like a preprocessor person to say if this is expected behavior.

Nope, it should be rejected outright like prior versions of GCC did.


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
  2004-09-22 18:14 ` [Bug preprocessor/17610] " pinskia at gcc dot gnu dot org
  2004-09-22 21:18 ` [Bug preprocessor/17610] [3.4/4.0 Regression] " pinskia at gcc dot gnu dot org
@ 2004-09-22 21:56 ` neil at daikokuya dot co dot uk
  2004-11-01  0:47 ` mmitchel at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: neil at daikokuya dot co dot uk @ 2004-09-22 21:56 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From neil at daikokuya dot co dot uk  2004-09-22 21:56 -------
Subject: Re:  [3.4/4.0 Regression] Empty #include statement halts gcc

pinskia at gcc dot gnu dot org wrote:-

> 
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-22 21:18 -------
> Confirmed, but I really would like a preprocessor person to say if this is expected behavior.

Nope, it should be rejected outright like prior versions of GCC did.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
                   ` (2 preceding siblings ...)
  2004-09-22 21:56 ` neil at daikokuya dot co dot uk
@ 2004-11-01  0:47 ` mmitchel at gcc dot gnu dot org
  2004-11-27 20:30 ` neroden at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-11-01  0:47 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-11-01 00:46 -------
Postponed until GCC 3.4.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.3                       |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
                   ` (3 preceding siblings ...)
  2004-11-01  0:47 ` mmitchel at gcc dot gnu dot org
@ 2004-11-27 20:30 ` neroden at gcc dot gnu dot org
  2004-11-27 22:50 ` neroden at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: neroden at gcc dot gnu dot org @ 2004-11-27 20:30 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2004-09-22 21:18:20         |2004-11-27 20:30:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
                   ` (4 preceding siblings ...)
  2004-11-27 20:30 ` neroden at gcc dot gnu dot org
@ 2004-11-27 22:50 ` neroden at gcc dot gnu dot org
  2004-11-28 22:28 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: neroden at gcc dot gnu dot org @ 2004-11-27 22:50 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From neroden at gcc dot gnu dot org  2004-11-27 22:50 -------
I took this.  Patch is at http://gcc.gnu.org/ml/gcc-patches/2004-11/msg02423. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4/4.0 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
                   ` (5 preceding siblings ...)
  2004-11-27 22:50 ` neroden at gcc dot gnu dot org
@ 2004-11-28 22:28 ` cvs-commit at gcc dot gnu dot org
  2004-12-02  2:33 ` [Bug preprocessor/17610] [3.4 " cvs-commit at gcc dot gnu dot org
  2004-12-02  2:37 ` neroden at gcc dot gnu dot org
  8 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-11-28 22:28 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-11-28 22:28 -------
Subject: Bug 17610

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	neroden@gcc.gnu.org	2004-11-28 22:28:13

Modified files:
	libcpp         : ChangeLog directives.c 
	gcc            : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg/cpp: empty-include.c 

Log message:
	(libcpp)
	PR preprocessor/17610
	* directives.c (do_include_common): Error out if an empty filename
	is given for #include (or #include_next or #import).
	
	(gcc)
	PR preprocessor/17610
	* testsuite/gcc.dg/cpp/empty-include.c: New testcase.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&r1=1.43&r2=1.44
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/directives.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.6602&r2=2.6603
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/empty-include.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
                   ` (6 preceding siblings ...)
  2004-11-28 22:28 ` cvs-commit at gcc dot gnu dot org
@ 2004-12-02  2:33 ` cvs-commit at gcc dot gnu dot org
  2004-12-02  2:37 ` neroden at gcc dot gnu dot org
  8 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-12-02  2:33 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-02 02:32 -------
Subject: Bug 17610

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	neroden@gcc.gnu.org	2004-12-02 02:32:22

Modified files:
	gcc            : ChangeLog c-opts.c c-ppoutput.c cpplib.c 
Added files:
	gcc/testsuite/gcc.dg/cpp: empty-include.c 

Log message:
	2004-12-01  Nathanael Nerode  <neroden@gcc.gnu.org>
	
	PR preprocessor/17651
	* c-opts.c (sanitize_cpp_opts): Make flag_no_output imply
	flag_no_line_commands.
	* c-ppoutput.c (pp_file_change): Remove now-redundant check of
	flag_no_output.
	
	PR preprocessor/17610
	* directives.c (do_include_common): Error out if an empty filename
	is given for #include (or #include_next or #import).
	PR preprocessor/17610
	* testsuite/gcc.dg/cpp/empty-include.c: New testcase.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.713&r2=2.2326.2.714
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-opts.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.96.4.8&r2=1.96.4.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-ppoutput.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.11.12.3&r2=1.11.12.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cpplib.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.355.4.2&r2=1.355.4.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/empty-include.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.4.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug preprocessor/17610] [3.4 Regression] Empty #include statement halts gcc
  2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
                   ` (7 preceding siblings ...)
  2004-12-02  2:33 ` [Bug preprocessor/17610] [3.4 " cvs-commit at gcc dot gnu dot org
@ 2004-12-02  2:37 ` neroden at gcc dot gnu dot org
  8 siblings, 0 replies; 11+ messages in thread
From: neroden at gcc dot gnu dot org @ 2004-12-02  2:37 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From neroden at gcc dot gnu dot org  2004-12-02 02:37 -------
fix in 3.4 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17610


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2004-12-02  2:37 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-22 14:32 [Bug c/17610] New: Empty #include statement halts gcc chappich at techfak dot uni-bielefeld dot de
2004-09-22 18:14 ` [Bug preprocessor/17610] " pinskia at gcc dot gnu dot org
2004-09-22 21:18 ` [Bug preprocessor/17610] [3.4/4.0 Regression] " pinskia at gcc dot gnu dot org
2004-09-22 21:56   ` Neil Booth
2004-09-22 21:56 ` neil at daikokuya dot co dot uk
2004-11-01  0:47 ` mmitchel at gcc dot gnu dot org
2004-11-27 20:30 ` neroden at gcc dot gnu dot org
2004-11-27 22:50 ` neroden at gcc dot gnu dot org
2004-11-28 22:28 ` cvs-commit at gcc dot gnu dot org
2004-12-02  2:33 ` [Bug preprocessor/17610] [3.4 " cvs-commit at gcc dot gnu dot org
2004-12-02  2:37 ` neroden at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).