[Bug fortran/18993] New: gfortran fails to recognise comment line.

[Bug fortran/18993] New: gfortran fails to recognise comment line.

[tow21 at cam dot ac dot uk]

With the attached code, gfortran fails to understand that the second comment 
is a comment, and complains about an unclassified statement. 
 
parabrisas% gfortran -c bug5.F  
 In file bug5.F:5 
 
C Set default sizes for order N arrays                                          
1 
Error: Non-numeric character in statement label at (1) 
 In file bug5.F:5 
 
C Set default sizes for order N arrays                                          
1 
Error: Unclassifiable statement at (1) 
 
parabrisas% cat bug5.F 
      subroutine ordern( ) 
      real, pointer :: aux(:,:) 
C Nullify pointers 
        nullify(aux) 
C Set default sizes for order N arrays 
      end subroutine ordern

-- 
           Summary: gfortran fails to recognise comment line.
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tow21 at cam dot ac dot uk
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] gfortran fails to recognise comment line.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-14 18:34 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |rejects-valid
   Last reconfirmed|0000-00-00 00:00:00         |2004-12-14 18:34:09
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] gfortran fails to recognise comment line.

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-14 22:24 -------
This is unrelated to preprocessing (changing the extension to .f doesn't solve
the problem). Changing 'C' to '!' fixes the problem.

It looks like the scanner is mistaken about the column count.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] incorrect parsing in fixed-form

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-15 17:33 -------
This is much worse than it seems. The problem is in statement matching, e.g. we
accept this, as if there was a semicolon on the indicated line:
      subroutine ordern( ) 
      real, pointer :: aux(:,:) 
C Nullify pointers 
        nullify(aux) i = i + 1 !<------ SYNTAX ERROR
C Set default sizes for order N arrays 
      end subroutine ordern

the problem is that we don't match the end of statement correctly. I have a
patch which addresses this case, but this problem will quite probably affect
other statements as well, so I'm looking into those first.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org
           Severity|normal                      |critical
           Keywords|                            |accepts-invalid
            Summary|gfortran fails to recognise |incorrect parsing in fixed-
                   |comment line.               |form


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] incorrect parsing in fixed-form

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-15 18:03 -------
Patch here: http://gcc.gnu.org/ml/fortran/2004-12/msg00161.html

After visual inspection of the statement matchers this problem only seems to
affect gfc_match_nullify.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
   Last reconfirmed|2004-12-14 18:34:09         |2004-12-15 18:03:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] incorrect parsing in fixed-form

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-15 18:56 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] incorrect parsing in fixed-form

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-15 18:56 -------
Subject: Bug 18993

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tobi@gcc.gnu.org	2004-12-15 18:55:57

Modified files:
	gcc/fortran    : ChangeLog match.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gfortran.dg: nullify_1.f 

Log message:
	fortran/
	PR fortran/18993
	* match.c (gfc_match_if): Don't explicitly skip optional whitespace.
	(gfc_match_nullify): Make sure that ')' is in front of the end of
	statement.
	
	testsuite/
	PR fortran/18993
	* gfotran.dg/nullify_1.f: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.273&r2=1.274
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/match.c.diff?cvsroot=gcc&r1=1.26&r2=1.27
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4765&r2=1.4766
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/nullify_1.f.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993

[Bug fortran/18993] incorrect parsing in fixed-form

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=18993