[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-06-05 20:32 -------
Richard, Joseph --

As C front end maintainers, can one of you look at this?

-- Mark

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm at polyomino dot org dot
                   |                            |uk, rth at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-06-06 22:13 -------
Subject: Re:  [3.3/3.4/3.5 Regression] [tree-ssa]
 ice-on-invalid-code, ICE while compiling ({}) expression

The following patch looks from some tests of patched cc1 like it will fix
this particular issue, but it needs full tests - on both mainline and 3.4
branch, given they show the problem in different places.  I'll do the
requisite four bootstraps and testsuite runs tomorrow.

It's not however a general fix of all such issues, as the last_expr_type
mechanism seems a fragile kludge and other cases fail to get detected as
not ending with an expression statement (and then on mainline fail in
gimplification).  For example,

void f (void) { int a = ({ while (1) 2; }); }

(ICE on mainline only; regression from 2.95 which detected this case) -
last_expr_type is reset after if statements, but not while statements.  
Things could probably be done more cleanly and easily if the C front end
generated GENERIC (and the types of the expressions used for statements
would be kept up so that the type of a statement expression follows
immediately from that of the COMPOUND_EXPR for the contained compound
statement, while the type for one used as a block not in a statement
expression would be set to void).  If that's not done in time for 3.5/4.0
then we can look at local fixes for all the cases where last_expr_type
isn't reset.

2004-06-06  Joseph S. Myers  <jsm@polyomino.org.uk>

	PR c/14765
	* c-parse.in (compstmt_primary_start): Set last_expr_type to
	NULL_TREE.

2004-06-06  Joseph S. Myers  <jsm@polyomino.org.uk>

	PR c/14765
	* gcc.dg/pr14765-1.c: New test.

diff -rupN gcc.orig/c-parse.in gcc/c-parse.in
--- gcc.orig/c-parse.in	2004-02-08 20:52:50.000000000 +0000
+++ gcc/c-parse.in	2004-06-06 21:40:00.000000000 +0000
@@ -2161,6 +2161,7 @@ compstmt_primary_start:
 		  keep_next_level ();
 		  compstmt_count++;
 		  $$ = add_stmt (build_stmt (COMPOUND_STMT, last_tree));
+		  last_expr_type = NULL_TREE;
 		}
         ;
 
diff -rupN gcc.orig/testsuite/gcc.dg/pr14765-1.c gcc/testsuite/gcc.dg/pr14765-1.c
--- gcc.orig/testsuite/gcc.dg/pr14765-1.c	1970-01-01 00:00:00.000000000 +0000
+++ gcc/testsuite/gcc.dg/pr14765-1.c	2004-06-06 21:43:14.000000000 +0000
@@ -0,0 +1,11 @@
+/* Empty statement expressions should get void type.  Bug 14765 from
+   Serge Belyshev <belyshev@lubercy.com>.  */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+int a;
+void fun ()
+{
+	a = 0;
+	a = ({}); /* { dg-error "not ignored" "void stmt expr" } */
+}



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-06-06 22:36 -------
(In reply to comment #4)
> Things could probably be done more cleanly and easily if the C front end
> generated GENERIC ...

I'm actively working on this.  Indeed, the given test case already does
not fail with my revised code.  This patch is appropriate for the 
release branches, however.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-06-07 14:28 -------
Subject: Re:  [3.3/3.4/3.5 Regression] [tree-ssa]
 ice-on-invalid-code, ICE while compiling ({}) expression

Joseph S. Myers wrote:

> The following patch looks from some tests of patched cc1 like it will fix
> this particular issue, but it needs full tests - on both mainline and 3.4
> branch, given they show the problem in different places.  I'll do the
> requisite four bootstraps and testsuite runs tomorrow.

Thanks.  This kind of incremental approach is certainly fine for 3.4.1, 
not that you need my approval for C front end changes at this point. 
You're right that this stuff is very fragile.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-07 19:49 -------
Subject: Bug 14765

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	jsm28@gcc.gnu.org	2004-06-07 19:49:31

Modified files:
	gcc            : ChangeLog c-parse.in 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: pr14765-1.c 

Log message:
	PR c/14765
	* c-parse.in (compstmt_primary_start): Set last_expr_type to
	NULL_TREE.
	
	testsuite:
	* gcc.dg/pr14765-1.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3866&r2=2.3867
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-parse.in.diff?cvsroot=gcc&r1=1.206&r2=1.207
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.3820&r2=1.3821
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr14765-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-07 19:52 -------
Subject: Bug 14765

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	jsm28@gcc.gnu.org	2004-06-07 19:52:56

Modified files:
	gcc            : ChangeLog c-parse.in 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: pr14765-1.c 

Log message:
	PR c/14765
	* c-parse.in (compstmt_primary_start): Set last_expr_type to
	NULL_TREE.
	
	testsuite:
	* gcc.dg/pr14765-1.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.474&r2=2.2326.2.475
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-parse.in.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.194.2.4&r2=1.194.2.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.198&r2=1.3389.2.199
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr14765-1.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-07 19:59 -------
PR 15243 is another case which RTH already have fixed with his rewrite.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |15243
      Known to fail|3.3.4 3.4.0 3.5.0 tree-ssa  |3.3.4 tree-ssa 3.2.3 3.2.2
                   |3.2.3 3.2.2 3.1             |3.1
      Known to work|2.95.3 3.0.4                |2.95.3 3.0.4 3.4.0 3.5.0
   Target Milestone|3.4.1                       |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[pinskia at gcc dot gnu dot org]

-- 
Bug 14765 depends on bug 15243, which changed state.

Bug 15243 Summary: [3.5 regression] ICE on statement expression (return void) inside a statement expression
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15243

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3/3.4/3.5 Regression] [tree-ssa] ice-on-invalid-code, ICE while compiling ({}) expression

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-16 07:03 -------
Fixed for 3.4.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.5.0                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-06-16 10:27 -------
JSM, I assume you are waiting for 3.3 branch defreeze to commit this patch 
there? Because this bug is still actual on the 3.3 branch as we speak

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |
            Summary|[3.3/3.4/3.5 Regression]    |[3.3 Regression] ice-on-
                   |[tree-ssa] ice-on-invalid-  |invalid-code, ICE while
                   |code, ICE while compiling   |compiling ({}) expression
                   |({}) expression             |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-06-16 10:37 -------
Subject: Re:  [3.3 Regression] ice-on-invalid-code,
 ICE while compiling ({}) expression

On Wed, 16 Jun 2004, giovannibajo at libero dot it wrote:

> JSM, I assume you are waiting for 3.3 branch defreeze to commit this patch 
> there? Because this bug is still actual on the 3.3 branch as we speak

I don't have a 3.3 branch CVS tree - I only generally keep mainline and
the most recent release branch checked out - and haven't tested this patch
on 3.3 branch; if it applies there and passes testing I see no problem
with applying it there, it should be a safe patch.  As well as keeping
three CVS trees, preparing patches for three versions would involve six
bootstraps and testsuite runs....



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-06-16 11:04 -------
> As well as keeping three CVS trees, preparing patches for three versions would
> involve six bootstraps and testsuite runs....

I think you can reasonably cut that by half, either by regularly doing nightly
builds and using them as base compilers or, since you test on i686-pc-linux-gnu,
by using gcc-testresults as the base results.

I've been using both methods (for SPARC and x86 respectively) for a couple of
years and this works pretty well.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug tree-optimization/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.1                       |3.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug c/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2004-09-28 13:29 -------
Adjust milestone

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.5                       |3.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug c/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2004-12-15 16:59 -------
Joseph's patch indeed fixes the problem on the 3.3 branch.
Bootstrap and regtests under way.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |reichelt at gcc dot gnu dot
                   |dot org                     |org
             Status|REOPENED                    |ASSIGNED
           Keywords|                            |monitored, patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug c/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2004-12-16 12:54 -------
Bootstrapped and regtested on 3.3 branch.

Gaby, is it ok to commit the patch in comment #4 to the 3.3 branch?
Do we need the testcase?


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gdr at gcc dot gnu dot org
      Known to fail|3.4.0 3.3.4 tree-ssa 3.2.3  |3.4.0 3.3.5 3.3 3.2.3 3.1
                   |3.2.2 3.1                   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug c/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[gdr at integrable-solutions dot net]

------- Additional Comments From gdr at integrable-solutions dot net  2004-12-16 14:05 -------
Subject: Re:  [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

"reichelt at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| Bootstrapped and regtested on 3.3 branch.
| 
| Gaby, is it ok to commit the patch in comment #4 to the 3.3 branch?
| Do we need the testcase?

This bug seems to have an interesting history...

yes, if you can pleas apply it.

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug c/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-21 21:51 -------
Subject: Bug 14765

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	reichelt@gcc.gnu.org	2004-12-21 21:51:29

Modified files:
	gcc            : ChangeLog c-parse.in 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: pr14765-1.c 

Log message:
	PR c/14765
	* c-parse.in (compstmt_primary_start): Set last_expr_type to
	NULL_TREE.
	
	* gcc.dg/pr14765-1.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.1043&r2=1.16114.2.1044
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-parse.in.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.152.14.1&r2=1.152.14.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.2261.2.392&r2=1.2261.2.393
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr14765-1.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=NONE&r2=1.1.48.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765

[Bug c/14765] [3.3 Regression] ice-on-invalid-code, ICE while compiling ({}) expression

[reichelt at gcc dot gnu dot org]

------- Additional Comments From reichelt at gcc dot gnu dot org  2004-12-21 21:53 -------
Now also fixed on the 3.3 branch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14765