[Bug fortran/19101] New: missing & in character continuation not caught

[Bug fortran/19101] New: missing & in character continuation not caught

[Thomas dot Koenig at online dot de]

The following code is erroneous because
there's a & missing in the continuation
line:

$ cat char-cont-wrong.f90
program main
  character (len=40) c
  c = "Hello, &
       world!"
  print *,c
end program main
$ gfortran char-cont-wrong.f90
$ ./a.out
 Hello,        world!

I think a diagnostic is needed for this case.

-- 
           Summary: missing & in character continuation not caught
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: Thomas dot Koenig at online dot de
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |accepts-invalid, diagnostic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[eedelman at acclab dot helsinki dot fi]

------- Additional Comments From eedelman at acclab dot helsinki dot fi  2004-12-25 00:41 -------
I think the result given by gfortran is correct.  Quote from "Fortran 95
handbook" by Adams, Brainerd et al., section 3.3.1.1

"""
To continue a character constant so that the continued line is indented, an
ampersand must be used as the first character of the continued line, as in:

NAME = "Mary K. W&
       &illiams"

In this case, the first nonblank character on the next line [...] must be an
ampersand because Williams is split between lines; _otherwise_ [emphasis mine]
the blanks at the beginning of the second line will be included as part of the
character constant
"""

If I understand this correctly, the & is not needed if you do want the blanks at
the beginning of the line included in the character constant (In your example
you probably do not want that, but how is the compiler supposed to know?).

On the other hand, it seems that the intel compiler wants the & anyway:

$ ifort -e95 char-cont-wrong.f90
fortcom: Warning: char-cont-wrong.f90, line 4: Missing ampersand in continued
character constant
       world!"
-------^

so perhaps I'm wrong.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[Thomas dot Koenig at online dot de]

------- Additional Comments From Thomas dot Koenig at online dot de  2004-12-25 09:31 -------
(In reply to comment #1)

The latest version of the F95 draft standard (isn't the world
of coypyrighted standards wonderful?) states

# If a character context is to be continued, the "&" shall be
# the last nonblank character on the line and shall not be
# followed by a commentary.  An "&" shall be the first nonblank
# character on the next line that is not a comment line and the
# statement continues with the next character following the "&".

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-27 21:41 -------
That's weird.  I wrote some of this originally, and I was sure that this has to
be interpreted in the way Erik quotes it. I double-checked the F95 and F2K
standards and they both agree with Thomas, but I have a book which I use as a
quick reference of the F90 standard which claims otherwise.  Maybe F90 was
different.

Confirmed nonetheless.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-12-27 21:41:42
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-27 21:47 -------
Actually, my misleading reference is by the same authors the same as Erik's,
it's the "Fortran 90 Handbook". Looks like they got it wrong.

I think I have a fix, it wasn't too hard :-)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2004-12-28 19:19 -------
I have a fix which issues the same error twice.

Unfortunately, continuation lines are eaten in the scanner, and there is no real
support for emitting errors from the scanner, as the same line may be rescanned
several times until one of the statement matchers succeeds.  I think the right
line of attack will be to modify the matcher for character literal strings to
deal with the continuation, and to issue the error from there, returning
MATCH_ERROR.

I'll look into doing this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #14 from jvdelisle at gcc dot gnu dot org  2006-04-07 21:20 -------
Fixed now on 4.1.1 and 4.2


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #13 from jvdelisle at gcc dot gnu dot org  2006-04-07 21:12 -------
Subject: Bug 19101

Author: jvdelisle
Date: Fri Apr  7 21:12:41 2006
New Revision: 112764

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112764
Log:
2006-04-07  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/19101
        * gfortran.dg/continuation.f90: New test.
        * gfortran.dg/fmt_read_bz_bn.f90: Fix use of continuation.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/continuation.f90
Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/fmt_read_bz_bn.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #12 from jvdelisle at gcc dot gnu dot org  2006-04-07 21:07 -------
Subject: Bug 19101

Author: jvdelisle
Date: Fri Apr  7 21:07:52 2006
New Revision: 112763

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112763
Log:
2006-04-07 Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/19101
        * gfortran.h: Add warn_ampersand.
        * invoke.texi: Add documentation for new option.
        * lang.opt: Add Wampersand.
        * options.c (gfc_init_options): Initialize warn_ampersand.
        (gfc_post_options): Set the warn if pedantic.
        (set_Wall): Set warn_ampersand.
        (gfc_handle_option: Add Wampersand for itself, -std=f95, and
-std=f2003.
        * scanner.c (gfc_next_char_literal): Add test for missing '&' in
        continued character constant and give warning if missing.

Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/gfortran.h
    branches/gcc-4_1-branch/gcc/fortran/invoke.texi
    branches/gcc-4_1-branch/gcc/fortran/lang.opt
    branches/gcc-4_1-branch/gcc/fortran/options.c
    branches/gcc-4_1-branch/gcc/fortran/scanner.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2006-03-15 07:08 -------
Subject: Bug 19101

Author: jvdelisle
Date: Wed Mar 15 07:08:06 2006
New Revision: 112079

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112079
Log:
2006-03-14  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/19101
        * gfortran.dg/continuation.f90: New test.
        * gfortran.dg/fmt_read_bz_bn.f90: Fix use of continuation.

Added:
    trunk/gcc/testsuite/gfortran.dg/continuation.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/fmt_read_bz_bn.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2006-03-15 07:03 -------
Subject: Bug 19101

Author: jvdelisle
Date: Wed Mar 15 07:03:20 2006
New Revision: 112078

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112078
Log:
2006-03-14  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/19101
        * gfortran.h: Add warn_ampersand.
        * invoke.texi: Add documentation for new option.
        * lang.opt: Add Wampersand.
        * options.c (gfc_init_options): Initialize warn_ampersand.
        (gfc_post_options): Set the warn if pedantic.
        (set_Wall): Set warn_ampersand.
        (gfc_handle_option: Add Wampersand for itself, -std=f95, and
-std=f2003.
        * scanner.c (gfc_next_char_literal): Add test for missing '&' in
        continued character constant and give warning if missing.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/invoke.texi
    trunk/gcc/fortran/lang.opt
    trunk/gcc/fortran/options.c
    trunk/gcc/fortran/scanner.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[patchapp at dberlin dot org]

------- Comment #9 from patchapp at dberlin dot org  2006-03-12 05:15 -------
Subject: Bug number PR19101

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00691.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2006-03-09 06:08 -------
A revised patch has been submitted that does what might be expected and issues
a warning on -pedantic if the ampersand is missing in a continued character
constant.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[patchapp at dberlin dot org]

------- Comment #7 from patchapp at dberlin dot org  2006-03-08 07:35 -------
Subject: Bug number PR19101

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00415.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2006-03-06 06:23 -------
I have found the fix for this.  It is simple.  Do we want to allow the missing
& and then give an error on -pedantic?

Intel allows the missing & and continues at the next non blank character.

How strict shall we go? per standard it "shall have".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101

[Bug fortran/19101] missing & in character continuation not caught

[jvdelisle at gcc dot gnu dot org]

-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-12-30 18:54:17         |2006-02-22 02:01:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19101