[Bug c++/14607] New: [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[Bug c++/14607] New: [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[danglin at gcc dot gnu dot org]

The following errors occured building groff-1.19 on the above target
with gcc version 3.3.4 20040306 (prerelease):

g++ -O2 -s -o troff dictionary.o div.o env.o glyphuni.o input.o majorminor.o nod
e.o number.o reg.o symbol.o unicode.o uniglyph.o uniuni.o /xxx/gnu/groff-1.19/ob
jdir3.3/src/libs/libgroff/libgroff.a  -lm
/usr/ccs/bin/ld: Duplicate symbol "vtable for node" in files div.o and env.o
/usr/ccs/bin/ld: Duplicate symbol "typeinfo for node" in files div.o and env.o
/usr/ccs/bin/ld: Duplicate symbol "typeinfo name for node" in files div.o and en
v.o
/usr/ccs/bin/ld: Duplicate symbol "vtable for node" in files div.o and input.o
/usr/ccs/bin/ld: Duplicate symbol "typeinfo for node" in files div.o and input.o
/usr/ccs/bin/ld: Duplicate symbol "typeinfo name for node" in files div.o and in
put.o
/usr/ccs/bin/ld: Duplicate symbol "vtable for node" in files div.o and node.o
/usr/ccs/bin/ld: Duplicate symbol "typeinfo for node" in files div.o and node.o
/usr/ccs/bin/ld: Duplicate symbol "typeinfo name for node" in files div.o and no
de.o

The problem doesn't occur with gcc 3.0.3.

I'm not sure of the the details as to when vtables should be emitted as
global objects.  The 3.3.4 assembler output has for example the following
code in div.o:

        .IMPORT _ZTV4node,DATA
	...
        .EXPORT _ZTV4node,DATA
        .align 8
_ZTV4node	
        .word   0
        .word   _ZTI4node
        .word   P%_ZN4nodeD1Ev
        .word   P%_ZN4nodeD0Ev
        .word   P%__cxa_pure_virtual
        .word   P%_ZN4node17set_unformat_flagEv
	...
_ZN4nodeD1Ev
        .PROC
        .CALLINFO FRAME=64,NO_CALLS
        .ENTRY
        addil LR'_ZTV4node-$global$,%r27
        ldo 64(%r30),%r30
        ldo RR'_ZTV4node-$global$+8(%r1),%r1
	...

The same code is duplicated in the assembler out put for env.cpp
and input.cpp.

The assembler output from 3.0.3 doesn't have or export the vtable for
node.  The table is only defined by input.o.

The hppa1.1-hp-hpux10.20 port doesn't support weak symbols.
In ports that support weak symbols, the vtables are weak avoiding
this problem.

I'm not sure of all the requirements for vtables.  For example, can
they be local to a translation unit and duplicated?

-- 
           Summary: [3.3 Regression] Duplicate symbol "vtable for node" in
                    files div.o and env.o
           Product: gcc
           Version: 3.3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: hppa1.1-hp-hpux10.20
  GCC host triplet: hppa1.1-hp-hpux10.20
GCC target triplet: hppa1.1-hp-hpux10.20


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
   Target Milestone|---                         |3.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.4                       |3.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2004-06-11 22:40 -------
Subject: Re:  [3.3 Regression] Duplicate symbol "vtable for nod

>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>    Target Milestone|3.3.4                       |3.3.5

I'm not sure this milestone is reasonable.  I did quite a bit
of investigation on this problem and came to the conclusion that
on targets that don't support one-only semantics we are more or
less scuppered by the C++ "ABI" used by GCC.

I have been testing a fix using the support for COMDAT that's
present in the hpux 10.20 linker to implement one-only support.
If I go ahead with this fix on [3.3/3.4], the new libstdc++
library will not be compatible with the previously installed
libraries.  I also note that using COMDAT instead on secondary
definition symbols (as in hpux 11) will make programs compiled
under hpux 10.20 incompatible with hpux 11.  As a result, any
existing old binaries will need recompilation and linking.  On
the other hand, C++ is more or less broken for any non trivial
programs at the moment.  So, implementing one-only support
would be a significant improvement.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

Re: [Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[Andrew Pinski]

> 
> 
> ------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2004-06-11 22:40 -------
> Subject: Re:  [3.3 Regression] Duplicate symbol "vtable for nod
> 
> >            What    |Removed                     |Added
> > ----------------------------------------------------------------------------
> >    Target Milestone|3.3.4                       |3.3.5
> 
> I'm not sure this milestone is reasonable.  I did quite a bit
> of investigation on this problem and came to the conclusion that
> on targets that don't support one-only semantics we are more or
> less scuppered by the C++ "ABI" used by GCC.

I had forgot to say the reason why I moved it is because 3.3.4 has been released
but not announced yet, you can see for your self in ftp://gcc.gnu.org/pub/gcc/releases.

Thanks,
Andrew Pinski

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[pinskia at physics dot uc dot edu]

------- Additional Comments From pinskia at physics dot uc dot edu  2004-06-11 22:45 -------
Subject: Re:  [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

> 
> 
> ------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2004-06-11 22:40 -------
> Subject: Re:  [3.3 Regression] Duplicate symbol "vtable for nod
> 
> >            What    |Removed                     |Added
> > ----------------------------------------------------------------------------
> >    Target Milestone|3.3.4                       |3.3.5
> 
> I'm not sure this milestone is reasonable.  I did quite a bit
> of investigation on this problem and came to the conclusion that
> on targets that don't support one-only semantics we are more or
> less scuppered by the C++ "ABI" used by GCC.

I had forgot to say the reason why I moved it is because 3.3.4 has been released
but not announced yet, you can see for your self in ftp://gcc.gnu.org/pub/gcc/releases.

Thanks,
Andrew Pinski



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2004-06-11 22:52 -------
Subject: Re:  [3.3 Regression] Duplicate symbol "vtable for nod

> > I'm not sure this milestone is reasonable.  I did quite a bit
> > of investigation on this problem and came to the conclusion that
> > on targets that don't support one-only semantics we are more or
> > less scuppered by the C++ "ABI" used by GCC.
> 
> I had forgot to say the reason why I moved it is because 3.3.4 has been
> released
> but not announced yet, you can see for your self in
> ftp://gcc.gnu.org/pub/gcc/releases.

I'm aware of that.  I was thinking that possibly the milestone
should be 3.5 because of the change in libstdc++ ABI required
for the fix.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-07-20 19:52 -------
Subject: Bug 14607

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	danglin@gcc.gnu.org	2004-07-20 19:52:13

Modified files:
	gcc            : ChangeLog 
	gcc/config/pa  : pa-hpux10.h pa-protos.h pa.c pa.h som.h 
	gcc/doc        : install.texi 

Log message:
	PR c++/14607
	* config/pa/pa-hpux10.h (SUPPORTS_ONE_ONLY): Define.
	(MAKE_DECL_ONE_ONLY): Undefine.
	* pa-protos.h (som_text_section_asm_op, one_only_readonly_data_section,
	readonly_data, one_only_data_section, forget_section): New prototypes.
	* pa.c (pa_init_machine_status, som_text_section_asm_op): New
	functions.
	(pa_select_section): Add one-only (COMDAT) support.
	* pa.h (struct machine_function): Define.
	* som.h (ASM_OUTPUT_FUNCTION_PREFIX): Delete.
	(TEXT_SECTION_ASM_OP): Call som_text_section_asm_op.
	(DEFAULT_TEXT_SECTION_ASM_OP, NEW_TEXT_SECTION_ASM_OP,
	ONE_ONLY_TEXT_SECTION_ASM_OP, ONE_ONLY_READONLY_DATA_SECTION_ASM_OP,
	ONE_ONLY_DATA_SECTION_ASM_OP): New defines.
	(EXTRA_SECTIONS): Add in_one_only_readonly_data and in_one_only_data.
	(EXTRA_SECTION_FUNCTIONS): Rework to use individual function macros.
	(READONLY_DATA_FUNCTION, ONE_ONLY_READONLY_DATA_SECTION_FUNCTION,
	ONE_ONLY_DATA_SECTION_FUNCTION, FORGET_SECTION_FUNCTION): New defines
	for EXTRA_SECTION_FUNCTIONS.
	* doc/install.texi: Update binutils requirements.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.4611&r2=2.4612
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa-hpux10.h.diff?cvsroot=gcc&r1=1.19&r2=1.20
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa-protos.h.diff?cvsroot=gcc&r1=1.34&r2=1.35
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.c.diff?cvsroot=gcc&r1=1.265&r2=1.266
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.h.diff?cvsroot=gcc&r1=1.227&r2=1.228
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/som.h.diff?cvsroot=gcc&r1=1.47&r2=1.48
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/install.texi.diff?cvsroot=gcc&r1=1.298&r2=1.299



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-15 04:14 -------
So closing as fixed in 3.5.0 as this requires an ABI change.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.3.5                       |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-28 04:51 -------
Subject: Bug 14607

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	danglin@gcc.gnu.org	2004-12-28 04:51:33

Modified files:
	gcc            : ChangeLog configure.ac configure config.in 
	gcc/config/pa  : pa-protos.h pa.c pa.h som.h 

Log message:
	PR c++/14607.
	Backported from main.
	* configure.ac (HAVE_GAS_NSUBSPA_COMDAT): Add check for .NSUBSPA
	COMDAT support.
	* configure. config.in: Rebuilt.
	* config/pa/pa-protos.h (som_text_section_asm_op,
	som_readonly_data_section, som_one_only_readonly_data_section,
	som_one_only_data_section, forget_section): Declare.
	* pa.c (override_options): Set init_machine_status to
	pa_init_machine_status.
	(pa_init_machine_status): New function.
	(pa_output_function_epilogue): Call forget_section if TARGET_SOM and
	TARGET_GAS.
	(pa_asm_output_mi_thunk): Likewise.
	(som_text_section_asm_op): New function.
	(pa_select_section): Call som_one_only_readonly_data_section and
	som_one_only_data_section when appropriate.
	* pa.h (struct machine_function): Define.
	(EXTRA_SECTIONS, EXTRA_SECTION_FUNCTIONS,
	SOM_READONLY_DATA_SECTION_FUNCTION,
	SOM_ONE_ONLY_READONLY_DATA_SECTION_FUNCTION
	SOM_ONE_ONLY_DATA_SECTION_FUNCTION, FORGET_SECTION_FUNCTION): New
	macros.
	* som.h (ASM_OUTPUT_FUNCTION_PREFIX): Delete.
	(TEXT_SECTION_ASM_OP): Call som_text_section_asm_op.
	(READONLY_DATA_ASM_OP, EXTRA_SECTIONS, EXTRA_SECTION_FUNCTIONS): Delete.
	(READONLY_DATA_SECTION): Call som_readonly_data_section when not PIC.
	(SUPPORTS_SOM_COMDAT): New define.
	(SUPPORTS_ONE_ONLY): True if SUPPORTS_WEAK or SUPPORTS_SOM_COMDAT.
	(MAKE_DECL_ONE_ONLY): Rework common support.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.755&r2=2.2326.2.756
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/configure.ac.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.6.2.18&r2=2.6.2.19
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/configure.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.794.2.20&r2=1.794.2.21
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config.in.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.181.4.5&r2=1.181.4.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa-protos.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.29.4.2&r2=1.29.4.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.235.4.8&r2=1.235.4.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.208.4.6&r2=1.208.4.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/som.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.47&r2=1.47.6.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607

[Bug c++/14607] [3.3 Regression] Duplicate symbol "vtable for node" in files div.o and env.o

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14607