public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/19182] New: Error messages seem to be printed slower
@ 2004-12-28 20:32 schnetter at aei dot mpg dot de
2004-12-28 20:45 ` [Bug fortran/19182] " pinskia at gcc dot gnu dot org
` (9 more replies)
0 siblings, 10 replies; 12+ messages in thread
From: schnetter at aei dot mpg dot de @ 2004-12-28 20:32 UTC (permalink / raw)
To: gcc-bugs
When I compare the speed of the screen output of, say, gcc and gfortran, then
it seems to me as if gfortran produced its output much more slowly. gcc's
output seems to appear line by line, whereas gfortran's output seems to appear
character by character. This could be caused by gfortran flushing after every
character instead of after every line or something similar. I'm wondering,
does gfortran do something special when it outputs diagnostic messages? There
has to be some difference -- gfortran's messages do look different, as
gfortran tries to print a cute "pointer" indicating the offending column,
which gcc does not.
--
Summary: Error messages seem to be printed slower
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Severity: minor
Priority: P2
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: schnetter at aei dot mpg dot de
CC: gcc-bugs at gcc dot gnu dot org
GCC build triplet: i686-pc-linux-gnu
GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
@ 2004-12-28 20:45 ` pinskia at gcc dot gnu dot org
2004-12-28 20:47 ` pinskia at gcc dot gnu dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-12-28 20:45 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-12-28 20:45 -------
They seem quick to me.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
2004-12-28 20:45 ` [Bug fortran/19182] " pinskia at gcc dot gnu dot org
@ 2004-12-28 20:47 ` pinskia at gcc dot gnu dot org
2004-12-28 21:41 ` tobi at gcc dot gnu dot org
` (7 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-12-28 20:47 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-12-28 20:47 -------
But seems slower than the C or C++ or java.
Java is more compariable in this case as it also outputs the context.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Keywords| |diagnostic
Last reconfirmed|0000-00-00 00:00:00 |2004-12-28 20:47:27
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
2004-12-28 20:45 ` [Bug fortran/19182] " pinskia at gcc dot gnu dot org
2004-12-28 20:47 ` pinskia at gcc dot gnu dot org
@ 2004-12-28 21:41 ` tobi at gcc dot gnu dot org
2004-12-28 22:31 ` schnetter at aei dot mpg dot de
` (6 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2004-12-28 21:41 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2004-12-28 21:41 -------
Does changing fputc to putc in line 95 of error.c enhance your 'experience'?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (2 preceding siblings ...)
2004-12-28 21:41 ` tobi at gcc dot gnu dot org
@ 2004-12-28 22:31 ` schnetter at aei dot mpg dot de
2004-12-28 22:34 ` Andrew Pinski
2004-12-28 22:35 ` pinskia at physics dot uc dot edu
` (5 subsequent siblings)
9 siblings, 1 reply; 12+ messages in thread
From: schnetter at aei dot mpg dot de @ 2004-12-28 22:31 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From schnetter at aei dot mpg dot de 2004-12-28 22:31 -------
I didn't try the putc vs. fputc change, but the patch below makes all the
difference:
$ cvs diff -u error.c
Index: error.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/fortran/error.c,v
retrieving revision 1.8
diff -u -r1.8 error.c
--- error.c 16 Sep 2004 16:00:41 -0000 1.8
+++ error.c 28 Dec 2004 22:26:52 -0000
@@ -74,6 +74,13 @@
static void
error_char (char c)
{
+ static int bufset = 0;
+ if (! bufset)
+ {
+ setvbuf (stderr, 0, _IOLBF, 0);
+ bufset = 1;
+ }
+
if (buffer_flag)
{
if (use_warning_buffer)
The call to setvbuf switches to line buffering, meaning that stderr is flushed
only after every line and not after every character. I assume that cc1 (as
opposed to f951) switches to line buffered stderr at some time, or else
outputs its error messages in some other way which is equivalent to some
internal buffering. f951 outputs its messages character by character, which
leads to an unnecessary overhead.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 22:31 ` schnetter at aei dot mpg dot de
@ 2004-12-28 22:34 ` Andrew Pinski
0 siblings, 0 replies; 12+ messages in thread
From: Andrew Pinski @ 2004-12-28 22:34 UTC (permalink / raw)
To: gcc-bugzilla; +Cc: gcc-bugs
On Dec 28, 2004, at 5:31 PM, schnetter at aei dot mpg dot de wrote:
>
> The call to setvbuf switches to line buffering, meaning that stderr is
> flushed
> only after every line and not after every character. I assume that
> cc1 (as
> opposed to f951) switches to line buffered stderr at some time, or else
> outputs its error messages in some other way which is equivalent to
> some
> internal buffering. f951 outputs its messages character by character,
> which
> leads to an unnecessary overhead.
Actually cc1 just uses fprintf instead of fputc so maybe that is the
problem, maybe we should be doing our own buffering.
-- Pinski
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (3 preceding siblings ...)
2004-12-28 22:31 ` schnetter at aei dot mpg dot de
@ 2004-12-28 22:35 ` pinskia at physics dot uc dot edu
2005-01-04 23:55 ` tobi at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: pinskia at physics dot uc dot edu @ 2004-12-28 22:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at physics dot uc dot edu 2004-12-28 22:34 -------
Subject: Re: Error messages seem to be printed slower
On Dec 28, 2004, at 5:31 PM, schnetter at aei dot mpg dot de wrote:
>
> The call to setvbuf switches to line buffering, meaning that stderr is
> flushed
> only after every line and not after every character. I assume that
> cc1 (as
> opposed to f951) switches to line buffered stderr at some time, or else
> outputs its error messages in some other way which is equivalent to
> some
> internal buffering. f951 outputs its messages character by character,
> which
> leads to an unnecessary overhead.
Actually cc1 just uses fprintf instead of fputc so maybe that is the
problem, maybe we should be doing our own buffering.
-- Pinski
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (4 preceding siblings ...)
2004-12-28 22:35 ` pinskia at physics dot uc dot edu
@ 2005-01-04 23:55 ` tobi at gcc dot gnu dot org
2005-01-08 0:05 ` tobi at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-01-04 23:55 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2005-01-04 23:55 -------
Patch here: http://gcc.gnu.org/ml/fortran/2005-01/msg00027.html
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (5 preceding siblings ...)
2005-01-04 23:55 ` tobi at gcc dot gnu dot org
@ 2005-01-08 0:05 ` tobi at gcc dot gnu dot org
2005-01-16 17:44 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-01-08 0:05 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2005-01-08 00:05 -------
New patch here: http://gcc.gnu.org/ml/fortran/2005-01/msg00060.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (6 preceding siblings ...)
2005-01-08 0:05 ` tobi at gcc dot gnu dot org
@ 2005-01-16 17:44 ` cvs-commit at gcc dot gnu dot org
2005-01-16 17:51 ` tobi at gcc dot gnu dot org
2005-01-16 17:55 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-01-16 17:44 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-01-16 17:44 -------
Subject: Bug 19182
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: pbrook@gcc.gnu.org 2005-01-16 17:44:17
Modified files:
gcc/fortran : ChangeLog error.c
Log message:
2005-01-16 Tobias Schlueter <tobias.schlueter@physik.uni-muenchen.de>
PR fortran/19182
* error.c (error_char): Line-buffer errors / warnings.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.300&r2=1.301
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/error.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (7 preceding siblings ...)
2005-01-16 17:44 ` cvs-commit at gcc dot gnu dot org
@ 2005-01-16 17:51 ` tobi at gcc dot gnu dot org
2005-01-16 17:55 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2005-01-16 17:51 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2005-01-16 17:51 -------
I believe this is fixed. Re-open if you disagree.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/19182] Error messages seem to be printed slower
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
` (8 preceding siblings ...)
2005-01-16 17:51 ` tobi at gcc dot gnu dot org
@ 2005-01-16 17:55 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-01-16 17:55 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19182
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2005-01-16 17:55 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-28 20:32 [Bug fortran/19182] New: Error messages seem to be printed slower schnetter at aei dot mpg dot de
2004-12-28 20:45 ` [Bug fortran/19182] " pinskia at gcc dot gnu dot org
2004-12-28 20:47 ` pinskia at gcc dot gnu dot org
2004-12-28 21:41 ` tobi at gcc dot gnu dot org
2004-12-28 22:31 ` schnetter at aei dot mpg dot de
2004-12-28 22:34 ` Andrew Pinski
2004-12-28 22:35 ` pinskia at physics dot uc dot edu
2005-01-04 23:55 ` tobi at gcc dot gnu dot org
2005-01-08 0:05 ` tobi at gcc dot gnu dot org
2005-01-16 17:44 ` cvs-commit at gcc dot gnu dot org
2005-01-16 17:51 ` tobi at gcc dot gnu dot org
2005-01-16 17:55 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).