public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "aoliva at redhat dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/19143] [4.0 regression] ICE on invalid template parameter Date: Wed, 29 Dec 2004 08:05:00 -0000 [thread overview] Message-ID: <20041229080441.14262.qmail@sourceware.org> (raw) In-Reply-To: <20041224013907.19143.reichelt@gcc.gnu.org> ------- Additional Comments From aoliva at redhat dot com 2004-12-29 08:04 ------- Subject: Re: New: [4.0 regression] ICE on invalid template parameter On Dec 23, 2004, "reichelt at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> wrote: > The following invalid code snippet triggers an ICE on mainline: > ============================================== > template<int> struct A; > template<> struct A<template> {}; > ============================================== > bug.cc:2: error: missing '>' to terminate the template argument list > bug.cc:2: error: template argument 1 is invalid > bug.cc:2: error: missing '>' to terminate the template argument list > bug.cc:2: error: template argument 1 is invalid > bug.cc:2: error: 'A' is not a template > bug.cc:2: error: missing '>' to terminate the template argument list > bug.cc:2: internal compiler error: Segmentation fault > Please submit a full bug report, [etc.] > Alexandre, this was causes by your path for PR18757: > http://gcc.gnu.org/ml/gcc-cvs/2004-12/msg00382.html > Could you please have a look? This patch fixes it, but I'm not entirely sure this is the best location for this test. Tested on amd64-linux-gnu, no failures. Ok to install? Index: gcc/cp/ChangeLog from Alexandre Oliva <aoliva@redhat.com> * pt.c (redeclare_class_template): Don't crash when parms parsing failed. Index: gcc/cp/pt.c =================================================================== RCS file: /cvs/gcc/gcc/gcc/cp/pt.c,v retrieving revision 1.962 diff -u -p -r1.962 pt.c --- gcc/cp/pt.c 23 Dec 2004 19:54:08 -0000 1.962 +++ gcc/cp/pt.c 29 Dec 2004 07:32:11 -0000 @@ -3234,6 +3234,11 @@ redeclare_class_template (tree type, tre type. */ return; + /* If the template parameters could not be parsed, assume we already + issued an error and bail out without crashing. */ + if (! parms) + return; + parms = INNERMOST_TEMPLATE_PARMS (parms); tmpl_parms = DECL_INNERMOST_TEMPLATE_PARMS (tmpl); -- Alexandre Oliva http://www.ic.unicamp.br/~oliva/ Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org} Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org} -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19143
next prev parent reply other threads:[~2004-12-29 8:05 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-12-24 1:39 [Bug c++/19143] New: " reichelt at gcc dot gnu dot org 2004-12-24 2:16 ` [Bug c++/19143] " pinskia at gcc dot gnu dot org 2004-12-29 8:05 ` aoliva at redhat dot com [this message] 2005-01-29 2:03 ` mmitchel at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20041229080441.14262.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).