public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "uros at kss-loka dot si" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/19240] [4.0 Regression] runtime performance regression in floating point heavy code, x86/SSE
Date: Mon, 03 Jan 2005 16:27:00 -0000	[thread overview]
Message-ID: <20050103162736.31473.qmail@sourceware.org> (raw)
In-Reply-To: <20050103131301.19240.tbptbp@gmail.com>


------- Additional Comments From uros at kss-loka dot si  2005-01-03 16:27 -------
Ah, I see the problem. Combine pass is producing reverse div/sub patterns, where
the first operand is a memory_operand and the second is a register.
Unfortunatelly, sse patterns doesn't provide reversed patterns:

(define_insn "*fop_sf_1_sse"
  [(set (match_operand:SF 0 "register_operand" "=x")
	(match_operator:SF 3 "binary_fp_operator"
			[(match_operand:SF 1 "register_operand" "0")
			 (match_operand:SF 2 "nonimmediate_operand" "xm")]))]
...

(define_insn "*fop_sf_1_i387"
  [(set (match_operand:SF 0 "register_operand" "=f,f")
	(match_operator:SF 3 "binary_fp_operator"
			[(match_operand:SF 1 "nonimmediate_operand" "0,fm")
			 (match_operand:SF 2 "nonimmediate_operand" "fm,0")]))]


SSE pattern isn't matched when first operand is memory operand and so it doesn't
shadow the 387 pattern. I think that fop_{s,d}f_1_i387 needs additional
constraint to hide them for TARGET_SSE. Perhaps:

&& !(TARGET_SSE && GET_CODE (operands[1]) == MEM)

and similar for DFmode.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-03 16:27:34
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19240


  parent reply	other threads:[~2005-01-03 16:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-03 13:13 [Bug rtl-optimization/19240] New: " tbptbp at gmail dot com
2005-01-03 13:14 ` [Bug rtl-optimization/19240] " tbptbp at gmail dot com
2005-01-03 15:06 ` [Bug target/19240] [4.0 Regression] " pinskia at gcc dot gnu dot org
2005-01-03 16:27 ` uros at kss-loka dot si [this message]
2005-01-03 20:39 ` rth at gcc dot gnu dot org
2005-01-04 10:41 ` cvs-commit at gcc dot gnu dot org
2005-01-04 15:43 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050103162736.31473.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).