[Bug objc/19324] New: [3.4/4.0 Regression] weird message for interface way in implementation

[Bug objc/19324] New: [3.4/4.0 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

@interface Foo
-(void) quux: (int [5])a;
@end

@implementation Foo
-(void) quux: (int *)a;
@end

With the mainline we get:
t.m: In function '-[Foo quux:]':
t.m:7: error: parse error before 'AT_NAME' token
t.m:7: warning: '@end' missing in implementation context

But with 3.3.2, we get:
t.m:7: error: parse error before "end"

3.4.0 is just as bad as 3.3.x:
t.m:7: error: parse error before 'CPP_AT_NAME' token
t.m:7: confused by earlier errors, bailing out

-- 
           Summary: [3.4/4.0 Regression] weird message for interface way in
                    implementation
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: minor
          Priority: P2
         Component: objc
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
      Known to fail|                            |3.4.0 4.0.0
      Known to work|                            |3.3.2
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-08 00:17:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zlaski at apple dot com
   Target Milestone|---                         |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0 Regression] weird message for interface way in implementation

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2005-01-19 22:46 -------
Objective-C is not part of the release criteria; removing target milestone.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.4                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-03-09 16:32 -------
4.1 Gives a better error message already:
t.m: In function ‘-[Foo quux:]’:
t.m:7: error: expected ‘{’ before ‘end’
t.m: At top level:
t.m:7: error: ‘void’ must be the only parameter

Though the last error  is still a regression.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2005-08-22 02:36 -------
Objective-C is not release-critical.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[lars dot sonchocky-helldorf at hamburg dot de]

------- Additional Comments From lars dot sonchocky-helldorf at hamburg dot de  2005-08-22 07:04 -------
(In reply to comment #3)
> Objective-C is not release-critical.

Sadly so. This is a very cheap way to get the numbers of bugs "down" for a release. :-(

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-03 03:12 -------
The patch for PR 20574 fixes the 4.1 regression.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |20574


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-03 17:56 -------
Patch posted here for 4.1:
http://gcc.gnu.org/ml/gcc-patches/2005-09/msg00174.html

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

-- 
Bug 19324 depends on bug 20574, which changed state.

Bug 20574 Summary: [4.1 Regression] weird error message after a parse error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20574

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-08 13:09 -------
Fixed on the mainline and is harder to fix any where else so closing as fixed since this is just a 
diagnostic problem.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324

[Bug objc/19324] [3.4/4.0/4.1 Regression] weird message for interface way in implementation

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-08 13:10 -------
Subject: Bug 19324

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2005-09-08 13:09:50

Modified files:
	gcc            : ChangeLog c-parser.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/objc.dg: error-1.m 

Log message:
	2005-09-08  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR objc/20574
	PR objc/19324
	* c-parser.c (c_parser_objc_method_definition): If the next
	token is not "{", error out and don't start the function.
	
	2005-09-08  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR objc/20574
	PR objc/19324
	* objc.dg/error-1.m: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9917&r2=2.9918
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-parser.c.diff?cvsroot=gcc&r1=2.21&r2=2.22
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.6027&r2=1.6028
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/objc.dg/error-1.m.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19324