[Bug c++/19399] New: gthread_recursive_mutex's missing

[Bug c++/19399] New: gthread_recursive_mutex's missing

[corsepiu at gcc dot gnu dot org]

GCC 4.0 has broken rtems thread support for all targets:

# configure --enable-languages=c,c++ --enable-threads=rtems\
[more options]
...
# make
...
/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/gcc/xgcc
-shared-libgcc
-B/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/gcc/
-nostdinc++
-L/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/arm-rtems4.7/libstdc++-v3/src
-L/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/arm-rtems4.7/libstdc++-v3/src/.libs
-nostdinc
-B/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/arm-rtems4.7/newlib/
-isystem
/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/arm-rtems4.7/newlib/targ-include
-isystem
/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/gcc-4.0.0/newlib/libc/include
-B/opt/rtems-4.7/arm-rtems4.7/bin/ -B/opt/rtems-4.7/arm-rtems4.7/lib/ -isystem
/opt/rtems-4.7/arm-rtems4.7/include -isystem
/opt/rtems-4.7/arm-rtems4.7/sys-include
-I/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/gcc-4.0.0/libstdc++-v3/../gcc
-I/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/arm-rtems4.7/libstdc++-v3/include/arm-rtems4.7
-I/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/arm-rtems4.7/libstdc++-v3/include
-I/users/rtems/src/rpms/BUILD/rtems-4.7-arm-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/gcc-4.0.0/libstdc++-v3/libsupc++
-O2 -g -O2 -g -O2 -fno-implicit-templates -Wall -Wextra -Wwrite-strings
-Wcast-qual -fdiagnostics-show-location=once -c
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc -o guard.o
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc:51: error:
'__gthread_recursive_mutex_t' does not name a type
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc:62: error:
'__gthread_recursive_mutex_t' does not name a type
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc: In static member function
'static void<unnamed>::static_mutex::lock()':
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc:81: error: 'mutex' was not
declared in this scope
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc:81: error:
'__gthread_recursive_mutex_lock' was not declared in this scope
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc: In static member function
'static void<unnamed>::static_mutex::unlock()':
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc:86: error: 'mutex' was not
declared in this scope
../../../../gcc-4.0.0/libstdc++-v3/libsupc++/guard.cc:86: error:
'__gthread_recursive_mutex_unlock' was not declared in this scope

Without having looked into details, something in GCC seems to have changed which
silently breaks gthr-rtems.h.

-- 
           Summary: gthread_recursive_mutex's missing
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: corsepiu at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,joel at gcc dot gnu dot
                    org
GCC target triplet: *-rtems*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug c++/19399] gthread_recursive_mutex's missing

[corsepiu at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug c++/19399] gthread_recursive_mutex's missing

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2005-01-12 14:50 -------
> Without having looked into details, something in GCC seems to have changed
> which silently breaks gthr-rtems.h.

Indeed, things rarely break without reason. :-)


It's

2004-08-27  Jason Merrill  <jason@redhat.com>

	PR c++/13684
	* gimplify.c (gimplify_cleanup_point_expr): Handle CLEANUP_EH_ONLY.
	(gimple_push_cleanup): Add eh_only parm.
	(gimplify_target_expr): Pass it.
	* c.opt (-fno-threadsafe-statics): New option.
	* c-opts.c (c_common_handle_option): Handle it.
	* c-common.h (flag_threadsafe_statics): Declare it.
	* c-common.c (flag_threadsafe_statics): Record it.
	* doc/invoke.texi: Document it.
	* tsystem.h (_GNU_SOURCE): Define.
	* gthr-posix.h (__gthread_recursive_mutex_t): New typedef.
	(__GTHREAD_RECURSIVE_MUTEX_INIT): New macro.
	(__GTHREAD_RECURSIVE_MUTEX_INIT_FUNCTION): New macro.
	(__gthread_recursive_mutex_init_function): New fn.
	(__gthread_recursive_mutex_lock): New fn.
	(__gthread_recursive_mutex_trylock): New fn.
	(__gthread_recursive_mutex_unlock): New fn.
	* gthr-solaris.h, gthr-single.h, gthr-dce.h: Likewise.
	* gthr-win32.h, gthr-vxworks.h: Likewise.
	* gthr.h: Document.

See gthr-win32.h or gthr-posix95.h or gthr-solaris.h for an example of
implementation of recursive mutexes.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-12 14:50:27
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug target/19399] [4.0 Regression] mutexes support broken

[ebotcazou at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |target
      Known to work|                            |3.4.0
            Summary|gthread_recursive_mutex's   |[4.0 Regression] mutexes
                   |missing                     |support broken
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug target/19399] [4.0 Regression] mutexes support broken

[joel at gcc dot gnu dot org]

------- Additional Comments From joel at gcc dot gnu dot org  2005-01-12 17:15 -------
(In reply to comment #3)

> I think the most flexible and simple solution would be to add a 
> rtems_gxx_recursive_mutex_init to RTEMS.
> 
> Also, I'd prefer to use this definition
> typedef void * __gthread_recursive_mutex_t;

Grrr.. looking back through the old mail and mail lists, that was indeed the 
intent when this was first mentioned.  I just added a new GCC patch and the
corresponding RTEMS patch (for reference).  What do you think of them?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug target/19399] [4.0 Regression] mutexes support broken

[corsepiu at gcc dot gnu dot org]

------- Additional Comments From corsepiu at gcc dot gnu dot org  2005-01-12 23:57 -------
(In reply to comment #6)
> (In reply to comment #3)

> What do you think of them?

pr19399-try2.diff looks good to me. I've just launched local test-builds,
nevertheless, OK to commit, IMO.

I haven't looked into rtems-gxx_wrappers.diff, yet.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug target/19399] [4.0 Regression] mutexes support broken

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-13 15:50 -------
Subject: Bug 19399

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	corsepiu@gcc.gnu.org	2005-01-13 15:50:13

Modified files:
	gcc            : ChangeLog gthr-rtems.h 

Log message:
	2005-01-13  Ralf Corsepius  <ralf.corsepius@rtems.org>
	Joel Sherrill  <joel@oarcorp.com>
	
	PR target/19399
	* gthr-rtems.h (__gthread_recursive_mutex_t): New type.
	(__GTHREAD_RECURSIVE_MUTEX_INIT_FUNCTION): Define to
	rtems_gxx_recursive_mutex_init.
	(__gthread_recursive_mutex_lock): New function.
	(__gthread_recursive_mutex_trylock): Likewise.
	(__gthread_recursive_mutex_unlock): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.7108&r2=2.7109
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/gthr-rtems.h.diff?cvsroot=gcc&r1=1.10&r2=1.11



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399

[Bug target/19399] [4.0 Regression] mutexes support broken

[corsepiu at gcc dot gnu dot org]

------- Additional Comments From corsepiu at gcc dot gnu dot org  2005-01-13 17:04 -------
Patches applied to trunk.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19399