[Bug ada/19388] New: [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

[Bug ada/19388] New: [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

[danglin at gcc dot gnu dot org]

gcc -D_XOPEN_UNIX -D_XOPEN_SOURCE_EXTENDED -D_INCLUDE__STDC_A1_SOURCE -D_INCLUDE
_XOPEN_SOURCE_500 -c   -g -DENABLE_CHECKING -DENABLE_ASSERT_CHECKING -DIN_GCC
-W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -mdisable-inde
xing    -fno-common   -DHAVE_CONFIG_H    -I. -Iada -I../../gcc/gcc -I../../gcc/g
cc/ada -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I/opt/gnu/i
nclude  ../../gcc/gcc/ada/utils.c -o ada/utils.o
../../gcc/gcc/ada/decl.c: In function `validate_alignment':
../../gcc/gcc/ada/decl.c:6165: error: `decl' undeclared (first use in this funct
ion)
../../gcc/gcc/ada/decl.c:6165: error: (Each undeclared identifier is reported on
ly once
../../gcc/gcc/ada/decl.c:6165: error: for each function it appears in.)

Unfortunately, the MAX_OFILE_ALIGNMENT on the PA under HP-UX depends on
whether or not a variable is placed in common.  The maximum alignment
in common is only 8 bytes.  I can't reduce MAX_OFILE_ALIGNMENT to 64 without
breaking other stuff.  In the other places where MAX_OFILE_ALIGNMENT is
used, I can access the declaration and do an appropriate test.  However,
this isn't going to work in ada/decl.c.

-- 
           Summary: [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: hppa*-*-hpux*
  GCC host triplet: hppa*-*-hpux*
GCC target triplet: hppa*-*-hpux*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19388

[Bug ada/19388] [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-12 02:32 -------
Hmm, I think pa abose of the macro really is the cause, maybe we should change the macro to 
dependent on the decl and then force the explicat use in the pa back-end so we don't run into this 
again?

What do people think, I think this is the best way to make sure that this does not happen again.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-12 02:32:09
               date|                            |
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19388

[Bug ada/19388] [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2005-01-12 02:53 -------
Subject: Re:  [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

> ------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-12
> 02:32 -------
> Hmm, I think pa abose of the macro really is the cause, maybe we should
> change the macro to 
> dependent on the decl and then force the explicat use in the pa back-end so
> we don't run into this 
> again?

I certainly agree that I abused the macro.  However, many people were
using the alignment attribute to request alignments that the linker
wasn't capable of providing without -fno-common.  This is critical for
when the decl is used for a semaphore lock.  They require 16-byte
alignment on the PA.  Also, I believe -fno-common only applies to C.
Thus, I think the above suggestion is a good one but the ada routine
doesn't have access to the decl.  The only other solution that I can
see is to give up using common for uninitialized data.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19388

[Bug ada/19388] [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-15 17:10 -------
Subject: Bug 19388

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	danglin@gcc.gnu.org	2005-01-15 17:10:02

Modified files:
	gcc            : ChangeLog 
	gcc/config/pa  : pa.c pa64-hpux.h som.h 

Log message:
	PR ada/19388
	* pa.c (pa_asm_output_aligned_common): Warn if specified alignment
	exceeds maximum alignment for global common data.
	* pa64-hpux.h (MAX_OFILE_ALIGNMENT): Define to 32768.
	* som.h (MAX_OFILE_ALIGNMENT): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.7139&r2=2.7140
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.c.diff?cvsroot=gcc&r1=1.282&r2=1.283
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa64-hpux.h.diff?cvsroot=gcc&r1=1.37&r2=1.38
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/som.h.diff?cvsroot=gcc&r1=1.52&r2=1.53



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19388

[Bug target/19388] [4.0 Regression] MAX_OFILE_ALIGNMENT on PA HP-UX

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-15 18:21 -------
Fixed, the remaining build failure is recorded in PR 19327.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
          Component|ada                         |target
           Keywords|                            |build
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19388