public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bernie at develer dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/19293] avr-gcc crashes when using shifts with negative shift count
Date: Wed, 19 Jan 2005 00:19:00 -0000 [thread overview]
Message-ID: <20050119001839.9146.qmail@sourceware.org> (raw)
In-Reply-To: <20050106160127.19293.bjoern.m.haase@web.de>
------- Additional Comments From bernie at develer dot com 2005-01-19 00:18 -------
(In reply to comment #3)
A quick informal review.
> if (GET_CODE (operands[2]) == CONST_INT)
> {
> int k;
>
> if (!len)
> len = &k;
> !
This line contains spurious whitespace.
> ! if ( (INTVAL(operands[2]) < 0) || (INTVAL(operands[2]) > 7) )
The coding standard requires a space between INTVAL and the
opening parenthesis.
Also remember to replace "<" with "<="!
> ! { /* illegal shift count */
> ! *len = 0;
> ! return "";
> ! }
The comment should stay on its own line, with
capitalized initial, a full stop (".") at the
end, followed by *two* whitespaces.
This also applies to the other hunks.
> const char *
> lshrhi3_out (rtx insn, rtx operands[], int *len)
> {
> if (GET_CODE (operands[2]) == CONST_INT)
> ! {
> int scratch = (GET_CODE (PATTERN (insn)) == PARALLEL);
> int ldi_ok = test_hard_reg_class (LD_REGS, operands[0]);
> int k;
This hunk adds spurious whitespace after the opening brace.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19293
next prev parent reply other threads:[~2005-01-19 0:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 16:01 [Bug c/19293] New: " bjoern dot m dot haase at web dot de
2005-01-06 16:53 ` [Bug target/19293] " pinskia at gcc dot gnu dot org
2005-01-06 17:35 ` bjoern dot m dot haase at web dot de
2005-01-06 18:03 ` joseph at codesourcery dot com
2005-01-06 18:57 ` bjoern dot m dot haase at web dot de
2005-01-06 22:00 ` ericw at evcohs dot com
2005-01-15 5:54 ` pinskia at gcc dot gnu dot org
2005-01-18 23:28 ` bjoern dot m dot haase at web dot de
2005-01-19 0:04 ` bernie at develer dot com
2005-01-19 0:09 ` bernie at develer dot com
2005-01-19 0:19 ` bernie at develer dot com [this message]
2005-01-19 5:17 ` schlie at comcast dot net
2005-01-19 5:26 ` schlie at comcast dot net
2005-01-19 21:25 ` bjoern dot m dot haase at web dot de
2005-01-20 5:46 ` bernie at develer dot com
2005-01-26 21:45 ` cvs-commit at gcc dot gnu dot org
2005-01-26 23:11 ` bernie at develer dot com
2005-01-27 22:36 ` cvs-commit at gcc dot gnu dot org
2005-01-27 22:59 ` pinskia at gcc dot gnu dot org
[not found] <bug-19293-9887@http.gcc.gnu.org/bugzilla/>
2007-02-05 19:44 ` pinskia at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050119001839.9146.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).