[Bug libfortran/19524] New: 5 times uninitialized var in libgfortran

[Bug libfortran/19524] New: 5 times uninitialized var in libgfortran

[marcus at jet dot franken dot de]

during bootstrap the compiler warns: 
 
../../../libgfortran/generated/matmul_l4.c:102: warning: 'astride' is used 
uninitialized in this function 
../../../libgfortran/generated/matmul_l4.c:109: warning: 'bstride' is used 
uninitialized in this function 
../../../libgfortran/generated/matmul_l8.c:102: warning: 'astride' is used 
uninitialized in this function 
../../../libgfortran/generated/matmul_l8.c:109: warning: 'bstride' is used 
uninitialized in this function 
../../../libgfortran/io/read.c:603: warning: 'buffer' is used uninitialized in 
this function 
 
and yes, astride and bstride are used uninitialized in those 2 files, and 
buffer can be used undefined too.

-- 
           Summary: 5 times uninitialized var in libgfortran
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: marcus at jet dot franken dot de
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524

[Bug libfortran/19524] 5 times uninitialized var in libgfortran

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2005-01-22 00:36 -------
The first four can be fixed by slightly reordering the contents of the functions
they're in.  I'm not proposing a patch, because I'm not completely sure why that
code is needed, and I'm too tired to look into this right now.  For the error in
read.c this patch should be sufficient, there's no path leading to bad_float on
which buffer is initialized.  I will regtest this tomorrow, and commit as
obvious if successful.

2005-01-22  Tobias Schl"uter  <tobias.schlueter@physik.un-muenchen.de>

        PR fortran/19524
        * io/read.c (read_f): Remove bogus if.

Index: read.c
===================================================================
RCS file: /cvs/gcc/gcc/libgfortran/io/read.c,v
retrieving revision 1.7
diff -u -p -r1.7 read.c
--- read.c      12 Jan 2005 21:27:31 -0000      1.7
+++ read.c      22 Jan 2005 00:32:45 -0000
@@ -600,8 +600,6 @@ read_f (fnode * f, char *dest, int lengt

  bad_float:
   generate_error (ERROR_READ_VALUE, "Bad value during floating point read");
-  if (buffer != scratch)
-     free_mem (buffer);
   return;

   /* At this point the start of an exponent has been found */


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-01-22 00:36:12
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524

[Bug libfortran/19524] 5 times uninitialized var in libgfortran

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-25 21:40 -------
Subject: Bug 19524

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tobi@gcc.gnu.org	2005-01-25 21:40:25

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/io : read.c 

Log message:
	PR libfortran/19524
	* io/read.c (read_f): Don't free uninitialized pointer.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.153&r2=1.154
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/read.c.diff?cvsroot=gcc&r1=1.7&r2=1.8



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524