public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/19528] New: [4.0 regression] missing ra.h
@ 2005-01-19 9:52 corsepiu at gcc dot gnu dot org
2005-01-19 12:22 ` [Bug target/19528] " steven at gcc dot gnu dot org
` (14 more replies)
0 siblings, 15 replies; 16+ messages in thread
From: corsepiu at gcc dot gnu dot org @ 2005-01-19 9:52 UTC (permalink / raw)
To: gcc-bugs
Today's (2005-01-19) gcc trunk does not build for sh-rtems*:
...
make[1]: Entering directory
`/users/rtems/src/rpms/BUILD/rtems-4.7-sh-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/gcc'
gcc -c -g -O2 -DIN_GCC -DCROSS_COMPILE -W -Wall -Wwrite-strings
-Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -fno-common
-DHAVE_CONFIG_H -I. -I. -I../../gcc-4.0.0/gcc -I../../gcc-4.0.0/gcc/.
-I../../gcc-4.0.0/gcc/../include -I../../gcc-4.0.0/gcc/../libcpp/include \
../../gcc-4.0.0/gcc/config/sh/sh.c -o sh.o
../../gcc-4.0.0/gcc/config/sh/sh.c:50:16: ra.h: No such file or directory
../../gcc-4.0.0/gcc/config/sh/sh.c: In function `push_regs':
../../gcc-4.0.0/gcc/config/sh/sh.c:5049: warning: implicit declaration of
function `hard_regs_intersect_p'
make[1]: *** [sh.o] Error 1
make[1]: Leaving directory
`/users/rtems/src/rpms/BUILD/rtems-4.7-sh-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/gcc'
As it seems to me, this patch might have broken the sh:
2005-01-17 Paolo Bonzini <bonzini@gnu.org>
* common.opt (-fnew-ra): Remove.
* ra*.*: Remove.
* toplev.h (flag_new_regalloc): Remove.
* Makefile.in (ra*.*): Don't mention.
* passes.c (rest_of_handle_new_regalloc): Remove.
(rest_of_handle_combine, rest_of_compilation): Always consider
flag_new_regalloc as false.
* doc/invoke.texi: Don't document -fnew-ra.
--
Summary: [4.0 regression] missing ra.h
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: target
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: corsepiu at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org,joel at oarcorp dot com
GCC target triplet: sh-rtems, sh-unknown-elf
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
@ 2005-01-19 12:22 ` steven at gcc dot gnu dot org
2005-01-19 12:26 ` steven at gcc dot gnu dot org
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-01-19 12:22 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From steven at gcc dot gnu dot org 2005-01-19 12:21 -------
I am not even going to try and look surprised, the SH port is a major
abuser of the middle-end. But of course, hard_regs_intersect_p should
have been in hard-reg-set.h from the start, *sigh*, mess-meets-mess.
Try this:
Index: hard-reg-set.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/hard-reg-set.h,v
retrieving revision 1.25
diff -u -3 -p -r1.25 hard-reg-set.h
--- hard-reg-set.h 15 Jan 2005 16:06:14 -0000 1.25
+++ hard-reg-set.h 19 Jan 2005 12:21:01 -0000
@@ -499,4 +499,19 @@ extern const char * reg_class_names[];
#define REG_CANNOT_CHANGE_MODE_P(REGN, FROM, TO) \
CANNOT_CHANGE_MODE_CLASS (FROM, TO, REGNO_REG_CLASS (REGN))
+/* Determine if two hard register sets intersect.
+ Return 1 if they do. */
+
+static inline bool
+hard_regs_intersect_p (HARD_REG_SET *a, HARD_REG_SET *b)
+{
+ HARD_REG_SET c;
+ COPY_HARD_REG_SET (c, *a);
+ AND_HARD_REG_SET (c, *b);
+ GO_IF_HARD_REG_SUBSET (c, reg_class_contents[(int) NO_REGS], lose);
+ return 1;
+lose:
+ return 0;
+}
+
#endif /* ! GCC_HARD_REG_SET_H */
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
2005-01-19 12:22 ` [Bug target/19528] " steven at gcc dot gnu dot org
@ 2005-01-19 12:26 ` steven at gcc dot gnu dot org
2005-01-19 12:55 ` paolo dot bonzini at lu dot unisi dot ch
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-01-19 12:26 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From steven at gcc dot gnu dot org 2005-01-19 12:26 -------
...and remove the #include "ra.h" of course.
Paolo, you should also update doc/passes.texi, which also still
has references to new-ra.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |bonzini at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-01-19 12:26:17
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
2005-01-19 12:22 ` [Bug target/19528] " steven at gcc dot gnu dot org
2005-01-19 12:26 ` steven at gcc dot gnu dot org
@ 2005-01-19 12:55 ` paolo dot bonzini at lu dot unisi dot ch
2005-01-19 13:27 ` bonzini at gcc dot gnu dot org
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: paolo dot bonzini at lu dot unisi dot ch @ 2005-01-19 12:55 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From paolo dot bonzini at lu dot unisi dot ch 2005-01-19 12:55 -------
Subject: Re: [4.0 regression] missing ra.h
steven at gcc dot gnu dot org wrote:
> ------- Additional Comments From steven at gcc dot gnu dot org 2005-01-19 12:26 -------
> ...and remove the #include "ra.h" of course.
Doh. I'm sorry for the breakage, but why the heck does the SH back-end
have to include it?
Why does the SH back-end have to behave different from every other one?^A^K
Paolo
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (2 preceding siblings ...)
2005-01-19 12:55 ` paolo dot bonzini at lu dot unisi dot ch
@ 2005-01-19 13:27 ` bonzini at gcc dot gnu dot org
2005-01-19 13:47 ` bonzini at gcc dot gnu dot org
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2005-01-19 13:27 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bonzini at gcc dot gnu dot org 2005-01-19 13:27 -------
I've fixed the doc/passes.texi (commit in progress).
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (3 preceding siblings ...)
2005-01-19 13:27 ` bonzini at gcc dot gnu dot org
@ 2005-01-19 13:47 ` bonzini at gcc dot gnu dot org
2005-01-19 13:48 ` pinskia at gcc dot gnu dot org
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2005-01-19 13:47 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bonzini at gcc dot gnu dot org 2005-01-19 13:47 -------
Steven, building cc1 to sh-unknown-elf with your patch succeeded.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (4 preceding siblings ...)
2005-01-19 13:47 ` bonzini at gcc dot gnu dot org
@ 2005-01-19 13:48 ` pinskia at gcc dot gnu dot org
2005-01-19 14:03 ` pinskia at gcc dot gnu dot org
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-01-19 13:48 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |build
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (5 preceding siblings ...)
2005-01-19 13:48 ` pinskia at gcc dot gnu dot org
@ 2005-01-19 14:03 ` pinskia at gcc dot gnu dot org
2005-01-19 16:35 ` corsepiu at gcc dot gnu dot org
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-01-19 14:03 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P3
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (6 preceding siblings ...)
2005-01-19 14:03 ` pinskia at gcc dot gnu dot org
@ 2005-01-19 16:35 ` corsepiu at gcc dot gnu dot org
2005-01-19 19:00 ` steven at gcc dot gnu dot org
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: corsepiu at gcc dot gnu dot org @ 2005-01-19 16:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From corsepiu at gcc dot gnu dot org 2005-01-19 16:35 -------
(In reply to comment #5)
> Steven, building cc1 to sh-unknown-elf with your patch succeeded.
Building sh-rtems4.7 with Steven's patch also succeeds.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (7 preceding siblings ...)
2005-01-19 16:35 ` corsepiu at gcc dot gnu dot org
@ 2005-01-19 19:00 ` steven at gcc dot gnu dot org
2005-01-21 17:34 ` mmitchel at gcc dot gnu dot org
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-01-19 19:00 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From steven at gcc dot gnu dot org 2005-01-19 18:59 -------
Good. Ralf, can you post it?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (8 preceding siblings ...)
2005-01-19 19:00 ` steven at gcc dot gnu dot org
@ 2005-01-21 17:34 ` mmitchel at gcc dot gnu dot org
2005-01-22 12:20 ` steven at gcc dot gnu dot org
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2005-01-21 17:34 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mmitchel at gcc dot gnu dot org 2005-01-21 17:33 -------
SH is not a primary or secondary platform; removing target milestone.
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.0 |---
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (9 preceding siblings ...)
2005-01-21 17:34 ` mmitchel at gcc dot gnu dot org
@ 2005-01-22 12:20 ` steven at gcc dot gnu dot org
2005-01-22 12:57 ` joel at gcc dot gnu dot org
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: steven at gcc dot gnu dot org @ 2005-01-22 12:20 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From steven at gcc dot gnu dot org 2005-01-22 12:19 -------
Mark, while you're using your RM powers to move the target milestone on
this one, could you also please use your GWP powers to approve the simple
patch http://gcc.gnu.org/ml/gcc-patches/2005-01/msg01258.html that fixes
this bug?
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (10 preceding siblings ...)
2005-01-22 12:20 ` steven at gcc dot gnu dot org
@ 2005-01-22 12:57 ` joel at gcc dot gnu dot org
2005-01-22 19:43 ` mark at codesourcery dot com
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: joel at gcc dot gnu dot org @ 2005-01-22 12:57 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From joel at gcc dot gnu dot org 2005-01-22 12:57 -------
(In reply to comment #10)
> Mark, while you're using your RM powers to move the target milestone on
> this one, could you also please use your GWP powers to approve the simple
> patch http://gcc.gnu.org/ml/gcc-patches/2005-01/msg01258.html that fixes
> this bug?
>
I can confirm that sh-rtems builds with this patch and won't without it.
The resulting compiler will also build RTEMS.
No sh target builds without this fix so I am also politely asking this to
be committed.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (11 preceding siblings ...)
2005-01-22 12:57 ` joel at gcc dot gnu dot org
@ 2005-01-22 19:43 ` mark at codesourcery dot com
2005-01-24 16:22 ` pinskia at gcc dot gnu dot org
2005-04-20 2:03 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 16+ messages in thread
From: mark at codesourcery dot com @ 2005-01-22 19:43 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mark at codesourcery dot com 2005-01-22 19:43 -------
Subject: Re: [4.0 regression] missing ra.h
joel at gcc dot gnu dot org wrote:
> ------- Additional Comments From joel at gcc dot gnu dot org 2005-01-22 12:57 -------
> (In reply to comment #10)
>
>>Mark, while you're using your RM powers to move the target milestone on
>>this one, could you also please use your GWP powers to approve the simple
>>patch http://gcc.gnu.org/ml/gcc-patches/2005-01/msg01258.html that fixes
>>this bug?
>>
>
>
> I can confirm that sh-rtems builds with this patch and won't without it.
> The resulting compiler will also build RTEMS.
>
> No sh target builds without this fix so I am also politely asking this to
> be committed.
The patch should says "Returns true" rather than "Returns 1" in the
comment; OK with that change.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (12 preceding siblings ...)
2005-01-22 19:43 ` mark at codesourcery dot com
@ 2005-01-24 16:22 ` pinskia at gcc dot gnu dot org
2005-04-20 2:03 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 16+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-01-24 16:22 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-01-24 16:21 -------
Fixed by:
2005-01-24 J"orn Rennecke <joern.rennecke@st.com>
* sh.c (ra.h): Don't #include.
(hard_regs_intersect_p): New function, resurrected from ra.c.
* sh.c: Fix 1996 Copyright.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Bug target/19528] [4.0 regression] missing ra.h
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
` (13 preceding siblings ...)
2005-01-24 16:22 ` pinskia at gcc dot gnu dot org
@ 2005-04-20 2:03 ` pinskia at gcc dot gnu dot org
14 siblings, 0 replies; 16+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-04-20 2:03 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19528
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2005-04-20 2:02 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-19 9:52 [Bug target/19528] New: [4.0 regression] missing ra.h corsepiu at gcc dot gnu dot org
2005-01-19 12:22 ` [Bug target/19528] " steven at gcc dot gnu dot org
2005-01-19 12:26 ` steven at gcc dot gnu dot org
2005-01-19 12:55 ` paolo dot bonzini at lu dot unisi dot ch
2005-01-19 13:27 ` bonzini at gcc dot gnu dot org
2005-01-19 13:47 ` bonzini at gcc dot gnu dot org
2005-01-19 13:48 ` pinskia at gcc dot gnu dot org
2005-01-19 14:03 ` pinskia at gcc dot gnu dot org
2005-01-19 16:35 ` corsepiu at gcc dot gnu dot org
2005-01-19 19:00 ` steven at gcc dot gnu dot org
2005-01-21 17:34 ` mmitchel at gcc dot gnu dot org
2005-01-22 12:20 ` steven at gcc dot gnu dot org
2005-01-22 12:57 ` joel at gcc dot gnu dot org
2005-01-22 19:43 ` mark at codesourcery dot com
2005-01-24 16:22 ` pinskia at gcc dot gnu dot org
2005-04-20 2:03 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).