[Bug c++/17115] New: -Winline does not respect __attribute__((__noinline__))

[Bug c++/17115] New: -Winline does not respect __attribute__((__noinline__))

[markus at oberhumer dot com]

This is could be regarded as a feature or missing documentation, but I was very
suprised finding out that -Winline does not respect _attribute__((__noinline__)).

Consider this code:

struct Foo {
            __attribute__((noinline)) int a(int r) { return r & 1; }
    virtual __attribute__((noinline)) int b(int r) { return r & 1; }
    static  __attribute__((noinline)) int c(int r) { return r & 1; }
};

int bar(int r) {
    Foo f;
    int k = 1; k &= f.a(r); k &= f.b(r); k &= f.a(r);
    return k;
}

> g++-3.5 -O2 -Winline -c x.cpp
x.cpp: In function `int bar(int)':
x.cpp:2: warning: inlining failed in call to 'int Foo::a(int)': function not
inlinable
x.cpp:9: warning: called from here
x.cpp:3: warning: inlining failed in call to 'virtual int Foo::b(int)': function
not inlinable
x.cpp:9: warning: called from here
x.cpp:2: warning: inlining failed in call to 'int Foo::a(int)': function not
inlinable
x.cpp:9: warning: called from here


Somewhat related is the usage of both -Winline and -fno-default-inline - I would
expect that -Winline would ignore non-inlines that result from
-fno-default-inline but still warns about other (e.g. global) non-inlined
functions. But currently it warns about every member function.

-- 
           Summary: -Winline does not respect __attribute__((__noinline__))
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: markus at oberhumer dot com
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4/3.5 regression] -Winline does not respect __attribute__((__noinline__))

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-08-20 12:55 -------
Confirmed. A regression in 3.3/3.4/mainline against 3.2 where we didn't 
report a warning. 
 
W. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |diagnostic
      Known to fail|                            |3.3.4 3.4.1 3.5.0
      Known to work|                            |3.2.3
   Last reconfirmed|0000-00-00 00:00:00         |2004-08-20 12:55:13
               date|                            |
            Summary|-Winline does not respect   |[3.3/3.4/3.5 regression] -
                   |__attribute__((__noinline__)|Winline does not respect
                   |)                           |__attribute__((__noinline__)
                   |                            |)
   Target Milestone|---                         |3.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4/3.5 regression] -Winline does not respect __attribute__((__noinline__))

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-20 17:12 -------
Moving to 3.4 per GDR.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gdr at gcc dot gnu dot org
   Target Milestone|3.3.5                       |3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4/3.5 regression] -Winline does not respect __attribute__((__noinline__))

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-08-29 18:51 -------
Postponed until GCC 3.4.3.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.2                       |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4/4.0 regression] -Winline does not respect __attribute__((__noinline__))

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-09-23 12:30 -------
Mine. Testing a patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |giovannibajo at libero dot
                   |dot org                     |it
             Status|NEW                         |ASSIGNED
      Known to fail|3.3.4 3.4.1 4.0             |3.3.4 3.4.1 4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4/4.0 regression] -Winline does not respect __attribute__((__noinline__))

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-10-04 11:30 -------
Patch posted here:
http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00235.html


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4/4.0 regression] -Winline does not respect __attribute__((__noinline__))

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-07 08:36 -------
Subject: Bug 17115

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	giovannibajo@gcc.gnu.org	2004-10-07 08:36:29

Modified files:
	gcc            : ChangeLog tree-inline.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/g++.dg/warn: Winline-4.C 

Log message:
	PR c++/17115
	* tree-inline.c (expand_call_inline): Do not warn for functions
	marked with attribute noinline.
	
	PR c++/17115
	* g++.dg/warn/Winline-4.C: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.5782&r2=2.5783
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-inline.c.diff?cvsroot=gcc&r1=1.144&r2=1.145
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4401&r2=1.4402
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/warn/Winline-4.C.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3/3.4 regression] -Winline does not respect __attribute__((__noinline__))

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-07 16:51 -------
Subject: Bug 17115

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	giovannibajo@gcc.gnu.org	2004-10-07 16:51:25

Modified files:
	gcc            : ChangeLog tree-inline.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/g++.dg/warn: Winline-4.C 

Log message:
	PR c++/17115
	* tree-inline.c (expand_call_inline): Do not warn for functions
	marked with attribute noinline.
	
	PR c++/17115
	* g++.dg/warn/Winline-4.C: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.648&r2=2.2326.2.649
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-inline.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.90.4.4&r2=1.90.4.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.277&r2=1.3389.2.278
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/warn/Winline-4.C.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-10-07 16:52 -------
The patch was tested succesfully on latest 3.3 branch too. I'm waiting for 
branch unfreeze to commit it there.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|3.3.4 3.4.1                 |3.3.4
      Known to work|3.2.3 4.0.0                 |3.2.3 4.0.0 3.4.3
            Summary|[3.3/3.4 regression] -      |[3.3 Regression] -Winline
                   |Winline does not respect    |does not respect
                   |__attribute__((__noinline__)|__attribute__((__noinline__)
                   |)                           |)


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.3                       |3.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[markus at oberhumer dot com]

------- Additional Comments From markus at oberhumer dot com  2004-10-20 05:55 -------
Mayn thanks for the fix. May I also draw your attention to bug18071 (-Winline
does not respect -fno-default-inline), and I'd also appreciate comments on
bug18070 (Contradicting function attributes).




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-10-21 01:36 -------
Subject: Re:  [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

> Mayn thanks for the fix. 

No problem.

> May I also draw
> your attention to bug18071 (-Winline 
> does not respect -fno-default-inline), and I'd also appreciate
> comments on 
> bug18070 (Contradicting function attributes).

I'll give them a look.

Giovanni Bajo




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[markus at oberhumer dot com]

------- Additional Comments From markus at oberhumer dot com  2005-01-21 02:02 -------
This seems to be fixed for 3.4 and 4.0 now, so the bug should be closed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2005-01-21 03:53 -------
(In reply to comment #8)
> The patch was tested succesfully on latest 3.3 branch too. I'm waiting for 
> branch unfreeze to commit it there.

Giovanni --
gcc-3.3 is unfrozen.  Do you still consider your patch as condidate
there?  If yes, you hav ehe approval.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2005-01-21 10:03 -------
This is now fixed in GCC 3.3.6, GCC 3.4.3 and GCC 4.0.0. Thanks for your report 
Markus!

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115

[Bug c++/17115] [3.3 Regression] -Winline does not respect __attribute__((__noinline__))

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-01-21 10:02 -------
Subject: Bug 17115

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	giovannibajo@gcc.gnu.org	2005-01-21 10:02:31

Modified files:
	gcc            : ChangeLog tree-inline.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/g++.dg/warn: Winline-4.C 

Log message:
	PR c++/17115
	* tree-inline.c (expand_call_inline): Do not warn for functions
	marked with attribute noinline.
	
	PR c++/17115
	* g++.dg/warn/Winline-4.C: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.1053&r2=1.16114.2.1054
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-inline.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.38.2.12&r2=1.38.2.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.2261.2.396&r2=1.2261.2.397
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/warn/Winline-4.C.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=NONE&r2=1.1.42.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17115