public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "tobi at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libfortran/19524] 5 times uninitialized var in libgfortran Date: Sat, 22 Jan 2005 00:36:00 -0000 [thread overview] Message-ID: <20050122003619.31353.qmail@sourceware.org> (raw) In-Reply-To: <20050119082102.19524.marcus@jet.franken.de> ------- Additional Comments From tobi at gcc dot gnu dot org 2005-01-22 00:36 ------- The first four can be fixed by slightly reordering the contents of the functions they're in. I'm not proposing a patch, because I'm not completely sure why that code is needed, and I'm too tired to look into this right now. For the error in read.c this patch should be sufficient, there's no path leading to bad_float on which buffer is initialized. I will regtest this tomorrow, and commit as obvious if successful. 2005-01-22 Tobias Schl"uter <tobias.schlueter@physik.un-muenchen.de> PR fortran/19524 * io/read.c (read_f): Remove bogus if. Index: read.c =================================================================== RCS file: /cvs/gcc/gcc/libgfortran/io/read.c,v retrieving revision 1.7 diff -u -p -r1.7 read.c --- read.c 12 Jan 2005 21:27:31 -0000 1.7 +++ read.c 22 Jan 2005 00:32:45 -0000 @@ -600,8 +600,6 @@ read_f (fnode * f, char *dest, int lengt bad_float: generate_error (ERROR_READ_VALUE, "Bad value during floating point read"); - if (buffer != scratch) - free_mem (buffer); return; /* At this point the start of an exponent has been found */ -- What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed| |1 Last reconfirmed|0000-00-00 00:00:00 |2005-01-22 00:36:12 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524
next prev parent reply other threads:[~2005-01-22 0:36 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2005-01-19 8:21 [Bug libfortran/19524] New: " marcus at jet dot franken dot de 2005-01-22 0:36 ` tobi at gcc dot gnu dot org [this message] 2005-01-25 21:40 ` [Bug libfortran/19524] " cvs-commit at gcc dot gnu dot org [not found] <bug-19524-3760@http.gcc.gnu.org/bugzilla/> 2005-11-18 12:54 ` fxcoudert at gcc dot gnu dot org 2005-11-18 12:59 ` tobi at gcc dot gnu dot org 2005-11-18 17:50 ` pinskia at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20050122003619.31353.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).