public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug libfortran/19524] New: 5 times uninitialized var in libgfortran
@ 2005-01-19 8:21 marcus at jet dot franken dot de
2005-01-22 0:36 ` [Bug libfortran/19524] " tobi at gcc dot gnu dot org
2005-01-25 21:40 ` cvs-commit at gcc dot gnu dot org
0 siblings, 2 replies; 6+ messages in thread
From: marcus at jet dot franken dot de @ 2005-01-19 8:21 UTC (permalink / raw)
To: gcc-bugs
during bootstrap the compiler warns:
../../../libgfortran/generated/matmul_l4.c:102: warning: 'astride' is used
uninitialized in this function
../../../libgfortran/generated/matmul_l4.c:109: warning: 'bstride' is used
uninitialized in this function
../../../libgfortran/generated/matmul_l8.c:102: warning: 'astride' is used
uninitialized in this function
../../../libgfortran/generated/matmul_l8.c:109: warning: 'bstride' is used
uninitialized in this function
../../../libgfortran/io/read.c:603: warning: 'buffer' is used uninitialized in
this function
and yes, astride and bstride are used uninitialized in those 2 files, and
buffer can be used undefined too.
--
Summary: 5 times uninitialized var in libgfortran
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libfortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: marcus at jet dot franken dot de
CC: gcc-bugs at gcc dot gnu dot org
GCC build triplet: i686-pc-linux-gnu
GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libfortran/19524] 5 times uninitialized var in libgfortran 2005-01-19 8:21 [Bug libfortran/19524] New: 5 times uninitialized var in libgfortran marcus at jet dot franken dot de @ 2005-01-22 0:36 ` tobi at gcc dot gnu dot org 2005-01-25 21:40 ` cvs-commit at gcc dot gnu dot org 1 sibling, 0 replies; 6+ messages in thread From: tobi at gcc dot gnu dot org @ 2005-01-22 0:36 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From tobi at gcc dot gnu dot org 2005-01-22 00:36 ------- The first four can be fixed by slightly reordering the contents of the functions they're in. I'm not proposing a patch, because I'm not completely sure why that code is needed, and I'm too tired to look into this right now. For the error in read.c this patch should be sufficient, there's no path leading to bad_float on which buffer is initialized. I will regtest this tomorrow, and commit as obvious if successful. 2005-01-22 Tobias Schl"uter <tobias.schlueter@physik.un-muenchen.de> PR fortran/19524 * io/read.c (read_f): Remove bogus if. Index: read.c =================================================================== RCS file: /cvs/gcc/gcc/libgfortran/io/read.c,v retrieving revision 1.7 diff -u -p -r1.7 read.c --- read.c 12 Jan 2005 21:27:31 -0000 1.7 +++ read.c 22 Jan 2005 00:32:45 -0000 @@ -600,8 +600,6 @@ read_f (fnode * f, char *dest, int lengt bad_float: generate_error (ERROR_READ_VALUE, "Bad value during floating point read"); - if (buffer != scratch) - free_mem (buffer); return; /* At this point the start of an exponent has been found */ -- What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed| |1 Last reconfirmed|0000-00-00 00:00:00 |2005-01-22 00:36:12 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libfortran/19524] 5 times uninitialized var in libgfortran 2005-01-19 8:21 [Bug libfortran/19524] New: 5 times uninitialized var in libgfortran marcus at jet dot franken dot de 2005-01-22 0:36 ` [Bug libfortran/19524] " tobi at gcc dot gnu dot org @ 2005-01-25 21:40 ` cvs-commit at gcc dot gnu dot org 1 sibling, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu dot org @ 2005-01-25 21:40 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-01-25 21:40 ------- Subject: Bug 19524 CVSROOT: /cvs/gcc Module name: gcc Changes by: tobi@gcc.gnu.org 2005-01-25 21:40:25 Modified files: libgfortran : ChangeLog libgfortran/io : read.c Log message: PR libfortran/19524 * io/read.c (read_f): Don't free uninitialized pointer. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.153&r2=1.154 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/read.c.diff?cvsroot=gcc&r1=1.7&r2=1.8 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524 ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <bug-19524-3760@http.gcc.gnu.org/bugzilla/>]
* [Bug libfortran/19524] 5 times uninitialized var in libgfortran [not found] <bug-19524-3760@http.gcc.gnu.org/bugzilla/> @ 2005-11-18 12:54 ` fxcoudert at gcc dot gnu dot org 2005-11-18 12:59 ` tobi at gcc dot gnu dot org 2005-11-18 17:50 ` pinskia at gcc dot gnu dot org 2 siblings, 0 replies; 6+ messages in thread From: fxcoudert at gcc dot gnu dot org @ 2005-11-18 12:54 UTC (permalink / raw) To: gcc-bugs ------- Comment #3 from fxcoudert at gcc dot gnu dot org 2005-11-18 12:54 ------- I don't see these warnings any more with the current mainline. Can someone confirms that they disappeared and then close this bug? -- fxcoudert at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fxcoudert at gcc dot gnu dot | |org Status|NEW |WAITING http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libfortran/19524] 5 times uninitialized var in libgfortran [not found] <bug-19524-3760@http.gcc.gnu.org/bugzilla/> 2005-11-18 12:54 ` fxcoudert at gcc dot gnu dot org @ 2005-11-18 12:59 ` tobi at gcc dot gnu dot org 2005-11-18 17:50 ` pinskia at gcc dot gnu dot org 2 siblings, 0 replies; 6+ messages in thread From: tobi at gcc dot gnu dot org @ 2005-11-18 12:59 UTC (permalink / raw) To: gcc-bugs ------- Comment #4 from tobi at gcc dot gnu dot org 2005-11-18 12:59 ------- I think that the following patch is the one responsible: 2005-05-15 Andreas Jaeger <aj@suse.de> * m4/eoshift1.m4: Initialize variables to avoid warnings. * m4/eoshift3.m4: Initialize variables to avoid warnings. * generated/eoshift1_4.c, generated/eoshift1_8.c, generated/eoshift3_4.c, generated/eoshift3_8.c: Regenerated. * intrinsics/spread_generic.c (spread): Initialize variables to avoid warnings. * intrinsics/eoshift0.c (eoshift0): Initialize variables to avoid warnings. * intrinsics/eoshift2.c (eoshift2): Initialize variables to avoid warnings. * io/list_read.c (nml_get_obj_data): Initialize variables to avoid warnings. * intrinsics/pack_generic.c (pack): Remove unneeded calculation. * m4/matmull.m4 (matmul_): Remove unneeded calculations, fix pointer cast to avoid warning. * generated/matmul_l4.c: Regenerated. * generated/matmul_l8.c: Regenerated. * Makefile.am: Remove AM_CFLAGS here. * configure.ac: Define AM_CFLAGS and AM_FCFLAGS so that warnings are set. Set additionally -Wstrict-prototypes for CFLAGS. * Makefile.in: Regenerated. * aclocal.m4: Regenerated. * configure: Regenerated. * intrinsics/system_clock.c (system_clock_4, system_clock_8): Add missing returns, reformat a bit. * io/write.c (nml_write_obj): Use %d again - and cast to int, st_sprintf does not handle %ld. * io/unit.c (is_internal_unit): Add void as parameter list. * io/transfer.c: Move prototype declarations before the functions. * runtime/normalize.c (almostone_r4, almostone_r8): Fix parameter list. * intrinsics/random.c (KISS_DEFAULT_SEED): Remove extra semicolon. * io/transfer.c: Do not use empty initializers for global objects. Add missing initializers. * io/lock.c: Do not use empty initializers for global objects. * io/close.c: Add missing initializers. * runtime/environ.c: Add missing initializers. Do not use empty initializers for global object. (init_string): Mark argument as unused. * runtime/main.c (cleanup): Fix parameter list. * io/io.h: Fix parameter lists. * m4/transpose.m4, m4/matmul.m4: Fix pointer cast to avoid warning. * generated/transpose_c4.c, generated/transpose_c8.c, generated/transpose_i4.c, generated/transpose_i8.c, generated/matmul_c4.c, generated/matmul_c8.c, generated/matmul_i4.c, generated/matmul_i8.c, generated/matmul_r4.c, generated/matmul_r8.c: Regenerated. * io/write.c (nml_write_obj): Fix 64-bit problem. * io/list_read.c (nml_get_obj_data): Add missing braces around initializer to avoid warnings. * intrinsics/etime.c (etime_sub): Remove unused variable. * intrinsics/chdir.c, intrinsics/getlog.c, intrinsics/link.c, intrinsics/symlnk.c, intrinsics/perror.c: Include <string.h> for prototypes. * runtime/string.c (compare0): Remove unused variable. * io/unit.c (init_units): Remove unused variables. * intrinsics/getcwd.c (getcwd_i4_sub): Remove unused variable. * intrinsics/unlink.c (unlink_i4_sub): Remove unused variable. * intrinsics/stat.c (stat_i4_sub, fstat_i8_sub, fstat_i4_sub, stat_i8_sub): Remove unused variable. -- tobi at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|WAITING |RESOLVED Resolution| |FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libfortran/19524] 5 times uninitialized var in libgfortran [not found] <bug-19524-3760@http.gcc.gnu.org/bugzilla/> 2005-11-18 12:54 ` fxcoudert at gcc dot gnu dot org 2005-11-18 12:59 ` tobi at gcc dot gnu dot org @ 2005-11-18 17:50 ` pinskia at gcc dot gnu dot org 2 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu dot org @ 2005-11-18 17:50 UTC (permalink / raw) To: gcc-bugs -- pinskia at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.1.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19524 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-11-18 17:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-19 8:21 [Bug libfortran/19524] New: 5 times uninitialized var in libgfortran marcus at jet dot franken dot de
2005-01-22 0:36 ` [Bug libfortran/19524] " tobi at gcc dot gnu dot org
2005-01-25 21:40 ` cvs-commit at gcc dot gnu dot org
[not found] <bug-19524-3760@http.gcc.gnu.org/bugzilla/>
2005-11-18 12:54 ` fxcoudert at gcc dot gnu dot org
2005-11-18 12:59 ` tobi at gcc dot gnu dot org
2005-11-18 17:50 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).