[Bug c++/19732] New: [4.0 regression] Invalid destructor declarations accepted

[Bug c++/19732] New: [4.0 regression] Invalid destructor declarations accepted

[reichelt at gcc dot gnu dot org]

The following invalid code snippet is accepted by mainline:

==================================
struct A;
struct B { ~A(); };
==================================

Mark, this was caused by your patch
http://gcc.gnu.org/ml/gcc-cvs/2004-06/msg00888.html

This patch not only removed the error message
  error ("destructor `%T' must match class name `%T'", name, rename);
for destructors from grokdeclarator, but also
  error ("destructors must be member functions");

A testcase that used to trigger the second error message but is now accepted
is the following:

==================================
struct A;
void ~A();
==================================

-- 
           Summary: [4.0 regression] Invalid destructor declarations
                    accepted
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid, monitored
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,mark at codesourcery dot
                    com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19732

[Bug c++/19732] [4.0 regression] Invalid destructor declarations accepted

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-01 00:01 -------
: Search converges between 2004-06-22-trunk (#470) and 2004-06-24-trunk (#471).

Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-02-01 00:01:01
               date|                            |
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19732

[Bug c++/19732] [4.0 regression] Invalid destructor declarations accepted

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mark at codesourcery dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19732

[Bug c++/19732] [4.0 regression] Invalid destructor declarations accepted

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-10 00:35 -------
Subject: Bug 19732

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	mmitchel@gcc.gnu.org	2005-02-10 00:34:47

Modified files:
	gcc/cp         : ChangeLog call.c decl.c parser.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/g++.dg/template: crash2.C 
Added files:
	gcc/testsuite/g++.dg/conversion: ambig1.C 
	gcc/testsuite/g++.dg/ext: attrib19.C 
	gcc/testsuite/g++.dg/parse: dtor5.C 
	gcc/testsuite/g++.dg/template: dtor3.C static11.C 

Log message:
	PR c++/19787
	* call.c (initialize_reference): Robustify.
	
	PR ++/19732
	* decl.c (grokdeclarator): Check for invalid use of destructor
	names.
	
	PR c++/19762
	* parser.c (cp_parser_unqualified_id): Avoid creating destructor
	names with invalid types.
	
	PR c++/19826
	* parser.c (cp_parser_direct_declarator): Allow type-dependent
	expressions as array bounds.
	
	PR c++/19739
	* parser.c (cp_parser_attributes_list): Allow empty lists.
	
	PR c++/19787
	* g++.dg/conversion/ambig1.C: New test.
	
	PR c++/19739
	* g++.dg/ext/attrib19.C: New test.
	
	PR c++/19732
	* g++.dg/parse/dtor5.C: New test.
	
	PR c++/19762
	* g++.dg/template/dtor3.C: New test.
	
	PR c++/19826
	* g++.dg/template/static11.C: New test.
	* g++.dg/template/crash2.C: Remove dg-error marker.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4618&r2=1.4619
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/call.c.diff?cvsroot=gcc&r1=1.528&r2=1.529
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl.c.diff?cvsroot=gcc&r1=1.1360&r2=1.1361
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.313&r2=1.314
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5011&r2=1.5012
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/conversion/ambig1.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/ext/attrib19.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/dtor5.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/dtor3.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/static11.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/crash2.C.diff?cvsroot=gcc&r1=1.3&r2=1.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19732

[Bug c++/19732] [4.0 regression] Invalid destructor declarations accepted

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2005-02-10 00:40 -------
Fixed in 4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19732