public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code
@ 2005-01-23 22:55 dmixm at marine dot febras dot ru
2005-01-23 23:02 ` [Bug middle-end/19597] [4.0 Regression] " pinskia at gcc dot gnu dot org
` (16 more replies)
0 siblings, 17 replies; 18+ messages in thread
From: dmixm at marine dot febras dot ru @ 2005-01-23 22:55 UTC (permalink / raw)
To: gcc-bugs
avr-gcc 4.0 (20050116) replaces multiplication by a constant to a combination of more simple
operations. Thus it does not pay attention to efficiency of such replacement.
For example:
int foo (int x) { return 24011 * x; }
produce 49 words (-mmcu=atmega8 -Os).
Older GCC branches -- only 11 words in this case.
--
Summary: avr-gcc 4.0, multiplication by constant, very long code
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: rtl-optimization
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: dmixm at marine dot febras dot ru
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug middle-end/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
@ 2005-01-23 23:02 ` pinskia at gcc dot gnu dot org
2005-01-23 23:56 ` giovannibajo at libero dot it
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-01-23 23:02 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-01-23 23:01 -------
The problem is that middle-end expands it to shifts and such but really it might be that rtx_cost for avr
does not take into account size at all.
--
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |minor
Component|rtl-optimization |middle-end
Keywords| |missed-optimization
Priority|P2 |P3
Summary|avr-gcc 4.0, multiplication |[4.0 Regression] avr-gcc
|by constant, very long code |4.0, multiplication by
| |constant, very long code
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug middle-end/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
2005-01-23 23:02 ` [Bug middle-end/19597] [4.0 Regression] " pinskia at gcc dot gnu dot org
@ 2005-01-23 23:56 ` giovannibajo at libero dot it
2005-01-24 0:49 ` bernie at develer dot com
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: giovannibajo at libero dot it @ 2005-01-23 23:56 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From giovannibajo at libero dot it 2005-01-23 23:56 -------
Bernie, can you confirm this?
Roger, you tweaked the middle-end in this regard. Can you have a look at this?
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |sayle at gcc dot gnu dot
| |org, bernie at develer dot
| |com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug middle-end/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
2005-01-23 23:02 ` [Bug middle-end/19597] [4.0 Regression] " pinskia at gcc dot gnu dot org
2005-01-23 23:56 ` giovannibajo at libero dot it
@ 2005-01-24 0:49 ` bernie at develer dot com
2005-01-24 2:54 ` roger at eyesopen dot com
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: bernie at develer dot com @ 2005-01-24 0:49 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bernie at develer dot com 2005-01-24 00:49 -------
Confirmed:
--- 3.4 output ---
ldi r18,lo8(24011)
ldi r19,hi8(24011)
mul r24,r18
movw r20,r0
mul r24,r19
add r21,r0
mul r25,r18
add r21,r0
clr r1
movw r24,r20
------------------
--- 4.0 output ---
movw r22,r24
movw r18,r24
add r18,r24
adc r19,r25
add r18,r18
adc r19,r19
add r18,r24
adc r19,r25
movw r24,r18
add r24,r18
adc r25,r19
add r24,r24
adc r25,r25
add r24,r24
adc r25,r25
sub r24,r18
sbc r25,r19
movw r18,r24
add r18,r24
adc r19,r25
add r18,r18
adc r19,r19
add r18,r18
adc r19,r19
sub r18,r24
sbc r19,r25
movw r20,r18
add r20,r18
adc r21,r19
add r20,r20
adc r21,r21
add r20,r20
adc r21,r21
sub r20,r18
sbc r21,r19
movw r24,r20
add r24,r20
adc r25,r21
add r24,r24
adc r25,r25
add r24,r24
adc r25,r25
sub r24,r20
sbc r25,r21
add r24,r24
adc r25,r25
add r24,r22
adc r25,r23
------------------
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-01-24 00:49:29
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug middle-end/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (2 preceding siblings ...)
2005-01-24 0:49 ` bernie at develer dot com
@ 2005-01-24 2:54 ` roger at eyesopen dot com
2005-01-24 8:17 ` [Bug target/19597] " pinskia at gcc dot gnu dot org
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: roger at eyesopen dot com @ 2005-01-24 2:54 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From roger at eyesopen dot com 2005-01-24 02:53 -------
The function avr_rtx_costs needs fixing. For a start, it doesn't even use
COSTS_N_INSNS, indeed COSTS_N_INSNS isn't used anywhere in the AVR backend.
I'm only mildly surprised at the code sequence we generate, it looks like
the avr backend reports the costs of shifts and multiplications as free,
but the code of additions as GET_MODE_SIZE (mode). i.e. SImode additions
are COSTS_N_INSNS(1), but it can perform four QImode additions in a single
cycle. And I don't think I even have to mention that avr_rtx_costs ignores
optimize_size.
Many of the middle-end improvements to make better use of rtx_costs should
benefit AVR, for example, where the cost of a shift is dependent upon the
number of bits by which the operand is being shifted, and where the cost of
almost all operations is highly dependent upon the machine mode.
But to summarise, this is a target bug.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (3 preceding siblings ...)
2005-01-24 2:54 ` roger at eyesopen dot com
@ 2005-01-24 8:17 ` pinskia at gcc dot gnu dot org
2005-01-24 8:56 ` giovannibajo at libero dot it
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-01-24 8:17 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-01-24 08:16 -------
(In reply to comment #4)
> But to summarise, this is a target bug.
That is what I thought.
Anyways Roger posted a patch to rewrite rtx_cost for AVR to fix this bug here: <http://gcc.gnu.org/ml/
gcc-patches/2005-01/msg01698.html> It might also improve other things too because of the
mentioned items in that mail.
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (4 preceding siblings ...)
2005-01-24 8:17 ` [Bug target/19597] " pinskia at gcc dot gnu dot org
@ 2005-01-24 8:56 ` giovannibajo at libero dot it
2005-01-24 9:24 ` marekm at amelek dot gda dot pl
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: giovannibajo at libero dot it @ 2005-01-24 8:56 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From giovannibajo at libero dot it 2005-01-24 08:56 -------
Marek, can you review this patch please?
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |marekm at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (5 preceding siblings ...)
2005-01-24 8:56 ` giovannibajo at libero dot it
@ 2005-01-24 9:24 ` marekm at amelek dot gda dot pl
2005-01-24 10:28 ` bernie at develer dot com
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: marekm at amelek dot gda dot pl @ 2005-01-24 9:24 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From marekm at amelek dot gda dot pl 2005-01-24 09:24 -------
Subject: Re: [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
On Mon, Jan 24, 2005 at 08:56:46AM -0000, giovannibajo at libero dot it wrote:
> Marek, can you review this patch please?
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
Thanks. Reviewing this will take some time - I agree the current rtx
costs are not perfect, but changing them can affect generated code in
unexpected ways. It would be good to test it a lot on various test
cases, to make sure it doesn't introduce new code size regressions...
Marek
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (6 preceding siblings ...)
2005-01-24 9:24 ` marekm at amelek dot gda dot pl
@ 2005-01-24 10:28 ` bernie at develer dot com
2005-01-24 13:16 ` bernie at develer dot com
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: bernie at develer dot com @ 2005-01-24 10:28 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bernie at develer dot com 2005-01-24 10:28 -------
Subject: Re: [4.0 Regression] avr-gcc 4.0, multiplication
by constant, very long code
marekm at amelek dot gda dot pl wrote:
> ------- Additional Comments From marekm at amelek dot gda dot pl 2005-01-24 09:24 -------
> Subject: Re: [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
>
> On Mon, Jan 24, 2005 at 08:56:46AM -0000, giovannibajo at libero dot it wrote:
>
>
>>Marek, can you review this patch please?
>
>
>>http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
>
>
> Thanks. Reviewing this will take some time - I agree the current rtx
> costs are not perfect, but changing them can affect generated code in
> unexpected ways. It would be good to test it a lot on various test
> cases, to make sure it doesn't introduce new code size regressions...
I'm building avr-gcc right now with your two patches and
this one applied. I'll let you know shortly.
btw, how do you test the AVR backend? Can you execute
the dejagnu testsuite on simulavr or something similar?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (7 preceding siblings ...)
2005-01-24 10:28 ` bernie at develer dot com
@ 2005-01-24 13:16 ` bernie at develer dot com
2005-01-25 20:33 ` schlie at comcast dot net
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: bernie at develer dot com @ 2005-01-24 13:16 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bernie at develer dot com 2005-01-24 13:15 -------
Subject: Re: [4.0 Regression] avr-gcc 4.0, multiplication
by constant, very long code
Bernardo Innocenti wrote:
> marekm at amelek dot gda dot pl wrote:
>
>>------- Additional Comments From marekm at amelek dot gda dot pl 2005-01-24 09:24 -------
>>Subject: Re: [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
>>
>>On Mon, Jan 24, 2005 at 08:56:46AM -0000, giovannibajo at libero dot it wrote:
>>
>>
>>
>>>Marek, can you review this patch please?
>>
>>
>>>http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
>>
>>
>>Thanks. Reviewing this will take some time - I agree the current rtx
>>costs are not perfect, but changing them can affect generated code in
>>unexpected ways. It would be good to test it a lot on various test
>>cases, to make sure it doesn't introduce new code size regressions...
>
>
> I'm building avr-gcc right now with your two patches and
> this one applied. I'll let you know shortly.
Not good. With these two patches applied, the size of four
big AVR applications increased slightly.
These were built with -Os (the second one shows a minor improvement):
text data bss dec hex filename
8008 136 401 8545 2161 images-orig/dspslave.elf
8032 136 401 8569 2179 images-patched/dspslave.elf
text data bss dec hex filename
18448 536 692 19676 4cdc images-orig/dspmaster.elf
18428 536 692 19656 4cc8 images-patched/dspmaster.elf
These with -O2:
text data bss dec hex filename
60454 1832 1562 63848 f968 images-orig/kfront.elf
60488 1832 1562 63882 f98a images-patched/kfront.elf
text data bss dec hex filename
36160 900 1713 38773 9775 images-orig/kcntrl.elf
36344 900 1713 38957 982d images-patched/kcntrl.elf
Would you like to see some diffs?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (8 preceding siblings ...)
2005-01-24 13:16 ` bernie at develer dot com
@ 2005-01-25 20:33 ` schlie at comcast dot net
2005-01-25 21:23 ` roger at eyesopen dot com
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: schlie at comcast dot net @ 2005-01-25 20:33 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From schlie at comcast dot net 2005-01-25 20:33 -------
(In reply to comment #9)
> Not good. With these two patches applied, the size of four
> big AVR applications increased slightly.
Although it would have been nicer if all 4 got smaller, it's not clear
that a < 0.5% code size variance means much of anything good or bad.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (9 preceding siblings ...)
2005-01-25 20:33 ` schlie at comcast dot net
@ 2005-01-25 21:23 ` roger at eyesopen dot com
2005-01-25 23:20 ` schlie at comcast dot net
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: roger at eyesopen dot com @ 2005-01-25 21:23 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From roger at eyesopen dot com 2005-01-25 21:23 -------
I'm currently working on an updated and improved patch that should address
some of this size regression. Failing that there are a number of middle-end
improvements that can be made to address the code size increase. For example,
GCC's middle-end considers any constant with an rtx_cost greater than
COSTS_N_INSNS(1) to be expensive, and therefore worth keeping in a register
for CSE and GCSE. Unfortunately, this plays badly with AVR, where the cost
of a register-register copy is often greater than COSTS_N_INSNS(1)! The
solution to which is to introduce a REG_REG_MOVE_COST(mode) target macro that
can be used to report the cost of copying a pseudo and use this instead of
COSTS_N_INSNS(1) where appropriate. This should even help non-AVR platforms,
for example DImode typically requires two move instructions.
The change described above should avoid AVR keeping HImode integer constants
in registers and then copying them when required (its as cheap to load an
immediate constant as it is to copy registers, but the later increases register
pressure, stack frame size, etc...)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (10 preceding siblings ...)
2005-01-25 21:23 ` roger at eyesopen dot com
@ 2005-01-25 23:20 ` schlie at comcast dot net
2005-02-09 12:44 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: schlie at comcast dot net @ 2005-01-25 23:20 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From schlie at comcast dot net 2005-01-25 23:19 -------
(In reply to comment #11)
> The change described above should avoid AVR keeping HImode integer constants
> in registers and then copying them when required (its as cheap to load an
> immediate constant as it is to copy registers, but the later increases register
> pressure, stack frame size, etc...)
Just as a minor clarification, HI-mode register-to-register moves are relativly cheap on avr
(i.e. 1-instruction/1-cycle if allocated in an register pair), so there may often be circumstances
when keeping frequently-recently used HI constants in registers may actually be cheaper than
loading them upon demand (as QI-mode constant loads are limited to r16-r31), and although
an HI-mode constant may be arbitrarity loaded from data-memory, they would need to have
been stored there first in anticipation of their requirement, unfortunatly further complecated
by data-memory itself tending to be a very scarce/limited resource (nor is it clear how to best
express this potential method or cost to GCC if considered worth while)?
(however, more accurrately describing true inst. costs should only help improve code effeciency)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (11 preceding siblings ...)
2005-01-25 23:20 ` schlie at comcast dot net
@ 2005-02-09 12:44 ` pinskia at gcc dot gnu dot org
2005-02-09 13:06 ` pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-09 12:44 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-02-09 07:02 -------
Fixed. Thanks Roger for looking into this testcase. And thanks for all people who tested the patch to
show it actually helps the code size.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (12 preceding siblings ...)
2005-02-09 12:44 ` pinskia at gcc dot gnu dot org
@ 2005-02-09 13:06 ` pinskia at gcc dot gnu dot org
2005-02-09 13:09 ` pinskia at gcc dot gnu dot org
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-09 13:06 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-02-09 07:16 -------
Actually Roger has not checked this in yet.
I was misled by: <http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00344.html>.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (13 preceding siblings ...)
2005-02-09 13:06 ` pinskia at gcc dot gnu dot org
@ 2005-02-09 13:09 ` pinskia at gcc dot gnu dot org
2005-02-09 20:09 ` cvs-commit at gcc dot gnu dot org
2005-02-09 20:13 ` pinskia at gcc dot gnu dot org
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-09 13:09 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.0 |---
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (14 preceding siblings ...)
2005-02-09 13:09 ` pinskia at gcc dot gnu dot org
@ 2005-02-09 20:09 ` cvs-commit at gcc dot gnu dot org
2005-02-09 20:13 ` pinskia at gcc dot gnu dot org
16 siblings, 0 replies; 18+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-02-09 20:09 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-02-09 14:43 -------
Subject: Bug 19597
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: sayle@gcc.gnu.org 2005-02-09 14:43:29
Modified files:
gcc : ChangeLog
gcc/config/avr : avr.c
Log message:
PR target/19597
* config/avr/avr.c (default_rtx_costs): Delete.
(avr_operand_rtx_cost): New function.
(avr_rtx_costs): Completely rewrite.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.7419&r2=2.7420
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/avr/avr.c.diff?cvsroot=gcc&r1=1.128&r2=1.129
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug target/19597] [4.0 Regression] avr-gcc 4.0, multiplication by constant, very long code
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
` (15 preceding siblings ...)
2005-02-09 20:09 ` cvs-commit at gcc dot gnu dot org
@ 2005-02-09 20:13 ` pinskia at gcc dot gnu dot org
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-09 20:13 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-02-09 14:49 -------
Fixed for real this time.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19597
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2005-02-09 14:49 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-23 22:55 [Bug rtl-optimization/19597] New: avr-gcc 4.0, multiplication by constant, very long code dmixm at marine dot febras dot ru
2005-01-23 23:02 ` [Bug middle-end/19597] [4.0 Regression] " pinskia at gcc dot gnu dot org
2005-01-23 23:56 ` giovannibajo at libero dot it
2005-01-24 0:49 ` bernie at develer dot com
2005-01-24 2:54 ` roger at eyesopen dot com
2005-01-24 8:17 ` [Bug target/19597] " pinskia at gcc dot gnu dot org
2005-01-24 8:56 ` giovannibajo at libero dot it
2005-01-24 9:24 ` marekm at amelek dot gda dot pl
2005-01-24 10:28 ` bernie at develer dot com
2005-01-24 13:16 ` bernie at develer dot com
2005-01-25 20:33 ` schlie at comcast dot net
2005-01-25 21:23 ` roger at eyesopen dot com
2005-01-25 23:20 ` schlie at comcast dot net
2005-02-09 12:44 ` pinskia at gcc dot gnu dot org
2005-02-09 13:06 ` pinskia at gcc dot gnu dot org
2005-02-09 13:09 ` pinskia at gcc dot gnu dot org
2005-02-09 20:09 ` cvs-commit at gcc dot gnu dot org
2005-02-09 20:13 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).