public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/15352] [tree-ssa] missed jump threading opportunity due to lack of short circuit
Date: Mon, 14 Feb 2005 22:38:00 -0000	[thread overview]
Message-ID: <20050214200141.24231.qmail@sourceware.org> (raw)
In-Reply-To: <20040509195933.15352.kazu@cs.umass.edu>


------- Additional Comments From law at redhat dot com  2005-02-14 20:01 -------
The new jump thread selection code handles this properly.

I will note that your comments about the code we ought to be able to generate
are wrong.  The correctly optimized code should look like this:  (note the
difference in where we test c == 3.


foo (a, b, c)
{
  # BLOCK 0
  # PRED: ENTRY [100.0%]  (fallthru,exec)
  if (a_1 == 1) goto <L3>; else goto <L0>;
  # SUCC: 3 [14.9%]  (true,exec) 1 [85.1%]  (false,exec)

  # BLOCK 1
  # PRED: 0 [85.1%]  (false,exec)
<L0>:;
  if (b_3 == 2) goto <L2>; else goto <L5>;
  # SUCC: 2 [45.3%]  (true,exec) 5 [54.7%]  (false,exec)

  # BLOCK 2
  # PRED: 1 [45.3%]  (true,exec)
<L2>:;
  if (c_2 == 3) goto <L3>; else goto <L4>;
  # SUCC: 3 [48.8%]  (true,exec) 4 [51.2%]  (false,exec)

  # BLOCK 3
  # PRED: 0 [14.9%]  (true,exec) 2 [48.8%]  (true,exec)
<L3>:;
  f1 ();
  goto <bb 5> (<L5>);
  # SUCC: 5 [100.0%]  (fallthru,exec)

  # BLOCK 4
  # PRED: 2 [51.2%]  (false,exec)
<L4>:;
  f2 ();
  # SUCC: 5 [100.0%]  (fallthru,exec)

  # BLOCK 5
  # PRED: 1 [54.7%]  (false,exec) 3 [100.0%]  (fallthru,exec) 4 [100.0%] 
(fallthru,exec)
<L5>:;
  return;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15352


  parent reply	other threads:[~2005-02-14 20:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-09 19:59 [Bug optimization/15352] New: [tree-ssa] kazu at cs dot umass dot edu
2004-05-09 20:00 ` [Bug optimization/15352] [tree-ssa] missed jump threading opportunity due to lack of short circuit kazu at cs dot umass dot edu
2004-05-09 20:51 ` pinskia at gcc dot gnu dot org
2004-05-09 22:11 ` pinskia at gcc dot gnu dot org
2004-05-13 23:50 ` [Bug tree-optimization/15352] " pinskia at gcc dot gnu dot org
2004-05-24 22:23 ` pinskia at gcc dot gnu dot org
2005-02-14 22:38 ` law at redhat dot com [this message]
2005-02-15  0:32 ` pinskia at gcc dot gnu dot org
2005-04-23  0:56 ` law at redhat dot com
2005-04-25  4:58 ` law at redhat dot com
     [not found] <bug-15352-4@http.gcc.gnu.org/bugzilla/>
2013-11-09 20:40 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050214200141.24231.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).