[Bug ada/19865] New: ice / gnat bug detected.

[Bug ada/19865] New: ice / gnat bug detected.

[pluto at pld-linux dot org]

../../xgcc -c -I./ -I../rts -I. 
-I/home/users/builder2/devel/pld/sandbox/gcc/BUILD/gcc-4.0-20050130/gcc/ada 
-B../../ -O2 -O2 -fsigned-char -gnatpg -gnata 
-I- 
/home/users/builder2/devel/pld/sandbox/gcc/BUILD/gcc-4.0-20050130/gcc/ada/m 
akegpr.adb gnat1: warning: command line option "-fsigned-char" is valid for 
C/C++/ObjC/ObjC++ but not for Ada+ 
 
===========================GNAT BUG DETECTED==============================+| 
4.0.0 20050130 (experimental) (PLD Linux) (powerpc-pld-linux-gnu) 
GCC error: 
tree check: expected ssa_name, have var_decl in verify_ssa, at           
tree-ssa.c:680 
Error detected at makegpr.adb:4167:23

-- 
           Summary: ice / gnat bug detected.
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pluto at pld-linux dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: ppc-pld-linux
  GCC host triplet: ppc-pld-linux
GCC target triplet: ppc-pld-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] ice / gnat bug detected.

[mmazur at kernel dot pl]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmazur at kernel dot pl


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-09 19:47 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |19853
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|0000-00-00 00:00:00         |2005-02-09 19:47:29
               date|                            |
            Summary|ice / gnat bug detected.    |[4.0 Regression] ice / gnat
                   |                            |bug detected.


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[awreynolds at mac dot com]

------- Additional Comments From awreynolds at mac dot com  2005-02-10 03:49 -------
This also occurs on powerpc-apple-darwin and has been for at least a week.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[bosch at gcc dot gnu dot org]

------- Additional Comments From bosch at gcc dot gnu dot org  2005-02-14 20:11 -------
This happens after in verify-ssa after running the kill_redundant_phi_nodes pass. It would be great if 
someone with a better understanding of this pass could take a look at this bug.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bosch at gnat dot com
   Last reconfirmed|2005-02-09 19:47:29         |2005-02-14 20:11:08
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-14 20:48 -------
(In reply to comment #3)
> This happens after in verify-ssa after running the kill_redundant_phi_nodes pass. It would be great if 
> someone with a better understanding of this pass could take a look at this bug.

Just a note for future people when looking over this bug, most of the discussion of this bug and how to 
fix this is in PR 19853.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[dnovillo at gcc dot gnu dot org]

-- 
Bug 19865 depends on bug 19853, which changed state.

Bug 19853 Summary: [4.0 Regression] incorrect vops after exposing a new global variable
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19853

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[uweigand at gcc dot gnu dot org]

------- Additional Comments From uweigand at gcc dot gnu dot org  2005-02-14 21:05 -------
Diego asked me to post a reduced test case; here we go.

This should go into a file named pr19865.ads:

package PR19865 is
   procedure Test;
end PR19865;

and this into a file named pr19865.adb:

package body PR19865 is

   type String_Access is access all String;
   type String_List is array (Positive range <>) of String_Access;
   type String_List_Access is access all String_List;

   No_Argument : aliased String_List := (1 .. 0 => null);

   package Cache_Args is
      type Table_Type is
        array (Integer range <>) of String_Access;
      subtype Big_Table_Type is
        Table_Type (1 .. Integer'Last);

      type Table_Ptr is access all Big_Table_Type;
      Table : aliased Table_Ptr := null;

      Last_Val : Integer;
   end Cache_Args;

   function Get_Name_String return String;
   function Get_Name_String return String is
   begin
      return "";
   end Get_Name_String;

   procedure Build_Dynamic_Library (Options : String_List);
   procedure Build_Dynamic_Library (Options : String_List) is
   begin
      null;
   end Build_Dynamic_Library;

   procedure Test is
      Lib_Opts : String_List_Access := No_Argument'Unrestricted_Access;
   begin
      for Index in 1 .. Cache_Args.Last_Val loop
         if Cache_Args.Table (Index).all = Get_Name_String then
            exit;
         end if;
      end loop;

      Build_Dynamic_Library (Lib_Opts.all);
   end Test;

end PR19865;


The error occurs when building this with
  gnat1 -I<path-to-srcdir>/gcc/ada -O2 pr19865.adb
(I've tested a gnat1 configured for s390-ibm-linux.)

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uweigand at de dot ibm dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[dnovillo at gcc dot gnu dot org]

------- Additional Comments From dnovillo at gcc dot gnu dot org  2005-02-14 21:08 -------

Thanks for the test case.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dnovillo at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-14 21:27 -------
(In reply to comment #5)
> The error occurs when building this with
>   gnat1 -I<path-to-srcdir>/gcc/ada -O2 pr19865.adb
> (I've tested a gnat1 configured for s390-ibm-linux.)

And I can reproduce this with the reduced testcase on  powerpc-darwin also. 

You most likely can reproduce it on i686-pc-linux-gnu when you change the MOVE_COST to be 
something lower.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[dnovillo at gcc dot gnu dot org]

------- Additional Comments From dnovillo at gcc dot gnu dot org  2005-02-14 22:06 -------
(In reply to comment #7)
> (In reply to comment #5)
> > The error occurs when building this with
> >   gnat1 -I<path-to-srcdir>/gcc/ada -O2 pr19865.adb
> > (I've tested a gnat1 configured for s390-ibm-linux.)
> 
> And I can reproduce this with the reduced testcase on  powerpc-darwin also. 
> 
> You most likely can reproduce it on i686-pc-linux-gnu when you change the
MOVE_COST to be 
> something lower.

Did you mean MOVE_RATIO?

In any case.  I can't reproduce this test case on x86 with various combinations
of --param sra-max-structure-size and --param sra-field-structure-ratio=100.  I
get clean bootstraps with Ada too.

I'll see if my ppc has Ada installed.  In the meantime, could you show me the IL
snippets where we fail and what SRA did in that function?  The test case is
still rather large.


Thanks.  Diego.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-14 22:10 -------
>From PR 18706 when I was looking into the bootstrap bug before

"I think this is the same failure as the current bootstrap problem on ppc-darwin.
For the bootstrap problem we have the following CONST_DECL:
  static struct gnat__strings__string_access C.828 = {.P_ARRAY=(character[(long int) 
<PLACEHOLDER_EXPR struct gnat__strings__string_access>.P_BOUNDS->LB0:(long int) 
<PLACEHOLDER_EXPR struct gnat__strings__string_access>.P_BOUNDS->UB0] *) "", 
.P_BOUNDS=&{.LB0=1, .UB0=0}};

Notice how we take the address of a CONSTRUCTOR this is wrong and we should never do that."

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |18706
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[dnovillo at redhat dot com]

------- Additional Comments From dnovillo at redhat dot com  2005-02-14 22:13 -------
Subject: Re:  [4.0 Regression] ice / gnat bug detected.

pinskia at gcc dot gnu dot org wrote:
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-14 22:10 -------
> From PR 18706 when I was looking into the bootstrap bug before
> 
> "I think this is the same failure as the current bootstrap problem on ppc-darwin.
> For the bootstrap problem we have the following CONST_DECL:
>   static struct gnat__strings__string_access C.828 = {.P_ARRAY=(character[(long int) 
> <PLACEHOLDER_EXPR struct gnat__strings__string_access>.P_BOUNDS->LB0:(long int) 
> <PLACEHOLDER_EXPR struct gnat__strings__string_access>.P_BOUNDS->UB0] *) "", 
> .P_BOUNDS=&{.LB0=1, .UB0=0}};
> 
> Notice how we take the address of a CONSTRUCTOR this is wrong and we should never do that."
> 
That tells me nothing.  Show me the failure and the spot where we fail. 
  You don't seem to be sure of what the problem is.


Diego.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-14 22:34 -------
(In reply to comment #10)
> Subject: Re:  [4.0 Regression] ice / gnat bug detected.

SRA turns:
<bb 0>:
  D.570 = C.8;
into 
  D.851_33 = &pr19865__no_argument + 8B;
  SR.48_32 = (struct pr19865__string_access[(long int) <PLACEHOLDER_EXPR struct 
pr19865__string_list_access>.P_BOUNDS->LB0:(long int) <PLACEHOLDER_EXPR struct 
pr19865__string_list_access>.P_BOUNDS->UB0] *) D.851_33;
  SR.49_10 = &C.56;

And adds:
  static struct pr19865__string_list___XUB C.56 = {.LB0=1, .UB0=0};

Where C.8 was:
  static struct pr19865__string_list_access C.8 = {.P_ARRAY=(struct pr19865__string_access[(long int) 
<PLACEHOLDER_EXPR struct pr19865__string_list_access>.P_BOUNDS->LB0:(long int) 
<PLACEHOLDER_EXPR struct pr19865__string_list_access>.P_BOUNDS->UB0] *) (struct 
pr19865__string_access[1:0] *) ((void *) &pr19865__no_argument + 8B), .P_BOUNDS=&{.LB0=1, 
.UB0=0}};

Is that what you want?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[uweigand at gcc dot gnu dot org]

------- Additional Comments From uweigand at gcc dot gnu dot org  2005-02-14 22:50 -------
(In reply to comment #5)

> The error occurs when building this with
>   gnat1 -I<path-to-srcdir>/gcc/ada -O2 pr19865.adb
> (I've tested a gnat1 configured for s390-ibm-linux.)

I'm sorry, I have mixed up the include statements here.
Using this line, I do not get an ICE either.  I do get 
the ICE when using instead
  gnat1 -I<path-to-builddir>/gcc/ada/rts -O2 pr19865.adb
(after I've built the Ada runtime library, of course).

This different include apparently causes gnat1 to use a
different method of exception handling, which is enough
of a difference to cause the ICE to vanish.


As to what causes the bug, as Andrew said the SRA pass
introduces a new temporary C.56 (in my case C.58), and
like in the other test case, the red-phi pass generates
a virtual operand (a VUSE in this case) for an unrenamed
C.58 in a function call:
<L4>:;
  #   VUSE <C.8_13>;
  #   VUSE <pr19865__no_argument_101>;
  #   VUSE <pr19865__cache_args__last_valX_102>;
  #   VUSE <pr19865__cache_args__tableX_103>;
  #   VUSE <FRAME.13_163>;
  #   VUSE <C.7_51>;
  #   VUSE <TMT.42_164>;
  #   VUSE <TMT.43_165>;
  #   VUSE <TMT.45_166>;
  #   VUSE <C.58>;
  __gnat_rcheck_05 ("pr19865.adb", 37);


This subsequently aborts.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug ada/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-15 02:39 -------
(In reply to comment #8)
> Did you mean MOVE_RATIO?
Yes.  A value of 2 should be able to reproduce it.  If we have any bigger value, the gimplifier will not 
produce the CONST_DECL which we will SRA on it.

Here is the smallest testcase which I could get:
package body PR19865 is
   type Integer_List is array (Positive range <>) of Integer;
   type Integer_List_Access is access all Integer_List;

   No_Argument : aliased Integer_List := (1 .. 0 => 0);
   package Cache_Args is
      Table : aliased Integer_List_Access := null;
   end Cache_Args;
   
   procedure Build_Dynamic_Library (Options : Integer_List);
   procedure Test is
      Lib_Opts : Integer_List_Access := No_Argument'Unrestricted_Access;
   begin
      for Index in 1 .. 1 loop
	Cache_Args.Table(Index) := 0;
      end loop;
      Build_Dynamic_Library (Lib_Opts.all);
   end Test;
   
   procedure Build_Dynamic_Library (Options : Integer_List) is
   begin
      null;
   end Build_Dynamic_Library;
end PR19865;
package PR19865 is
   procedure Test;
end PR19865;

Write it out to a file called t.ada and run gnatchop on it.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug middle-end/19865] [4.0 Regression] ice / gnat bug detected.

[uweigand at gcc dot gnu dot org]

------- Additional Comments From uweigand at gcc dot gnu dot org  2005-02-15 12:18 -------
The smaller test case also still ICEs on s390.  Thanks!

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug middle-end/19865] [4.0 Regression] ice / gnat bug detected.

[dnovillo at redhat dot com]

------- Additional Comments From dnovillo at redhat dot com  2005-02-16 15:16 -------
Subject: Re:  [4.0 Regression] ice / gnat bug detected.

pinskia at gcc dot gnu dot org wrote:

> Is that what you want?
> 
Yes, thanks.  I can now reproduce this on my ppc box with your reduced 
test case.  I'll take a look.


Diego.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug middle-end/19865] [4.0 Regression] ice / gnat bug detected.

[dnovillo at gcc dot gnu dot org]

------- Additional Comments From dnovillo at gcc dot gnu dot org  2005-02-16 19:21 -------
Fixed.  http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00943.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug middle-end/19865] [4.0 Regression] ice / gnat bug detected.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-16 19:19 -------
Subject: Bug 19865

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	dnovillo@gcc.gnu.org	2005-02-16 19:19:35

Modified files:
	gcc            : ChangeLog tree-optimize.c 

Log message:
	PR tree-optimization/19865
	* tree-optimize.c (init_tree_optimization_passes): Run
	pass_may_alias after pass_sra.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.7495&r2=2.7496
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-optimize.c.diff?cvsroot=gcc&r1=2.71&r2=2.72



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865

[Bug middle-end/19865] [4.0 Regression] ice / gnat bug detected.

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19865