public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/20117] New: [4.0.0 Regression] duplicated labels in PIC
@ 2005-02-21 18:23 kkojima at gcc dot gnu dot org
  2005-02-21 18:45 ` [Bug target/20117] " kkojima at gcc dot gnu dot org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: kkojima at gcc dot gnu dot org @ 2005-02-21 18:23 UTC (permalink / raw)
  To: gcc-bugs

4.0.0 generates duplicated labels on sh4-unknown-linux-gnu with -fPIC -O2
for the code below:

void bar (void);

int f(int i, int j)
{
  static void *a[5] = {&&b,&&c,&&d,&&e,&&f};

    if (i >=5) i = 0; if (i<=0)i=5;
    goto *a[i];
  e:
    i++;  if (i >=5) i = 0; if (i<=0)i=5;
    j++;
    goto *a[i];
  f:
    i--;  if (i >=5) i = 0; if (i<=0)i=5;
    j--;
    goto *a[i];
  b:
    i+=2;  if (i >=5) i = 0; if (i<=0)i=5;
    goto *a[i];
  c:
    i*=2;  if (i >=5) i = 0; if (i<=0)i=5;
    bar ();
    goto *a[i];
  d:;
}

which is a slightly modified testcase in PR 15242.  SH uses the unique
label for PIC call insn and it's noncopyable.  duplicate_computed_gotos
which was introduced to solve PR 15242 copies the block including call
insn for bar and produces duplicated labels.  I'm proposing a patch
http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00924.html to avoid this.

-- 
           Summary: [4.0.0 Regression] duplicated labels in PIC
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kkojima at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gn
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: sh4-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20117


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug target/20117] [4.0.0 Regression] duplicated labels in PIC
  2005-02-21 18:23 [Bug target/20117] New: [4.0.0 Regression] duplicated labels in PIC kkojima at gcc dot gnu dot org
@ 2005-02-21 18:45 ` kkojima at gcc dot gnu dot org
  2005-02-22  0:48 ` [Bug rtl-optimization/20117] [4.0 " pinskia at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: kkojima at gcc dot gnu dot org @ 2005-02-21 18:45 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.0.0
      Known to work|                            |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20117


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug rtl-optimization/20117] [4.0 Regression] duplicated labels in PIC
  2005-02-21 18:23 [Bug target/20117] New: [4.0.0 Regression] duplicated labels in PIC kkojima at gcc dot gnu dot org
  2005-02-21 18:45 ` [Bug target/20117] " kkojima at gcc dot gnu dot org
@ 2005-02-22  0:48 ` pinskia at gcc dot gnu dot org
  2005-02-25 16:20 ` cvs-commit at gcc dot gnu dot org
  2005-02-25 17:04 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-22  0:48 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-21 21:38 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|target                      |rtl-optimization
     Ever Confirmed|                            |1
           Keywords|                            |patch
   Last reconfirmed|0000-00-00 00:00:00         |2005-02-21 21:38:06
               date|                            |
            Summary|[4.0.0 Regression]          |[4.0 Regression] duplicated
                   |duplicated labels in PIC    |labels in PIC


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20117


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug rtl-optimization/20117] [4.0 Regression] duplicated labels in PIC
  2005-02-21 18:23 [Bug target/20117] New: [4.0.0 Regression] duplicated labels in PIC kkojima at gcc dot gnu dot org
  2005-02-21 18:45 ` [Bug target/20117] " kkojima at gcc dot gnu dot org
  2005-02-22  0:48 ` [Bug rtl-optimization/20117] [4.0 " pinskia at gcc dot gnu dot org
@ 2005-02-25 16:20 ` cvs-commit at gcc dot gnu dot org
  2005-02-25 17:04 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-02-25 16:20 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-25 07:13 -------
Subject: Bug 20117

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	kkojima@gcc.gnu.org	2005-02-25 07:13:26

Modified files:
	gcc            : ChangeLog bb-reorder.c 

Log message:
	PR rtl-optimization/20117
	* bb-reorder.c (duplicate_computed_gotos): Don't duplicate
	the block including noncopyable insn.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.7591&r2=2.7592
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/bb-reorder.c.diff?cvsroot=gcc&r1=1.91&r2=1.92



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20117


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug rtl-optimization/20117] [4.0 Regression] duplicated labels in PIC
  2005-02-21 18:23 [Bug target/20117] New: [4.0.0 Regression] duplicated labels in PIC kkojima at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2005-02-25 16:20 ` cvs-commit at gcc dot gnu dot org
@ 2005-02-25 17:04 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-25 17:04 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-25 12:32 -------
Fixed in 4.0.0 (before the branch) so closing as fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20117


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2005-02-25 12:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-21 18:23 [Bug target/20117] New: [4.0.0 Regression] duplicated labels in PIC kkojima at gcc dot gnu dot org
2005-02-21 18:45 ` [Bug target/20117] " kkojima at gcc dot gnu dot org
2005-02-22  0:48 ` [Bug rtl-optimization/20117] [4.0 " pinskia at gcc dot gnu dot org
2005-02-25 16:20 ` cvs-commit at gcc dot gnu dot org
2005-02-25 17:04 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).