public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line.
@ 2005-02-22 7:17 dir at lanl dot gov
2005-02-22 9:56 ` [Bug libfortran/20131] " pinskia at gcc dot gnu dot org
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: dir at lanl dot gov @ 2005-02-22 7:17 UTC (permalink / raw)
To: gcc-bugs
I finally realized that this is actually the source of most of the data reading
problems that I have had. If you look at the hex dump of the file, the first
line has extra padding blanks and reads correctly. The second line has no
padding and gfortran reads past the end of line and takes data from the third
line and prints it.
[dir:~/tests/gfortran] dir% gfortran -o fread03 fread03.f
[dir:~/tests/gfortran] dir% fread03 < fread03.dat
1 0
1 2
STOP 0
[dir:~/tests/gfortran] dir% cat fread03.f
program main
do 10 j=1,2
read(5,1010) nload,npr2
write(6,1010) nload,npr2
10 continue
1010 format (16i5)
stop
end
[dir:~/tests/gfortran] dir% cat fread03.dat
1
1
2
[dir:~/tests/gfortran] dir% dump -i fread03.dat
File name: fread03.dat Block number: 0 Byte number: 0
0000 20 20 20 20 31 20 20 20 20 20 20 20 20 20 20 0a 1 .
0010 20 20 20 20 31 0a 20 20 20 20 32 0a 00 00 00 00 1. 2.
EOF encountered. Do you want to continue ? n
--
Summary: gfortan - incorrectly reads beyond the end of line.
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: dir at lanl dot gov
CC: gcc-bugs at gcc dot gnu dot org
GCC host triplet: powerpc-apple-darwin7.8.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
@ 2005-02-22 9:56 ` pinskia at gcc dot gnu dot org
2005-02-23 15:45 ` Thomas dot Koenig at online dot de
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-02-22 9:56 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-02-22 01:34 -------
Confirmed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Component|fortran |libfortran
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-02-22 01:34:31
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
2005-02-22 9:56 ` [Bug libfortran/20131] " pinskia at gcc dot gnu dot org
@ 2005-02-23 15:45 ` Thomas dot Koenig at online dot de
2005-02-24 11:45 ` Thomas dot Koenig at online dot de
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Thomas dot Koenig at online dot de @ 2005-02-23 15:45 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From Thomas dot Koenig at online dot de 2005-02-23 12:28 -------
I'll check later wether this is fixed with the proposed fix
for PR 19568 to be found at
http://gcc.gnu.org/ml/gcc-patches/2005-01/msg02295.html
Thomas
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |Thomas dot Koenig at online
| |dot de
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
2005-02-22 9:56 ` [Bug libfortran/20131] " pinskia at gcc dot gnu dot org
2005-02-23 15:45 ` Thomas dot Koenig at online dot de
@ 2005-02-24 11:45 ` Thomas dot Koenig at online dot de
2005-03-06 23:34 ` Thomas dot Koenig at online dot de
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Thomas dot Koenig at online dot de @ 2005-02-24 11:45 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From Thomas dot Koenig at online dot de 2005-02-23 21:27 -------
No, this isn't fixed with the patch I referred to earlier.
Thomas
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (2 preceding siblings ...)
2005-02-24 11:45 ` Thomas dot Koenig at online dot de
@ 2005-03-06 23:34 ` Thomas dot Koenig at online dot de
2005-03-08 8:20 ` Thomas dot Koenig at online dot de
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Thomas dot Koenig at online dot de @ 2005-03-06 23:34 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From Thomas dot Koenig at online dot de 2005-03-06 23:34 -------
Patch:
http://gcc.gnu.org/ml/gcc-patches/2005-03/msg00566.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (3 preceding siblings ...)
2005-03-06 23:34 ` Thomas dot Koenig at online dot de
@ 2005-03-08 8:20 ` Thomas dot Koenig at online dot de
2005-04-10 8:36 ` cvs-commit at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Thomas dot Koenig at online dot de @ 2005-03-08 8:20 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From Thomas dot Koenig at online dot de 2005-03-08 08:20 -------
Updated patch:
http://gcc.gnu.org/ml/gcc-patches/2005-03/msg00729.html
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (4 preceding siblings ...)
2005-03-08 8:20 ` Thomas dot Koenig at online dot de
@ 2005-04-10 8:36 ` cvs-commit at gcc dot gnu dot org
2005-04-10 8:41 ` tkoenig at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-04-10 8:36 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-04-10 08:36 -------
Subject: Bug 20131
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: tkoenig@gcc.gnu.org 2005-04-10 08:35:40
Modified files:
libgfortran : ChangeLog
libgfortran/io : transfer.c
gcc/testsuite : ChangeLog
Added files:
gcc/testsuite/gfortran.dg: eor_handling_1.f90 eor_handling_2.f90
eor_handling_3.f90 eor_handling_4.f90
eor_handling_5.f90 noadv_size.f90
pad_no.f90
Log message:
2005-04-10 Thomas Koenig <Thomas.Koenig@online.de>
PR libfortran/17992
PR libfortran/19568
PR libfortran/19595
PR libfortran/20005
PR libfortran/20092
PR libfortran/20131
PR libfortran/20138
PR libfortran/20661
PR libfortran/20744
* io/transfer.c (top level): eor_condition: New static variable.
(read_sf): Remove unnecessary zeroing of buffer (there is enough
information in its length).
Return a string of length 0 (to be padded by caller) if EOR was
seen previously.
Remove erroneous special casing of EOR for standard input.
Set eor_condition for non-advancing I/O if an end of line was
detected.
Increment ioparm.size if necessary.
(formatted_transfer): Skip the function if there is an EOR condition.
(data_transfer_init): Initialize eor_condition to zero (false).
(next_record_r): Clear sf_seen_eor if a \n has been seen already.
(finalize_transfer): If there is an EOR condition, raise the error.
2005-04-10 Thomas Koenig <Thomas.Koenig@online.de>
* eor_handling_1.f90: New test case.
* eor_handling_2.f90: New test case.
* eor_handling_3.f90: New test case.
* eor_handling_4.f90: New test case.
* eor_handling_5.f90: New test case.
* noadv_size.f90: New test case.
* pad_no.f90: New test case.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.188&r2=1.189
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/transfer.c.diff?cvsroot=gcc&r1=1.35&r2=1.36
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5320&r2=1.5321
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_1.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_2.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_3.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_4.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_5.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/noadv_size.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/pad_no.f90.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (5 preceding siblings ...)
2005-04-10 8:36 ` cvs-commit at gcc dot gnu dot org
@ 2005-04-10 8:41 ` tkoenig at gcc dot gnu dot org
2005-05-03 19:41 ` [Bug libfortran/20131] [4.0 only] " cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-04-10 8:41 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tkoenig at gcc dot gnu dot org 2005-04-10 08:41 -------
Fixed in 4.1.0, waiting for 4.0 to reopen.
--
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] [4.0 only] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (6 preceding siblings ...)
2005-04-10 8:41 ` tkoenig at gcc dot gnu dot org
@ 2005-05-03 19:41 ` cvs-commit at gcc dot gnu dot org
2005-05-03 19:48 ` tkoenig at gcc dot gnu dot org
2005-06-05 7:44 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-03 19:41 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-03 19:40 -------
Subject: Bug 20131
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: tkoenig@gcc.gnu.org 2005-05-03 19:39:36
Modified files:
libgfortran : ChangeLog
libgfortran/io : transfer.c
gcc/testsuite : ChangeLog
Added files:
gcc/testsuite/gfortran.dg: eor_handling_1.f90 eor_handling_2.f90
eor_handling_3.f90 eor_handling_4.f90
eor_handling_5.f90 noadv_size.f90
pad_no.f90
Log message:
2005-05-03 Thomas Koenig <Thomas.Koenig@online.de>
Backport from mainline:
PR libfortran/17992
PR libfortran/19568
PR libfortran/19595
PR libfortran/20005
PR libfortran/20092
PR libfortran/20131
PR libfortran/20661
PR libfortran/20744
* io/transfer.c (top level): eor_condition: New static variable.
(read_sf): Remove unnecessary zeroing of buffer (there is enough
information in its length).
Return a string of length 0 (to be padded by caller) if EOR was
seen previously.
Remove erroneous special casing of EOR for standard input.
Set eor_condition for non-advancing I/O if an end of line was
detected.
Increment ioparm.size if necessary.
(formatted_transfer): Skip the function if there is an EOR condition.
(data_transfer_init): Initialize eor_condition to zero (false).
(next_record_r): Clear sf_seen_eor if a \n has been seen already.
(finalize_transfer): If there is an EOR condition, raise the error.
2005-05-03 Thomas Koenig <Thomas.Koenig@online.de>
Backport from mainline:
* eor_handling_1.f90: New test case.
* eor_handling_2.f90: New test case.
* eor_handling_3.f90: New test case.
* eor_handling_4.f90: New test case.
* eor_handling_5.f90: New test case.
* noadv_size.f90: New test case.
* pad_no.f90: New test case.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.22&r2=1.163.2.23
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/transfer.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.32.2.2&r2=1.32.2.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.156&r2=1.5084.2.157
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_1.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_2.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_3.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_4.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/eor_handling_5.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/noadv_size.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/pad_no.f90.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.6.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] [4.0 only] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (7 preceding siblings ...)
2005-05-03 19:41 ` [Bug libfortran/20131] [4.0 only] " cvs-commit at gcc dot gnu dot org
@ 2005-05-03 19:48 ` tkoenig at gcc dot gnu dot org
2005-06-05 7:44 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: tkoenig at gcc dot gnu dot org @ 2005-05-03 19:48 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tkoenig at gcc dot gnu dot org 2005-05-03 19:47 -------
Patch committed to 4.0.1. Fixed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug libfortran/20131] [4.0 only] gfortan - incorrectly reads beyond the end of line.
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
` (8 preceding siblings ...)
2005-05-03 19:48 ` tkoenig at gcc dot gnu dot org
@ 2005-06-05 7:44 ` pinskia at gcc dot gnu dot org
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-05 7:44 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20131
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2005-06-05 7:44 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-22 7:17 [Bug fortran/20131] New: gfortan - incorrectly reads beyond the end of line dir at lanl dot gov
2005-02-22 9:56 ` [Bug libfortran/20131] " pinskia at gcc dot gnu dot org
2005-02-23 15:45 ` Thomas dot Koenig at online dot de
2005-02-24 11:45 ` Thomas dot Koenig at online dot de
2005-03-06 23:34 ` Thomas dot Koenig at online dot de
2005-03-08 8:20 ` Thomas dot Koenig at online dot de
2005-04-10 8:36 ` cvs-commit at gcc dot gnu dot org
2005-04-10 8:41 ` tkoenig at gcc dot gnu dot org
2005-05-03 19:41 ` [Bug libfortran/20131] [4.0 only] " cvs-commit at gcc dot gnu dot org
2005-05-03 19:48 ` tkoenig at gcc dot gnu dot org
2005-06-05 7:44 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).