[Bug libobjc/19024] New: name collisions libobjc/libmysqlclient

[Bug libobjc/19024] New: name collisions libobjc/libmysqlclient

[d dot ayers at inode dot at]

It would be great it the exported symbols of hash.h could be migrated to a
version with an objc_ prefix.  There are currently name collistions with some
versions of the mysqlclient library.  If someone can propose a migration
strategy I can provide a patch.  My guess would be along the lines of:

hash.h
#define hash_func objc_hash_func
export void objc_hash_func(void)

hash.c
void objc_hash_func(void) {...}
void hash_func { log?("deprecated"); objc_hash_func(); }
/* for binary compatibility for a limited time.  */

-- 
           Summary: name collisions libobjc/libmysqlclient
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libobjc
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: d dot ayers at inode dot at
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-15 23:40 -------
Confirmed, Mine, I will look at doing that tomorrow.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-12-15 23:40:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-03-01 17:46 -------
Here is how I would fix this use objc_hash_* in libobjc and then declare in hash.h, a deperated inline 
functions which call the new functions.  The other thing would be have a new file which has those inline 
functions actually there so we can be still binary compatible.

So:
in hash.h, hash_new becomes objc_hash_new and there would be an inline function called hash_new 
which just calls objc_hash_new.
in hash_compat.c, we have hash_new which just calls objc_hash_new.

What do you think?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-03-02 19:37 -------
Subject: Bug 19024

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2005-03-02 19:37:03

Modified files:
	libobjc        : ChangeLog Makefile.in archive.c hash.c init.c 
	                 libobjc.def selector.c 
	libobjc/objc   : hash.h 
Added files:
	libobjc        : hash_compat.c 

Log message:
	2005-03-02  David Ayers  <d.ayers@inode.at>
	
	PR libobjc/19024
	* Makefile.in (OBJS): Add hash_compat.lo.
	(OBJS_GC): Add hash_compat_gc.lo.
	(hash_compat_gc.lo): New target and rule.
	* objc/hash.h (hash_new, hash_delete, hash_add, hash_remove)
	(hash_next, hash_value_for_key, hash_is_key_in_hash)
	(hash_ptr, hash_string, compare_ptrs, compare_strings): Prefix
	with objc_.  Add deprecated non prefixed inlined versions.
	(OBJC_IGNORE_DEPRECATED_API): New macro to hide deprecated
	declarations.
	* hash.c (hash_new, hash_delete, hash_add, hash_remove, hash_next)
	(hash_value_for_key, hash_is_key_in_hash): Prefix with objc_ and
	update callers.
	* hash_compat.c: New file.
	* archive.c: Update callers.
	* init.c: Likewise.
	* selector.c: Likewise.
	* libobjc.def: Add objc_ versions of hash functions.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/hash_compat.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/ChangeLog.diff?cvsroot=gcc&r1=1.159&r2=1.160
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/Makefile.in.diff?cvsroot=gcc&r1=1.46&r2=1.47
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/archive.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/hash.c.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/init.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/libobjc.def.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/selector.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/objc/hash.h.diff?cvsroot=gcc&r1=1.11&r2=1.12



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-03-02 19:39 -------
Fixed in 4.1.0 (which is a ways off), I am thinking about backporting this to the 4.0 branch but I don't 
know if I should.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-03-02 20:12 -------
Subject: Bug 19024

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	pinskia@gcc.gnu.org	2005-03-02 20:12:18

Modified files:
	libobjc        : ChangeLog Makefile.in archive.c hash.c init.c 
	                 libobjc.def selector.c 
	libobjc/objc   : hash.h 
Added files:
	libobjc        : hash_compat.c 

Log message:
	2005-03-02  David Ayers  <d.ayers@inode.at>
	
	PR libobjc/19024
	* Makefile.in (OBJS): Add hash_compat.lo.
	(OBJS_GC): Add hash_compat_gc.lo.
	(hash_compat_gc.lo): New target and rule.
	* objc/hash.h (hash_new, hash_delete, hash_add, hash_remove)
	(hash_next, hash_value_for_key, hash_is_key_in_hash)
	(hash_ptr, hash_string, compare_ptrs, compare_strings): Prefix
	with objc_.  Add deprecated non prefixed inlined versions.
	(OBJC_IGNORE_DEPRECATED_API): New macro to hide deprecated
	declarations.
	* hash.c (hash_new, hash_delete, hash_add, hash_remove, hash_next)
	(hash_value_for_key, hash_is_key_in_hash): Prefix with objc_ and
	update callers.
	* hash_compat.c: New file.
	* archive.c: Update callers.
	* init.c: Likewise.
	* selector.c: Likewise.
	* libobjc.def: Add objc_ versions of hash functions.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/hash_compat.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.157&r2=1.157.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/Makefile.in.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.44&r2=1.44.18.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/archive.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.22.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/hash.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5&r2=1.5.40.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/init.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.76.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/libobjc.def.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4&r2=1.4.76.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/selector.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/objc/hash.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.11&r2=1.11.34.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-03-02 20:13 -------
I decided to apply thios to the 4.0 branch also.  Fixed in 4.0.0 also.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024

[Bug libobjc/19024] name collisions libobjc/libmysqlclient

[ayers at gcc dot gnu dot org]

------- Comment #9 from ayers at gcc dot gnu dot org  2005-11-20 12:49 -------
Subject: Bug 19024

Author: ayers
Date: Sun Nov 20 12:49:41 2005
New Revision: 107251

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107251
Log:
2005-11-20  David Ayers  <d.ayers@inode.at>

        PR libobjc/19024
        * objc/hash.h: Remove deprecated hash API.
        * hash_compat.c: Remove.
        * Makefile.in: Remove reference to hash_compat.c.

        * configure.ac (VERSION): Bump library version to 2:0:0.
        * configure: Regenerate.


Removed:
    trunk/libobjc/hash_compat.c
Modified:
    trunk/libobjc/ChangeLog
    trunk/libobjc/Makefile.in
    trunk/libobjc/configure
    trunk/libobjc/configure.ac
    trunk/libobjc/objc/hash.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19024