[Bug preprocessor/20348] New: File not included when file with same name is included before

[Bug preprocessor/20348] New: File not included when file with same name is included before

[pepster at users dot sourceforge dot net]

Source submitted as attachment

~/gcc4build/bin/gcc -v -I. -Iinc1   -E t1.cc
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../gcc-4.0-20050220/configure --prefix=/home/joseph/gcc4build
--enable-languages=c,c++
Thread model: posix
gcc version 4.0.0 20050220 (experimental)
 /home/joseph/gcc4build/libexec/gcc/i686-pc-linux-gnu/4.0.0/cc1plus -E -quiet -v
-I. -Iinc1 -D_GNU_SOURCE t1.cc -mtune=pentiumpro
ignoring nonexistent directory
"/home/joseph/gcc4build/lib/gcc/i686-pc-linux-gnu/4.0.0/../../../../i686-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 .
 inc1
 /home/joseph/gcc4build/lib/gcc/i686-pc-linux-gnu/4.0.0/../../../../include/c++/4.0.0
 /home/joseph/gcc4build/lib/gcc/i686-pc-linux-gnu/4.0.0/../../../../include/c++/4.0.0/i686-pc-linux-gnu
 /home/joseph/gcc4build/lib/gcc/i686-pc-linux-gnu/4.0.0/../../../../include/c++/4.0.0/backward
 /usr/local/include
 /home/joseph/gcc4build/include
 /home/joseph/gcc4build/lib/gcc/i686-pc-linux-gnu/4.0.0/include
 /usr/include
End of search list.
# 1 "t1.cc"
# 1 "<built-in>"
# 1 "<command line>"
# 1 "t1.cc"
# 1 "inc1/h2.h" 1
# 1 "inc1/h1.h" 1
# 1 "inc1/h2.h" 2
# 2 "t1.cc" 2


# 1 "inc1/h1.h" 1
# 5 "t1.cc" 2

Compilation finished at Mon Mar  7 02:06:36

-- 
           Summary: File not included when file with same name is included
                    before
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pepster at users dot sourceforge dot net
                CC: gcc-bugs at gcc dot gnu dot org
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] File not included when file with same name is included before

[pepster at users dot sourceforge dot net]

------- Additional Comments From pepster at users dot sourceforge dot net  2005-03-06 13:09 -------
Created an attachment (id=8344)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8344&action=view)
setup for recreating bug


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-03-06 15:34 -------
Confirmed.  There is some caching going wrong here.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Severity|normal                      |critical
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
      Known to fail|                            |4.0.0 4.1.0
      Known to work|                            |3.4.0
   Last reconfirmed|0000-00-00 00:00:00         |2005-03-06 15:34:10
               date|                            |
            Summary|File not included when file |[4.0/4.1 Regression] File
                   |with same name is included  |not included when file with
                   |before                      |same name is included before
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-15 13:22 -------
*** Bug 21039 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matz at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.1                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[pepster at users dot sourceforge dot net]

------- Additional Comments From pepster at users dot sourceforge dot net  2005-07-09 21:54 -------
Thats just great. A critical bug reported for 4.0.0, target set to 4.0.2 still
unfixed in 4.1.0.

And I can't upgrade and try out the new vectors stuff ....

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[jakub at gcc dot gnu dot org]

------- Additional Comments From jakub at gcc dot gnu dot org  2005-08-26 15:57 -------
This got broken by the libcpp/files.c part of
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00272.html
My understanding of the change was that this was just a performance improvement.
The question is if that change is fixable to handle this and keep the
improvements where they can be used, or if it should be reverted.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bje at gcc dot gnu dot org,
                   |                            |zackw at panix dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[jakub at gcc dot gnu dot org]

------- Additional Comments From jakub at gcc dot gnu dot org  2005-08-26 16:16 -------
*** Bug 20356 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

Re: [Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[Neil Booth]

jakub at gcc dot gnu dot org wrote:-

> 
> ------- Additional Comments From jakub at gcc dot gnu dot org  2005-08-26 15:57 -------
> This got broken by the libcpp/files.c part of
> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00272.html
> My understanding of the change was that this was just a performance improvement.
> The question is if that change is fixable to handle this and keep the
> improvements where they can be used, or if it should be reverted.

I would back it out; I suspect the perceived performance improvement
came from missing some cases like these.  IMO the code was already
quite efficient.

Neil.

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[neil at daikokuya dot co dot uk]

------- Additional Comments From neil at daikokuya dot co dot uk  2005-08-27 05:44 -------
Subject: Re:  [4.0/4.1 Regression] File not included when file with same name is included before

jakub at gcc dot gnu dot org wrote:-

> 
> ------- Additional Comments From jakub at gcc dot gnu dot org  2005-08-26 15:57 -------
> This got broken by the libcpp/files.c part of
> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00272.html
> My understanding of the change was that this was just a performance improvement.
> The question is if that change is fixable to handle this and keep the
> improvements where they can be used, or if it should be reverted.

I would back it out; I suspect the perceived performance improvement
came from missing some cases like these.  IMO the code was already
quite efficient.

Neil.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-30 06:28 -------
Subject: Bug 20348

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	jakub@gcc.gnu.org	2005-08-30 06:28:22

Modified files:
	libcpp         : ChangeLog 
	gcc/testsuite  : ChangeLog 
	libcpp         : files.c 
Added files:
	gcc/testsuite/gcc.dg/cpp: pr20356.h pr20356.c pr20348.c 
	                          pr20348.h 
	gcc/testsuite/gcc.dg/cpp/inc: pr20348-aux.h pr20356.h 
	                              pr20356-aux.h pr20348.h 

Log message:
	PR preprocessor/20348
	PR preprocessor/20356
	* files.c (_cpp_find_file, search_cache): Revert 2004-06-26 and
	2004-06-05 changes.
	
	* gcc.dg/cpp/pr20348.c: New test.
	* gcc.dg/cpp/pr20348.h: New file.
	* gcc.dg/cpp/inc/pr20348.h: New file.
	* gcc.dg/cpp/inc/pr20348-aux.h: New file.
	* gcc.dg/cpp/pr20356.c: New test.
	* gcc.dg/cpp/pr20356.h: New file.
	* gcc.dg/cpp/inc/pr20356.h: New file.
	* gcc.dg/cpp/inc/pr20356-aux.h: New file.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&r1=1.75&r2=1.76
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5980&r2=1.5981
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/files.c.diff?cvsroot=gcc&r1=1.12&r2=1.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20356.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20356.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20348.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20348.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20348-aux.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20356.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20356-aux.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20348.h.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-30 06:35 -------
Subject: Bug 20348

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	jakub@gcc.gnu.org	2005-08-30 06:35:45

Modified files:
	libcpp         : ChangeLog 
	gcc/testsuite  : ChangeLog 
	libcpp         : files.c 
Added files:
	gcc/testsuite/gcc.dg/cpp: pr20356.h pr20356.c pr20348.c 
	                          pr20348.h 
	gcc/testsuite/gcc.dg/cpp/inc: pr20348-aux.h pr20356.h 
	                              pr20356-aux.h pr20348.h 

Log message:
	PR preprocessor/20348
	PR preprocessor/20356
	* files.c (_cpp_find_file, search_cache): Revert 2004-06-26 and
	2004-06-05 changes.
	
	* gcc.dg/cpp/pr20348.c: New test.
	* gcc.dg/cpp/pr20348.h: New file.
	* gcc.dg/cpp/inc/pr20348.h: New file.
	* gcc.dg/cpp/inc/pr20348-aux.h: New file.
	* gcc.dg/cpp/pr20356.c: New test.
	* gcc.dg/cpp/pr20356.h: New file.
	* gcc.dg/cpp/inc/pr20356.h: New file.
	* gcc.dg/cpp/inc/pr20356-aux.h: New file.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.56.2.9&r2=1.56.2.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.361&r2=1.5084.2.362
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/files.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9&r2=1.9.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20356.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20356.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20348.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pr20348.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20348-aux.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20356.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20356-aux.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pr20348.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348

[Bug preprocessor/20348] [4.0/4.1 Regression] File not included when file with same name is included before

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-08-30 10:44 -------
Fixed in 4.0.2 by reverting the patch which caused this.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20348