* [Bug c++/1016] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
@ 2003-06-02 19:14 ` pinskia@physics.uc.edu
2004-08-12 0:57 ` [Bug c++/1016] [DR 166] " pinskia at gcc dot gnu dot org
` (15 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: pinskia@physics.uc.edu @ 2003-06-02 19:14 UTC (permalink / raw)
To: gcc-bugs
PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
pinskia@physics.uc.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.4 |---
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
2003-06-02 19:14 ` [Bug c++/1016] friend class declarations not observing namespace rules pinskia@physics.uc.edu
@ 2004-08-12 0:57 ` pinskia at gcc dot gnu dot org
2004-08-23 18:35 ` pinskia at gcc dot gnu dot org
` (14 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-08-12 0:57 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |16995
nThis| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
2003-06-02 19:14 ` [Bug c++/1016] friend class declarations not observing namespace rules pinskia@physics.uc.edu
2004-08-12 0:57 ` [Bug c++/1016] [DR 166] " pinskia at gcc dot gnu dot org
@ 2004-08-23 18:35 ` pinskia at gcc dot gnu dot org
2004-09-04 12:46 ` lerdsuwa at gcc dot gnu dot org
` (13 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-08-23 18:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-08-23 18:35 -------
*** Bug 17122 has been marked as a duplicate of this bug. ***
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |ron at vaniwaarden dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (2 preceding siblings ...)
2004-08-23 18:35 ` pinskia at gcc dot gnu dot org
@ 2004-09-04 12:46 ` lerdsuwa at gcc dot gnu dot org
2004-10-17 15:17 ` lerdsuwa at gcc dot gnu dot org
` (12 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2004-09-04 12:46 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2004-09-04 12:46 -------
Looking at friend class injection bugs.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |lerdsuwa at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (3 preceding siblings ...)
2004-09-04 12:46 ` lerdsuwa at gcc dot gnu dot org
@ 2004-10-17 15:17 ` lerdsuwa at gcc dot gnu dot org
2004-11-26 16:32 ` reichelt at gcc dot gnu dot org
` (11 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2004-10-17 15:17 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2004-10-17 15:17 -------
With patches:
http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01321.html
http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01372.html
GCC gives:
pr1016.C:8: error: field 'b_' has incomplete type
which is still wrong because the injected name is still hidden.
Name lookup should find the global 'b'.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (4 preceding siblings ...)
2004-10-17 15:17 ` lerdsuwa at gcc dot gnu dot org
@ 2004-11-26 16:32 ` reichelt at gcc dot gnu dot org
2004-11-26 16:39 ` lerdsuwa at gcc dot gnu dot org
` (10 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: reichelt at gcc dot gnu dot org @ 2004-11-26 16:32 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From reichelt at gcc dot gnu dot org 2004-11-26 16:31 -------
Kriang, according to your comment in #6 the original example should
compile, right?
And the following example should generate an error in line 12 since
the global class b is not a friend of foo::a, right?
=====================================
class b { void bar(); };
namespace foo
{
class a
{
friend class b;
b b_;
};
}
void b::bar() { foo::a().b_; }
=====================================
In this case we have a rejects-valid on mainline for the example in
comment #1. And an accepts-invalid for the example in this comment
for gcc 2.95.3 - 3.4.3.
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rejects-valid
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (5 preceding siblings ...)
2004-11-26 16:32 ` reichelt at gcc dot gnu dot org
@ 2004-11-26 16:39 ` lerdsuwa at gcc dot gnu dot org
2004-12-28 15:29 ` lerdsuwa at gcc dot gnu dot org
` (9 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2004-11-26 16:39 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2004-11-26 16:39 -------
Right. The code example in comment #1 should compile and
comment #8 should not. Class foo::b, which is still
not declared yet, is the friend of class foo::a. So this
bug is both accepts-invalid and rejects-valid.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (6 preceding siblings ...)
2004-11-26 16:39 ` lerdsuwa at gcc dot gnu dot org
@ 2004-12-28 15:29 ` lerdsuwa at gcc dot gnu dot org
2004-12-28 15:30 ` lerdsuwa at gcc dot gnu dot org
` (8 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2004-12-28 15:29 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2004-12-28 15:29 -------
*** Bug 13830 has been marked as a duplicate of this bug. ***
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |13830
nThis| |
CC| |mattyt-bugzilla at tpg dot
| |com dot au
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (7 preceding siblings ...)
2004-12-28 15:29 ` lerdsuwa at gcc dot gnu dot org
@ 2004-12-28 15:30 ` lerdsuwa at gcc dot gnu dot org
2004-12-30 7:39 ` lerdsuwa at gcc dot gnu dot org
` (7 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2004-12-28 15:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2004-12-28 15:30 -------
*** Bug 15453 has been marked as a duplicate of this bug. ***
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |igodard at pacbell dot net
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (8 preceding siblings ...)
2004-12-28 15:30 ` lerdsuwa at gcc dot gnu dot org
@ 2004-12-30 7:39 ` lerdsuwa at gcc dot gnu dot org
2005-03-12 15:13 ` lerdsuwa at gcc dot gnu dot org
` (6 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2004-12-30 7:39 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.1.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (9 preceding siblings ...)
2004-12-30 7:39 ` lerdsuwa at gcc dot gnu dot org
@ 2005-03-12 15:13 ` lerdsuwa at gcc dot gnu dot org
2005-03-13 14:18 ` lerdsuwa at gcc dot gnu dot org
` (5 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2005-03-12 15:13 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2005-03-12 15:13 -------
*** Bug 20234 has been marked as a duplicate of this bug. ***
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |20234
nThis| |
CC| |fang at csl dot cornell dot
| |edu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (10 preceding siblings ...)
2005-03-12 15:13 ` lerdsuwa at gcc dot gnu dot org
@ 2005-03-13 14:18 ` lerdsuwa at gcc dot gnu dot org
2005-03-14 14:35 ` cvs-commit at gcc dot gnu dot org
` (4 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2005-03-13 14:18 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2005-03-13 14:18 -------
Patch submitted:
http://gcc.gnu.org/ml/gcc-patches/2005-03/msg01283.html
It's the same as in attachment. I retested it and add
the explanation.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (11 preceding siblings ...)
2005-03-13 14:18 ` lerdsuwa at gcc dot gnu dot org
@ 2005-03-14 14:35 ` cvs-commit at gcc dot gnu dot org
2005-03-14 14:40 ` lerdsuwa at gcc dot gnu dot org
` (3 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-03-14 14:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-03-14 14:34 -------
Subject: Bug 1016
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: lerdsuwa@gcc.gnu.org 2005-03-14 14:33:55
Modified files:
gcc/cp : ChangeLog cp-tree.h decl.c name-lookup.c
name-lookup.h parser.c pt.c rtti.c semantics.c
gcc/testsuite : ChangeLog
Added files:
gcc/testsuite/g++.dg/lookup: hidden-class1.C hidden-class2.C
hidden-class3.C hidden-class4.C
hidden-class5.C hidden-class6.C
hidden-class7.C hidden-class8.C
hidden-class9.C
hidden-temp-class10.C
hidden-temp-class11.C
hidden-temp-class1.C
hidden-temp-class2.C
hidden-temp-class3.C
hidden-temp-class4.C
hidden-temp-class5.C
hidden-temp-class6.C
hidden-temp-class7.C
hidden-temp-class8.C
hidden-temp-class9.C
Log message:
Friend class name lookup 5/n
PR c++/1016
* cp-tree.h (pushtag): Adjust declaration.
* decl.c (lookup_and_check_tag): Call lookup_type_scope if
lookup_name fails.
(xref_tag): Adjust call to pushtag. Make hidden class visible.
(start_enum): Adjust call to pushtag.
* name-lookup.c (ambiguous_decl): Ignore hidden names.
(qualify_lookup): Change return type to bool.
(hidden_name_p): New function.
(lookup_namespace_name, unqualified_namespace_lookup,
lookup_name_real): Use it.
(lookup_type_scope): Update comments.
(maybe_process_template_type_declaration): Change parameter name
from globalize to is_friend.
(pushtag): Change globalize parameter of type int to tag_scope.
Hide name if introduced by friend declaration.
* name-lookup.h (hidden_name_p): Add declaration.
* parser.c (cp_parser_lookup_name): Don't deal with hidden name
here.
* pt.c (push_template_decl_real): Make hidden class template
visible.
(lookup_template_class, instantiate_class_template): Adjust call
to pushtag.
* semantics.c (begin_class_definition): Likewise.
* rtti.c (init_rtti_processing, build_dynamic_cast_1,
tinfo_base_init, emit_support_tinfos): Use ts_current instead of
ts_global.
* g++.dg/lookup/hidden-class1.C: New test.
* g++.dg/lookup/hidden-class2.C: Likewise.
* g++.dg/lookup/hidden-class3.C: Likewise.
* g++.dg/lookup/hidden-class4.C: Likewise.
* g++.dg/lookup/hidden-class5.C: Likewise.
* g++.dg/lookup/hidden-class6.C: Likewise.
* g++.dg/lookup/hidden-class7.C: Likewise.
* g++.dg/lookup/hidden-class8.C: Likewise.
* g++.dg/lookup/hidden-class9.C: Likewise.
* g++.dg/lookup/hidden-temp-class1.C: Likewise.
* g++.dg/lookup/hidden-temp-class2.C: Likewise.
* g++.dg/lookup/hidden-temp-class3.C: Likewise.
* g++.dg/lookup/hidden-temp-class4.C: Likewise.
* g++.dg/lookup/hidden-temp-class5.C: Likewise.
* g++.dg/lookup/hidden-temp-class6.C: Likewise.
* g++.dg/lookup/hidden-temp-class7.C: Likewise.
* g++.dg/lookup/hidden-temp-class8.C: Likewise.
* g++.dg/lookup/hidden-temp-class9.C: Likewise.
* g++.dg/lookup/hidden-temp-class10.C: Likewise.
* g++.dg/lookup/hidden-temp-class11.C: Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4661&r2=1.4662
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/cp-tree.h.diff?cvsroot=gcc&r1=1.1109&r2=1.1110
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl.c.diff?cvsroot=gcc&r1=1.1377&r2=1.1378
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.c.diff?cvsroot=gcc&r1=1.111&r2=1.112
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.h.diff?cvsroot=gcc&r1=1.37&r2=1.38
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.320&r2=1.321
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/pt.c.diff?cvsroot=gcc&r1=1.982&r2=1.983
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/rtti.c.diff?cvsroot=gcc&r1=1.210&r2=1.211
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&r1=1.463&r2=1.464
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5160&r2=1.5161
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class1.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class2.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class3.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class4.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class5.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class6.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class7.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class8.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class9.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class10.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class11.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class1.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class2.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class3.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class4.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class5.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class6.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class7.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class8.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class9.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (12 preceding siblings ...)
2005-03-14 14:35 ` cvs-commit at gcc dot gnu dot org
@ 2005-03-14 14:40 ` lerdsuwa at gcc dot gnu dot org
2005-05-20 17:30 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2005-03-14 14:40 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2005-03-14 14:40 -------
Fixed in the mainline.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (13 preceding siblings ...)
2005-03-14 14:40 ` lerdsuwa at gcc dot gnu dot org
@ 2005-05-20 17:30 ` cvs-commit at gcc dot gnu dot org
2005-05-20 17:42 ` lerdsuwa at gcc dot gnu dot org
2005-07-26 22:11 ` cvs-commit at gcc dot gnu dot org
16 siblings, 0 replies; 17+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-20 17:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-20 17:29 -------
Subject: Bug 1016
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: lerdsuwa@gcc.gnu.org 2005-05-20 17:28:56
Modified files:
gcc/cp : cp-tree.h decl.c name-lookup.c name-lookup.h
parser.c pt.c rtti.c semantics.c ChangeLog
gcc/testsuite : ChangeLog
Added files:
gcc/testsuite/g++.dg/lookup: hidden-class1.C hidden-class2.C
hidden-class3.C hidden-class4.C
hidden-class5.C hidden-class6.C
hidden-class7.C hidden-class8.C
hidden-class9.C
hidden-temp-class10.C
hidden-temp-class11.C
hidden-temp-class1.C
hidden-temp-class2.C
hidden-temp-class3.C
hidden-temp-class4.C
hidden-temp-class5.C
hidden-temp-class6.C
hidden-temp-class7.C
hidden-temp-class8.C
hidden-temp-class9.C
Log message:
Friend class name lookup 5/n
PR c++/1016
* cp-tree.h (pushtag): Adjust declaration.
* decl.c (lookup_and_check_tag): Call lookup_type_scope if
lookup_name fails.
(xref_tag): Adjust call to pushtag. Make hidden class visible.
(start_enum): Adjust call to pushtag.
* name-lookup.c (ambiguous_decl): Ignore hidden names.
(qualify_lookup): Change return type to bool.
(hidden_name_p): New function.
(lookup_namespace_name, unqualified_namespace_lookup,
lookup_name_real): Use it.
(lookup_type_scope): Update comments.
(maybe_process_template_type_declaration): Change parameter name
from globalize to is_friend.
(pushtag): Change globalize parameter of type int to tag_scope.
Hide name if introduced by friend declaration.
* name-lookup.h (hidden_name_p): Add declaration.
* parser.c (cp_parser_lookup_name): Don't deal with hidden name
here.
* pt.c (push_template_decl_real): Make hidden class template
visible.
(lookup_template_class, instantiate_class_template): Adjust call
to pushtag.
* semantics.c (begin_class_definition): Likewise.
* rtti.c (init_rtti_processing, build_dynamic_cast_1,
tinfo_base_init, emit_support_tinfos): Use ts_current instead of
ts_global.
* g++.dg/lookup/hidden-class1.C: New test.
* g++.dg/lookup/hidden-class2.C: Likewise.
* g++.dg/lookup/hidden-class3.C: Likewise.
* g++.dg/lookup/hidden-class4.C: Likewise.
* g++.dg/lookup/hidden-class5.C: Likewise.
* g++.dg/lookup/hidden-class6.C: Likewise.
* g++.dg/lookup/hidden-class7.C: Likewise.
* g++.dg/lookup/hidden-class8.C: Likewise.
* g++.dg/lookup/hidden-class9.C: Likewise.
* g++.dg/lookup/hidden-temp-class1.C: Likewise.
* g++.dg/lookup/hidden-temp-class2.C: Likewise.
* g++.dg/lookup/hidden-temp-class3.C: Likewise.
* g++.dg/lookup/hidden-temp-class4.C: Likewise.
* g++.dg/lookup/hidden-temp-class5.C: Likewise.
* g++.dg/lookup/hidden-temp-class6.C: Likewise.
* g++.dg/lookup/hidden-temp-class7.C: Likewise.
* g++.dg/lookup/hidden-temp-class8.C: Likewise.
* g++.dg/lookup/hidden-temp-class9.C: Likewise.
* g++.dg/lookup/hidden-temp-class10.C: Likewise.
* g++.dg/lookup/hidden-temp-class11.C: Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/cp-tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1106.2.5&r2=1.1106.2.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1371.2.10&r2=1.1371.2.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.109.4.2&r2=1.109.4.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.37&r2=1.37.8.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.319.2.6&r2=1.319.2.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/pt.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.978.2.9&r2=1.978.2.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/rtti.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.210&r2=1.210.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.463.2.2&r2=1.463.2.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4648.2.41&r2=1.4648.2.42
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class1.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class2.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class3.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class4.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class5.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class6.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class7.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class8.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-class9.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class10.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class11.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class1.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class2.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class3.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class4.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class5.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class6.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class7.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class8.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/lookup/hidden-temp-class9.C.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.14.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.189&r2=1.5084.2.190
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (14 preceding siblings ...)
2005-05-20 17:30 ` cvs-commit at gcc dot gnu dot org
@ 2005-05-20 17:42 ` lerdsuwa at gcc dot gnu dot org
2005-07-26 22:11 ` cvs-commit at gcc dot gnu dot org
16 siblings, 0 replies; 17+ messages in thread
From: lerdsuwa at gcc dot gnu dot org @ 2005-05-20 17:42 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From lerdsuwa at gcc dot gnu dot org 2005-05-20 17:42 -------
Also fixed in 4.0.1.
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.1.0 |4.0.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug c++/1016] [DR 166] friend class declarations not observing namespace rules.
[not found] <20001207214600.1016.jaycox@gimp.org>
` (15 preceding siblings ...)
2005-05-20 17:42 ` lerdsuwa at gcc dot gnu dot org
@ 2005-07-26 22:11 ` cvs-commit at gcc dot gnu dot org
16 siblings, 0 replies; 17+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-07-26 22:11 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-07-26 22:10 -------
Subject: Bug 1016
CVSROOT: /cvs/gcc
Module name: gcc
Branch: apple-local-200502-branch
Changes by: dpatel@gcc.gnu.org 2005-07-26 22:10:16
Modified files:
gcc/cp : ChangeLog.apple-ppc cp-tree.h decl.c
name-lookup.c name-lookup.h parser.c pt.c
rtti.c semantics.c
Log message:
Radar 4184203
Undo PR c++/1016 patch.
2005-03-13 Kriang Lerdsuwanakij <lerdsuwa@users.sourceforge.net>
* cp-tree.h (pushtag): Adjust declaration.
* decl.c (lookup_and_check_tag): Call lookup_type_scope if
lookup_name fails.
(xref_tag): Adjust call to pushtag. Make hidden class visible.
(start_enum): Adjust call to pushtag.
* name-lookup.c (ambiguous_decl): Ignore hidden names.
(qualify_lookup): Change return type to bool.
(hidden_name_p): New function.
(lookup_namespace_name, unqualified_namespace_lookup,
lookup_name_real): Use it.
(lookup_type_scope): Update comments.
(maybe_process_template_type_declaration): Change parameter name
from globalize to is_friend.
(pushtag): Change globalize parameter of type int to tag_scope.
Hide name if introduced by friend declaration.
* name-lookup.h (hidden_name_p): Add declaration.
* parser.c (cp_parser_lookup_name): Don't deal with hidden name
here.
* pt.c (push_template_decl_real): Make hidden class template
visible.
(lookup_template_class, instantiate_class_template): Adjust call
to pushtag.
* semantics.c (begin_class_definition): Likewise.
* rtti.c (init_rtti_processing, build_dynamic_cast_1,
tinfo_base_init, emit_support_tinfos): Use ts_current instead of
ts_global.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.apple-ppc.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.1.4.15&r2=1.1.4.16
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/cp-tree.h.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.1104.2.7&r2=1.1104.2.8
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.1364.2.7&r2=1.1364.2.8
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.109.2.3&r2=1.109.2.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/name-lookup.h.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.37.6.1&r2=1.37.6.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.316.2.12&r2=1.316.2.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/pt.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.977.2.7&r2=1.977.2.8
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/rtti.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.210.4.1&r2=1.210.4.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.460.4.9&r2=1.460.4.10
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=1016
^ permalink raw reply [flat|nested] 17+ messages in thread