[Bug preprocessor/20907] New: long comments throw off line numbers

[Bug preprocessor/20907] New: long comments throw off line numbers

[dpatel at apple dot com]

It seems that long comment blocks can throw off gcc's notion of the source line number. Here is a 
sample test case (also attached in case the line breaks get messed up pasting in):
/*
This is a really long comment. This is a really long comment. This is a really long comment. This is a 
really long comment. This is a really long comment. This is a really long comment. This is a really long 
comment. This is a really long comment. This is a really long comment. This is a really long comment. 
This is a really long comment. This is a really long comment. This is a really long comment. This is a 
really long comment. This is a really long comment. This is a really long comment.
 */
#warning test warning
#include <stdio.h>

int main(int argc, char *argv)
{
        printf("This is line %d\n", __LINE__);
}

-- 
           Summary: long comments throw off line numbers
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dpatel at apple dot com
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-08 20:30 -------
Confirmed.
This has been broken since at least "gcc version 3.5.0 20040909 (experimental)".

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |diagnostic
      Known to fail|                            |4.0.0 4.1.0
      Known to work|                            |3.4.0
   Last reconfirmed|0000-00-00 00:00:00         |2005-04-08 20:30:31
               date|                            |
            Summary|long comments throw off line|[4.0/4.1 Regression] long
                   |numbers                     |comments throw off line
                   |                            |numbers
   Target Milestone|---                         |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-08 20:34 -------
This broke between 20040201 and 20040301.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-08 20:36 -------
There were quiet a number of cpp patches during that time.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[bothner at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |bothner at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-04-08 20:30:31         |2005-04-19 21:30:11
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-21 17:09 -------
Subject: Bug 20907

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bothner@gcc.gnu.org	2005-04-21 17:08:29

Modified files:
	libcpp         : line-map.c ChangeLog 

Log message:
	PR preprocessor/20907
	* line-map.c (linemap_line_start): Fix bug when we need to increse
	column_bits but can re-use the current line_map.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/line-map.c.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&r1=1.67&r2=1.68



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[bothner at gcc dot gnu dot org]

------- Additional Comments From bothner at gcc dot gnu dot org  2005-04-21 17:21 -------
Patch checked into mainline; not yet into 4.0 branch.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[dpatel at apple dot com]

------- Additional Comments From dpatel at apple dot com  2005-04-21 17:26 -------
Subject: Re:  [4.0/4.1 Regression] long comments throw off line numbers

Would it be possible for you to add one test case also ?
Thanks,
-
Devang



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0/4.1 Regression] long comments throw off line numbers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-21 18:40 -------
Subject: Bug 20907

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	apple-local-200502-branch
Changes by:	dpatel@gcc.gnu.org	2005-04-21 18:40:08

Modified files:
	libcpp         : line-map.c ChangeLog.apple-ppc 
	gcc/testsuite  : ChangeLog.apple-ppc 
Added files:
	gcc/testsuite/gcc.apple: very-long-comment.c 

Log message:
	Radar 4058553
	Backport from FSF Mainline.
	2005-04-19  Per Bothner  <per@bothner.com>
	
	PR preprocessor/20907
	* line-map.c (linemap_line_start): Fix bug when we need to increse
	column_bits but can re-use the current line_map.
	
	* gcc.apple/very-long-comment.c: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/line-map.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.1&r2=1.1.52.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.apple-ppc.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.1.4.4&r2=1.1.4.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.apple/very-long-comment.c.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.apple-ppc.diff?cvsroot=gcc&only_with_tag=apple-local-200502-branch&r1=1.1.4.22&r2=1.1.4.23



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0 Regression] long comments throw off line numbers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-24 20:05 -------
Subject: Bug 20907

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bothner@gcc.gnu.org	2005-04-24 20:05:30

Modified files:
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg/cpp: very-long-comment.c 

Log message:
	PR preprocessor/20907
	* gcc.dg/cpp/very-long-comment.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/very-long-comment.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5390&r2=1.5391



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0 Regression] long comments throw off line numbers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-24 20:32 -------
Subject: Bug 20907

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	bothner@gcc.gnu.org	2005-04-24 20:32:32

Modified files:
	libcpp         : line-map.c ChangeLog 

Log message:
	PR preprocessor/20907
	* line-map.c (linemap_line_start): Fix bug when we need to increse
	column_bits but can re-use the current line_map.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/line-map.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.1&r2=1.1.54.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.56.2.5&r2=1.56.2.6



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0 Regression] long comments throw off line numbers

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-24 20:37 -------
Subject: Bug 20907

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	bothner@gcc.gnu.org	2005-04-24 20:37:39

Modified files:
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg/cpp: very-long-comment.c 

Log message:
	PR preprocessor/20907
	* gcc.dg/cpp/very-long-comment.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/very-long-comment.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.136&r2=1.5084.2.137



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907

[Bug preprocessor/20907] [4.0 Regression] long comments throw off line numbers

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-24 20:43 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20907