public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "roger at eyesopen dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/20126] [3.3/3.4/4.0/4.1 Regression] Inlined memcmp makes one argument null on entry Date: Sun, 10 Apr 2005 03:18:00 -0000 [thread overview] Message-ID: <20050410031841.20684.qmail@sourceware.org> (raw) In-Reply-To: <20050221214433.20126.jkohen@users.sourceforge.net> ------- Additional Comments From roger at eyesopen dot com 2005-04-10 03:18 ------- Subject: Re: [PR target/20126, RFC] loop DEST_ADDR biv replacement may fail On 9 Apr 2005, Alexandre Oliva wrote: > On Apr 8, 2005, Roger Sayle <roger@eyesopen.com> wrote: > > > ++ /* If there isn't a volatile MEM, there's nothing we can do. */ > > ++ || !for_each_rtx (&object, volatile_mem_p, 0) > > This actually caused crashes. We don't want to scan the entire insn > (it might contain NULLs), only the insn pattern. Argh! Indeed, my mistake/oversight. Thanks. > PR target/20126 > * loop.c (loop_givs_rescan): If replacement of DEST_ADDR failed, > set the original address pseudo to the correct value before the > original insn, if possible, and leave the insn alone, otherwise > create a new pseudo, set it and replace it in the insn. > * recog.c (validate_change_maybe_volatile): New. > * recog.h (validate_change_maybe_volatile): Declare. This is OK for mainline, thanks. Now that 4.0 is frozen for release candidate one, Mark needs to decide whether this patch can make it into 4.0.0 or will have to wait for 4.0.1. I also think we should wait for that decision before considering a backport for 3.4.x (or we'll have a strange temporal regression). I'd recommend commiting this patch to mainline ASAP, so it can have a few days of testing before Mark has to make his decision. Thanks again for your patience, Roger -- -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20126
next prev parent reply other threads:[~2005-04-10 3:18 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2005-02-22 1:42 [Bug c/20126] New: " jkohen at users dot sourceforge dot net 2005-02-22 1:44 ` [Bug c/20126] " jkohen at users dot sourceforge dot net 2005-02-22 1:47 ` [Bug target/20126] " pinskia at gcc dot gnu dot org 2005-02-22 1:49 ` jkohen at users dot sourceforge dot net 2005-02-22 1:50 ` pinskia at gcc dot gnu dot org 2005-02-22 1:51 ` pinskia at gcc dot gnu dot org 2005-02-22 2:22 ` [Bug target/20126] [3.3/3.4/4.0 Regression] " pinskia at gcc dot gnu dot org 2005-02-22 15:55 ` jakub at gcc dot gnu dot org 2005-02-22 17:03 ` jakub at gcc dot gnu dot org 2005-03-03 7:04 ` [Bug target/20126] [3.3/3.4/4.0/4.1 " aoliva at gcc dot gnu dot org 2005-03-03 7:07 ` aoliva at gcc dot gnu dot org 2005-03-07 21:57 ` aoliva at redhat dot com 2005-03-07 22:15 ` aoliva at gcc dot gnu dot org 2005-03-09 1:47 ` jakub at redhat dot com 2005-03-09 4:02 ` aoliva at redhat dot com 2005-03-09 8:51 ` jakub at redhat dot com 2005-03-09 9:24 ` jakub at redhat dot com 2005-03-10 11:45 ` aoliva at redhat dot com 2005-03-11 14:30 ` aoliva at redhat dot com 2005-04-02 17:22 ` aoliva at redhat dot com 2005-04-05 4:22 ` roger at eyesopen dot com 2005-04-08 16:34 ` aoliva at redhat dot com 2005-04-08 17:03 ` roger at eyesopen dot com 2005-04-08 20:51 ` aoliva at redhat dot com 2005-04-10 2:43 ` aoliva at redhat dot com 2005-04-10 3:18 ` roger at eyesopen dot com [this message] 2005-04-10 4:01 ` cvs-commit at gcc dot gnu dot org 2005-04-10 18:44 ` mark at codesourcery dot com 2005-04-10 21:00 ` [Bug target/20126] [3.3/3.4/4.0 " pinskia at gcc dot gnu dot org 2005-04-11 3:51 ` aoliva at redhat dot com 2005-04-11 21:11 ` jconner at apple dot com 2005-04-12 3:36 ` aoliva at redhat dot com 2005-04-12 6:59 ` aoliva at redhat dot com 2005-04-12 8:19 ` aoliva at redhat dot com 2005-04-12 14:39 ` roger at eyesopen dot com 2005-04-12 17:55 ` mmitchel at gcc dot gnu dot org 2005-04-13 9:47 ` jakub at redhat dot com 2005-04-13 10:10 ` bernds_cb1 at t-online dot de 2005-04-13 11:39 ` jakub at redhat dot com 2005-04-13 21:01 ` joseph at codesourcery dot com 2005-04-14 6:03 ` mark at codesourcery dot com 2005-04-14 6:14 ` cvs-commit at gcc dot gnu dot org 2005-04-14 17:21 ` aoliva at redhat dot com 2005-04-14 17:38 ` roger at eyesopen dot com 2005-04-15 3:31 ` aoliva at redhat dot com 2005-04-15 14:52 ` roger at eyesopen dot com 2005-04-16 17:50 ` rearnsha at gcc dot gnu dot org 2005-04-16 21:42 ` cvs-commit at gcc dot gnu dot org 2005-04-16 21:49 ` aoliva at redhat dot com 2005-04-16 21:58 ` aoliva at redhat dot com 2005-04-17 0:22 ` roger at eyesopen dot com 2005-04-17 2:38 ` aoliva at redhat dot com 2005-04-17 2:46 ` mmitchel at gcc dot gnu dot org 2005-04-17 3:06 ` roger at eyesopen dot com 2005-05-19 17:28 ` [Bug target/20126] [3.3/3.4 " mmitchel at gcc dot gnu dot org 2005-07-07 19:20 ` [Bug target/20126] [3.4 " uweigand at gcc dot gnu dot org 2005-07-08 12:25 ` aoliva at gcc dot gnu dot org 2005-07-08 15:48 ` uweigand at gcc dot gnu dot org 2005-07-11 3:56 ` cvs-commit at gcc dot gnu dot org 2005-07-12 4:11 ` belyshev at depni dot sinp dot msu dot ru 2005-07-13 22:30 ` uweigand at gcc dot gnu dot org 2005-07-14 18:48 ` aoliva at gcc dot gnu dot org 2005-07-14 21:17 ` cvs-commit at gcc dot gnu dot org 2005-08-04 23:12 ` belyshev at depni dot sinp dot msu dot ru
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20050410031841.20684.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).