public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "steven at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/20928] [4.0/4.1 regression] ICE: unrecognizable insns
Date: Sun, 10 Apr 2005 21:05:00 -0000 [thread overview]
Message-ID: <20050410210540.14994.qmail@sourceware.org> (raw)
In-Reply-To: <20050410150728.20928.aj@gcc.gnu.org>
------- Additional Comments From steven at gcc dot gnu dot org 2005-04-10 21:05 -------
Alexandre Oliva pointed out to me that it was probably the expander who
should produce a proper legitimate insn. I looked at this some more and
found that in legitimize_pic_address we do not check if a displacement
is a valid PIC displacement:
Index: config/i386/i386.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.c,v
retrieving revision 1.807
diff -u -3 -p -r1.807 i386.c
--- config/i386/i386.c 9 Apr 2005 17:19:48 -0000 1.807
+++ config/i386/i386.c 10 Apr 2005 21:01:26 -0000
@@ -5612,7 +5612,13 @@ legitimize_pic_address (rtx orig, rtx re
base == reg ? NULL_RTX : reg);
if (GET_CODE (new) == CONST_INT)
- new = plus_constant (base, INTVAL (new));
+ {
+ if (legitimate_pic_address_disp_p (new))
+ new = plus_constant (base, INTVAL (new));
+ else
+ new = gen_rtx_PLUS (Pmode, base,
+ copy_to_mode_reg (Pmode, new));
+ }
else
{
if (GET_CODE (new) == PLUS && CONSTANT_P (XEXP (new, 1)))
This looks to me like much better hack (maybe even a proper fix!) so I'll
test this to see what happens...
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20928
next prev parent reply other threads:[~2005-04-10 21:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-10 15:07 [Bug target/20928] New: ICE: unrecognoizable insns aj at gcc dot gnu dot org
2005-04-10 15:08 ` [Bug target/20928] ICE: unrecognizable insns aj at gcc dot gnu dot org
2005-04-10 15:08 ` aj at gcc dot gnu dot org
2005-04-10 16:02 ` steven at gcc dot gnu dot org
2005-04-10 16:03 ` [Bug target/20928] [4.0/4.1 regression] " steven at gcc dot gnu dot org
2005-04-10 16:08 ` steven at gcc dot gnu dot org
2005-04-10 17:24 ` steven at gcc dot gnu dot org
2005-04-10 17:39 ` steven at gcc dot gnu dot org
2005-04-10 17:52 ` steven at gcc dot gnu dot org
2005-04-10 19:03 ` steven at gcc dot gnu dot org
2005-04-10 21:05 ` steven at gcc dot gnu dot org [this message]
2005-04-21 5:06 ` mmitchel at gcc dot gnu dot org
2005-05-21 7:00 ` aj at gcc dot gnu dot org
2005-06-08 0:09 ` rth at gcc dot gnu dot org
2005-07-06 17:03 ` mmitchel at gcc dot gnu dot org
2005-09-27 16:24 ` mmitchel at gcc dot gnu dot org
[not found] <bug-20928-260@http.gcc.gnu.org/bugzilla/>
2005-10-10 3:20 ` kazu at gcc dot gnu dot org
2005-10-13 16:03 ` pinskia at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050410210540.14994.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).