[Bug c/21014] New: read-rtl.c:670: warning: missing sentinel in function call

[Bug c/21014] New: read-rtl.c:670: warning: missing sentinel in function call

[danglin at gcc dot gnu dot org]

stage1/xgcc -Bstage1/ -B/usr/local/gcc/gcc-4.1.0/vax-dec-ultrix4.3/bin/ -c   -g 
-O2 -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
 -pedantic -Wno-long-long -Wno-variadic-macros -Wold-style-definition -Werror -f
no-common   -DHAVE_CONFIG_H -DGENERATOR_FILE    -I. -Ibuild -I../../gcc/gcc -I..
/../gcc/gcc/build -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include  
\
 -o build/read-rtl.o ../../gcc/gcc/read-rtl.c
cc1: warnings being treated as errors
../../gcc/gcc/read-rtl.c: In function 'join_c_conditions':
../../gcc/gcc/read-rtl.c:670: warning: missing sentinel in function call
make[2]: *** [build/read-rtl.o] Error 1

The same error occurs with preprocessed source using x86 cross.

-- 
           Summary: read-rtl.c:670: warning: missing sentinel in function
                    call
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: vax-dec-ultrix4.3
  GCC host triplet: vax-dec-ultrix4.3
GCC target triplet: vax-dec-ultrix4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug c/21014] read-rtl.c:670: warning: missing sentinel in function call

[danglin at gcc dot gnu dot org]

------- Additional Comments From danglin at gcc dot gnu dot org  2005-04-14 00:28 -------
Created an attachment (id=8622)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8622&action=view)
Preprocessed source.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-14 00:30 -------
  result = concat ("(", cond1, ") && (", cond2, ")", NULL);


Looks like someone forgot the cast.  (well in most of the time there is a cast, oh well).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|c                           |middle-end
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-04-14 00:30:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2005-04-14 00:46 -------
Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call

>   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> 
> 
> Looks like someone forgot the cast.  (well in most of the time there is a cast, oh well).

Casts definitely postdate vax-ultrix ;-)  Do we always need a cast in
join_c_conditions?

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2005-04-14 00:58 -------
Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call

> >   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> > 
> > 
> > Looks like someone forgot the cast.  (well in most of the time there is a cast, oh well).
> 
> Casts definitely postdate vax-ultrix ;-)  Do we always need a cast in
> join_c_conditions?

Looking at /usr/include/sys/_null.h on HP-UX 11.11, it appears that
we only will get a cast if _ANSI_NULL_POINTER is defined.  Since we
don't define this, I'm not sure why this problem doesn't also occur
under HP-UX.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014

[Bug middle-end/21014] read-rtl.c:670: warning: missing sentinel in function call

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2005-04-15 22:10 -------
Subject: Re:  read-rtl.c:670: warning: missing sentinel in function call

>   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
> 
> 
> Looks like someone forgot the cast.  (well in most of the time there is a cast, oh well).

It looks like this could be fixed by including stddef.h after stdio.h
in system.h.  stddef.h would then provide an appropriate define for NULL.
Otherwise, stdio.h needs fixing.  The define for NULL in system.h is
also probably inadequate if it's ever needed.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21014