[Bug ada/21053] New: Warnings from init.c

[Bug ada/21053] New: Warnings from init.c

[danglin at gcc dot gnu dot org]

stage1/xgcc -Bstage1/ -B/opt/gnu/gcc/gcc-4.1.0/hppa2.0w-hp-hpux11.11/bin/ -c   -
g -O2 -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototyp
es -mdisable-indexing   -Werror -fno-common   -DHAVE_CONFIG_H -mdisable-indexing
    \
            -I. -Iada -I../../gcc/gcc -I../../gcc/gcc/ada -I../../gcc/gcc/../inc
lude -I../../gcc/gcc/../libcpp/include -I/opt/gnu/include  ../../gcc/gcc/ada/ini
t.c -o ada/init.o
cc1: warnings being treated as errors
../../gcc/gcc/ada/init.c: In function '__gnat_error_handler':
../../gcc/gcc/ada/init.c:613: warning: assignment discards qualifiers from point
er target type
../../gcc/gcc/ada/init.c:618: warning: assignment discards qualifiers from point
er target type
../../gcc/gcc/ada/init.c:623: warning: assignment discards qualifiers from point
er target type
../../gcc/gcc/ada/init.c:628: warning: assignment discards qualifiers from point
er target type
../../gcc/gcc/ada/init.c:603: warning: unused parameter 'siginfo'
make[2]: *** [ada/init.o] Error 1
make[2]: Leaving directory `/test/gnu/gcc-3.3/objdir/gcc'

-- 
           Summary: Warnings from init.c
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.11
  GCC host triplet: hppa2.0w-hp-hpux11.11
GCC target triplet: hppa2.0w-hp-hpux11.11


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053

[Bug ada/21053] Warnings from init.c

[laurent at guerby dot net]

------- Additional Comments From laurent at guerby dot net  2005-04-16 07:38 -------
Could you try the obvious patch below?
It looks like the same problem as  PR ada/17527
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17527
which was fixed the same way a while ago.

I believe you can commit as obvious once tested.

There are other occurence of the same code for other target, but I don't have
access to them, may be Arnaud?

Index: init.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/ada/init.c,v
retrieving revision 1.47
diff -u -r1.47 init.c
--- init.c      10 Apr 2005 17:38:53 -0000      1.47
+++ init.c      16 Apr 2005 07:34:39 -0000
@@ -603,7 +603,7 @@
 __gnat_error_handler (int sig, siginfo_t *siginfo, void *ucontext)
 {
   struct Exception_Data *exception;
-  char *msg;
+  const char *msg;

   switch (sig)
     {


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charlet at adacore dot com
           Keywords|                            |build, patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053

[Bug ada/21053] Warnings from init.c

[charlet at adacore dot com]

------- Additional Comments From charlet at adacore dot com  2005-04-17 08:13 -------
Subject: Re:  Warnings from init.c

> I believe you can commit as obvious once tested.

Right.

> There are other occurence of the same code for other target, but I don't have
> access to them, may be Arnaud?

I don't have a gcc head set up except under x86-linux

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053

[Bug ada/21053] Warnings from init.c

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-16 01:16 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-16 01:16:30
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053

[Bug ada/21053] Warnings from init.c

[charlet at gcc dot gnu dot org]

------- Additional Comments From charlet at gcc dot gnu dot org  2005-08-29 12:34 -------
I can't really test on a hppa configuration, but the change is trivial and
obviousely correct anyway, so I'll incorporate it soon.

Arno

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|charlet at adacore dot com  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053

[Bug ada/21053] Warnings from init.c

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-08-29 15:41 -------
Subject: Bug 21053

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	charlet@gcc.gnu.org	2005-08-29 15:41:45

Modified files:
	gcc/ada        : s-stalib.adb decl.c fe.h init.c 

Log message:
	2005-08-29  Arnaud Charlet  <charlet@adacore.com>
	Doug Rupp  <rupp@adacore.com>
	
	* s-stalib.adb: Add missing pragma Warnings (On) to reenable Warnings
	when needed.
	(Inside_Elab_Final_Code): Moved to init.c to avoid having to keep
	this code in the GNAT run-time.
	
	* decl.c, fe.h: Replace GCC_ZCX by Back_End_Exceptions.
	
	PR ada/21053
	* init.c (__gnat_error_handler [many]): Mark "msg" as const
	(__gnat_error_handler [HPUX]): Mark siginfo parameter as unused
	
	(__gnat_inside_elab_final_code): Moved here from
	Standard_Library and only defined for the compiler.
	__gnat_error_handler [VMS]: Adjust sigargs to account for PC & PSL.
	(__gnat_inum_to_ivec): Do not define this function on VxWorks when
	using RTPs because directly vectored Interrupt routines are not
	supported on this configuration.
	(getpid): Do not redefine this function on VxWorks when using RTPs
	because this primitive is well supported by the RTP libraries.
	(copy_msg): Correct the code that checks for buffer overflow.
	Discovered during code reading.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ada/s-stalib.adb.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ada/decl.c.diff?cvsroot=gcc&r1=1.79&r2=1.80
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ada/fe.h.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ada/init.c.diff?cvsroot=gcc&r1=1.52&r2=1.53



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053

[Bug ada/21053] Warnings from init.c

[charlet at gcc dot gnu dot org]

------- Additional Comments From charlet at gcc dot gnu dot org  2005-08-29 15:48 -------
Should be fixed now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21053