[Bug c++/17964] New: cpp error messages contain wrong line in C++

[Bug c++/17964] New: cpp error messages contain wrong line in C++

[mrs at apple dot com]

The below testcase recently broke for C++.

char *p = "\q"; /* { dg-error "unknown escape" } */
int i;

The problem is the line numbers for cpp_error 
come out as the last line number in the source file.
we currently see:

t.cc:2:1: warning: unknown escape sequence '\q'

instead of:

t.cc:1:11: warning: unknown escape sequence '\q'

(which is what we see in C).

-- 
           Summary: cpp error messages contain wrong line in C++
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P1
         Component: c++
        AssignedTo: zack at codesourcery dot com
        ReportedBy: mrs at apple dot com
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: powerpc-apple-darwin7.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-13 00:56 -------
Confirmed, a regression.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |diagnostic
      Known to fail|                            |4.0.0
      Known to work|                            |3.3.3
   Last reconfirmed|0000-00-00 00:00:00         |2004-10-13 00:56:10
               date|                            |
            Summary|cpp error messages contain  |[4.0 Regression] cpp error
                   |wrong line in C++           |messages contain wrong line
                   |                            |in C++
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0 Regression] cpp error messages contain wrong line in C++

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-10-13 01:43 -------
This seems to have been broken by a patch for which Zack assumed 
responsibility here: 
  http://gcc.gnu.org/ml/gcc/2004-10/msg00464.html 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0 Regression] cpp error messages contain wrong line in C++

[zack at codesourcery dot com]

------- Additional Comments From zack at codesourcery dot com  2005-02-09 02:28 -------
I am testing a patch for this bug now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-01-11 13:34:31         |2005-02-09 02:28:52
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-05 02:14 -------
Unassigning from Zack since he is now gone from GCC development.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|zack at codesourcery dot com|unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.1                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.2                       |4.0.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

------- Comment #15 from pinskia at gcc dot gnu dot org  2005-11-04 04:50 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[jsm28 at gcc dot gnu dot org]

------- Comment #14 from jsm28 at gcc dot gnu dot org  2005-11-04 01:23 -------
Subject: Bug 17964

Author: jsm28
Date: Fri Nov  4 01:23:54 2005
New Revision: 106469

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106469
Log:
gcc:
        PR c++/17964
        * diagnostic.c (diagnostic_set_info_translated): New function.
        (diagnostic_set_info): Use it.  Add comment.
        * diagnostic.h (diagnostic_set_info_translated): Declare.

gcc/cp:
        * error.c (cp_cpp_error): New function.
        * cp-tree.h (cp_cpp_error): Declare.
        * parser.c (cp_lexer_new_main): Set CPP option client_diagnostic
        and error callback after lexing.

gcc/testsuite:
        * g++.dg/cpp/string-1.C: New test.

libcpp:
        * include/cpplib.h (struct cpp_options): Add client_diagnostic.
        (struct cpp_callbacks): Add error.
        * errors.c (cpp_error): If client_diagnostic, use error callback.
        * charset.c (convert_escape): Don't use %03o in diagnostic.

Added:
    branches/gcc-4_0-branch/gcc/testsuite/g++.dg/cpp/string-1.C
      - copied unchanged from r106454,
trunk/gcc/testsuite/g++.dg/cpp/string-1.C
Modified:
    branches/gcc-4_0-branch/gcc/ChangeLog
    branches/gcc-4_0-branch/gcc/cp/ChangeLog
    branches/gcc-4_0-branch/gcc/cp/cp-tree.h
    branches/gcc-4_0-branch/gcc/cp/error.c
    branches/gcc-4_0-branch/gcc/cp/parser.c
    branches/gcc-4_0-branch/gcc/diagnostic.c
    branches/gcc-4_0-branch/gcc/diagnostic.h
    branches/gcc-4_0-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_0-branch/libcpp/ChangeLog
    branches/gcc-4_0-branch/libcpp/charset.c
    branches/gcc-4_0-branch/libcpp/errors.c
    branches/gcc-4_0-branch/libcpp/include/cpplib.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[jsm28 at gcc dot gnu dot org]

------- Comment #13 from jsm28 at gcc dot gnu dot org  2005-11-03 23:08 -------
Subject: Bug 17964

Author: jsm28
Date: Thu Nov  3 23:08:18 2005
New Revision: 106454

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=106454
Log:
gcc:
        PR c++/17964
        * diagnostic.c (diagnostic_set_info_translated): New function.
        (diagnostic_set_info): Use it.  Add comment.
        * diagnostic.h (diagnostic_set_info_translated): Declare.

gcc/cp:
        * error.c (cp_cpp_error): New function.
        * cp-tree.h (cp_cpp_error): Declare.
        * parser.c (cp_lexer_new_main): Set CPP option client_diagnostic
        and error callback after lexing.

gcc/testsuite:
        * g++.dg/cpp/string-1.C: New test.

libcpp:
        * include/cpplib.h (struct cpp_options): Add client_diagnostic.
        (struct cpp_callbacks): Add error.
        * errors.c (cpp_error): If client_diagnostic, use error callback.
        * charset.c (convert_escape): Don't use %03o in diagnostic.

Added:
    trunk/gcc/testsuite/g++.dg/cpp/string-1.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/error.c
    trunk/gcc/cp/parser.c
    trunk/gcc/diagnostic.c
    trunk/gcc/diagnostic.h
    trunk/gcc/testsuite/ChangeLog
    trunk/libcpp/ChangeLog
    trunk/libcpp/charset.c
    trunk/libcpp/errors.c
    trunk/libcpp/include/cpplib.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[mmitchel at gcc dot gnu dot org]

------- Comment #12 from mmitchel at gcc dot gnu dot org  2005-11-03 07:01 -------
I approved the patch, subject to there being no objections from the cpplib or
diagnostic maintainers.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2005-11-03 00:30 -------
Patch posted:
http://gcc.gnu.org/ml/gcc-patches/2005-11/msg00092.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |11/msg00092.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[mrs at apple dot com]

------- Comment #10 from mrs at apple dot com  2005-11-02 21:04 -------
Radar 3843157


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[jsm28 at gcc dot gnu dot org]

------- Comment #9 from jsm28 at gcc dot gnu dot org  2005-11-01 20:03 -------
Working on a fix.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jsm28 at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2005-10-13 20:57:39         |2005-11-01 20:03:12
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[joseph at codesourcery dot com]

------- Comment #8 from joseph at codesourcery dot com  2005-10-31 01:16 -------
Subject: Re:  [4.0/4.1 Regression] cpp error messages contain
 wrong line in C++

On Mon, 31 Oct 2005, mmitchel at gcc dot gnu dot org wrote:

> Overall, the Weinberg/Austern patch to improve compilation speed by reading in
> all the tokens upfront has indeed caused several diagnostic issues, all
> relating to the fact that we rely on cpplib to tell us about our current
> location, and that's no longer possible.  We need to explore whether there's a
> good way to recover that information, having pre-scanned the file.

 ... and without causing other problems with diagnostic location such as 
diagnostics appearing where NULL is defined instead of where it is used.  
Zack's patch which ran into that issue (mentioned in comment#3) is 
<http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00394.html>.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[mmitchel at gcc dot gnu dot org]

------- Comment #7 from mmitchel at gcc dot gnu dot org  2005-10-31 00:40 -------
Leaving as P2; indeed, this is something we should fix.

Overall, the Weinberg/Austern patch to improve compilation speed by reading in
all the tokens upfront has indeed caused several diagnostic issues, all
relating to the fact that we rely on cpplib to tell us about our current
location, and that's no longer possible.  We need to explore whether there's a
good way to recover that information, having pre-scanned the file.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2005-10-27 20:34 -------
(In reply to comment #5)
> It gets worse if the unknown escape is at the beginning of the file and then
> you have about 100 more lines.

Or even in a different file.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964

[Bug c++/17964] [4.0/4.1 Regression] cpp error messages contain wrong line in C++

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-10-13 20:57 -------
It gets worse if the unknown escape is at the beginning of the file and then
you have about 100 more lines.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2005-09-10 02:28:42         |2005-10-13 20:57:39
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17964