public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/20914] New: Another grouping trouble
@ 2005-04-09 7:47 pcarlini at suse dot de
2005-04-09 7:47 ` [Bug libstdc++/20914] " pcarlini at suse dot de
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: pcarlini at suse dot de @ 2005-04-09 7:47 UTC (permalink / raw)
To: gcc-bugs
Unfortunately, we have got another *long* standing issue, which affects both
integers and floats: when grouping, we should not involve an initial sign. For
instance, -200000, in "de_DE" gets grouped as -.200.000 and the initial '.' on
the left is completely bogus.
--
Summary: Another grouping trouble
Product: gcc
Version: 4.0.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libstdc++
AssignedTo: pcarlini at suse dot de
ReportedBy: pcarlini at suse dot de
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20914
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/20914] Another grouping trouble
2005-04-09 7:47 [Bug libstdc++/20914] New: Another grouping trouble pcarlini at suse dot de
@ 2005-04-09 7:47 ` pcarlini at suse dot de
2005-04-09 8:41 ` pcarlini at suse dot de
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pcarlini at suse dot de @ 2005-04-09 7:47 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-04-09 07:47:22
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20914
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/20914] Another grouping trouble
2005-04-09 7:47 [Bug libstdc++/20914] New: Another grouping trouble pcarlini at suse dot de
2005-04-09 7:47 ` [Bug libstdc++/20914] " pcarlini at suse dot de
@ 2005-04-09 8:41 ` pcarlini at suse dot de
2005-04-17 14:30 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: pcarlini at suse dot de @ 2005-04-09 8:41 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20914
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/20914] Another grouping trouble
2005-04-09 7:47 [Bug libstdc++/20914] New: Another grouping trouble pcarlini at suse dot de
2005-04-09 7:47 ` [Bug libstdc++/20914] " pcarlini at suse dot de
2005-04-09 8:41 ` pcarlini at suse dot de
@ 2005-04-17 14:30 ` cvs-commit at gcc dot gnu dot org
2005-04-25 9:35 ` pcarlini at suse dot de
2005-04-25 9:35 ` cvs-commit at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-04-17 14:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-04-17 14:30 -------
Subject: Bug 20914
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: paolo@gcc.gnu.org 2005-04-17 14:30:37
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: locale_facets.tcc
Added files:
libstdc++-v3/testsuite/22_locale/num_put/put/char: 20914.cc
libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t: 20914.cc
Log message:
2005-04-17 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/20914
* include/bits/locale_facets.tcc (__int_to_char(_CharT*, _ValueT,
const _CharT*, ios_base::fmtflags, bool)): Don't deal with numeric
base or sign here, instead...
(_M_insert_int(_OutIter, ios_base&, _CharT, _ValueT)): ... here,
after adding the grouping. This fixes the bug and also allows to
clean-up the code dealing with integer types.
(_M_group_int(const char*, size_t, _CharT, ios_base&, _CharT*,
_CharT*, int&)): Simplify, remove bits dealing with numeric base.
(__int_to_char(_CharT*, unsigned long, const _CharT*,
ios_base::fmtflags), __int_to_char(_CharT*, unsigned long long,
const _CharT*, ios_base::fmtflags)): Remove hackish fix for
libstdc++/15565.
(__int_to_char(_CharT*, long, const _CharT*, ios_base::fmtflags),
__int_to_char(_CharT*, long long, const _CharT*, ios_base::fmtflags)):
Simplify, don't pass the sign.
(_M_insert_float(_OutIter, ios_base&, _CharT, char, _ValueT)):
Deal with a sign at the beginning of __cs; robustify the grouping
check.
* testsuite/22_locale/num_put/put/char/20914.cc: New.
* testsuite/22_locale/num_put/put/wchar_t/20914.cc: Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2973&r2=1.2974
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&r1=1.212&r2=1.213
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/char/20914.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/20914.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20914
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/20914] Another grouping trouble
2005-04-09 7:47 [Bug libstdc++/20914] New: Another grouping trouble pcarlini at suse dot de
` (2 preceding siblings ...)
2005-04-17 14:30 ` cvs-commit at gcc dot gnu dot org
@ 2005-04-25 9:35 ` pcarlini at suse dot de
2005-04-25 9:35 ` cvs-commit at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: pcarlini at suse dot de @ 2005-04-25 9:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2005-04-25 09:35 -------
Fixed for 4.0.1.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20914
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/20914] Another grouping trouble
2005-04-09 7:47 [Bug libstdc++/20914] New: Another grouping trouble pcarlini at suse dot de
` (3 preceding siblings ...)
2005-04-25 9:35 ` pcarlini at suse dot de
@ 2005-04-25 9:35 ` cvs-commit at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-04-25 9:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-04-25 09:34 -------
Subject: Bug 20914
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: paolo@gcc.gnu.org 2005-04-25 09:33:41
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: locale_facets.tcc stl_tree.h
Added files:
libstdc++-v3/testsuite/22_locale/num_put/put/char: 20914.cc
libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t: 20914.cc
Log message:
2005-04-25 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/20914
* include/bits/locale_facets.tcc (__int_to_char(_CharT*, _ValueT,
const _CharT*, ios_base::fmtflags, bool)): Don't deal with numeric
base or sign here, instead...
(_M_insert_int(_OutIter, ios_base&, _CharT, _ValueT)): ... here,
after adding the grouping. This fixes the bug and also allows to
clean-up the code dealing with integer types.
(_M_group_int(const char*, size_t, _CharT, ios_base&, _CharT*,
_CharT*, int&)): Simplify, remove bits dealing with numeric base.
(__int_to_char(_CharT*, unsigned long, const _CharT*,
ios_base::fmtflags), __int_to_char(_CharT*, unsigned long long,
const _CharT*, ios_base::fmtflags)): Remove hackish fix for
libstdc++/15565.
(__int_to_char(_CharT*, long, const _CharT*, ios_base::fmtflags),
__int_to_char(_CharT*, long long, const _CharT*, ios_base::fmtflags)):
Simplify, don't pass the sign.
(_M_insert_float(_OutIter, ios_base&, _CharT, char, _ValueT)):
Deal with a sign at the beginning of __cs; robustify the grouping
check.
* testsuite/22_locale/num_put/put/char/20914.cc: New.
* testsuite/22_locale/num_put/put/wchar_t/20914.cc: Likewise.
2005-04-25 Earl Chew <earl_chew@agilent.com>
Christopher Jefferson <chris@bubblescope.net>
* include/bits/stl_tree.h (_Rb_tree<>::_M_insert): Don't leak
memory if _M_key_compare throws.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.2917.2.27&r2=1.2917.2.28
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.211.12.1&r2=1.211.12.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.44&r2=1.44.6.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/char/20914.cc.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.4.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/20914.cc.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.4.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20914
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-04-25 9:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-09 7:47 [Bug libstdc++/20914] New: Another grouping trouble pcarlini at suse dot de
2005-04-09 7:47 ` [Bug libstdc++/20914] " pcarlini at suse dot de
2005-04-09 8:41 ` pcarlini at suse dot de
2005-04-17 14:30 ` cvs-commit at gcc dot gnu dot org
2005-04-25 9:35 ` pcarlini at suse dot de
2005-04-25 9:35 ` cvs-commit at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).