public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/21433] New: The COMPONENT_REF case of expand_expr_real_1 is probably wrong
@ 2005-05-07 3:31 kazu at cs dot umass dot edu
2005-05-07 15:52 ` [Bug middle-end/21433] " pinskia at gcc dot gnu dot org
0 siblings, 1 reply; 7+ messages in thread
From: kazu at cs dot umass dot edu @ 2005-05-07 3:31 UTC (permalink / raw)
To: gcc-bugs
We have the following coverage for the COMPONENT_REF case.
-: 6997: case COMPONENT_REF:
-: 6998: /* If the operand is a CONSTRUCTOR, we can just extract the
-: 6999: appropriate field if it is present. */
75549: 7000: if (TREE_CODE (TREE_OPERAND (exp, 0)) == CONSTRUCTOR)
-: 7001: {
-: 7002: tree elt;
-: 7003:
#####: 7004: for (elt = CONSTRUCTOR_ELTS (TREE_OPERAND (exp, 0)); elt;
#####: 7005: elt = TREE_CHAIN (elt))
I don't think we should expect a CONSTRUCTOR as the first operand
of EXP. If TREE_OPERAND (exp, 0) is VAR_DECL, then we can expect
CONSTRUCTOR in DECL_INITIAL (TREE_OPERAND (exp, 0)).
--
Summary: The COMPONENT_REF case of expand_expr_real_1 is probably
wrong
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: middle-end
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: kazu at cs dot umass dot edu
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/21433] The COMPONENT_REF case of expand_expr_real_1 is probably wrong
2005-05-07 3:31 [Bug middle-end/21433] New: The COMPONENT_REF case of expand_expr_real_1 is probably wrong kazu at cs dot umass dot edu
@ 2005-05-07 15:52 ` pinskia at gcc dot gnu dot org
0 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-05-07 15:52 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2005-05-07 15:52 -------
(In reply to comment #0)
> We have the following coverage for the COMPONENT_REF case.
Actually I think at one point this was valid to do but that was before gimple and generic and tree-ssa.
I think the code is just dead now.
In fact this code dates before the EGCS split.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2005-05-07 15:52:26
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/21433] The COMPONENT_REF case of expand_expr_real_1 is probably wrong
[not found] <bug-21433-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2021-05-11 20:00 ` cvs-commit at gcc dot gnu.org
@ 2021-05-11 20:01 ` msebor at gcc dot gnu.org
4 siblings, 0 replies; 7+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-05-11 20:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
Martin Sebor <msebor at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #6 from Martin Sebor <msebor at gcc dot gnu.org> ---
Fixed in r12-728.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/21433] The COMPONENT_REF case of expand_expr_real_1 is probably wrong
[not found] <bug-21433-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2021-02-12 0:16 ` msebor at gcc dot gnu.org
@ 2021-05-11 20:00 ` cvs-commit at gcc dot gnu.org
2021-05-11 20:01 ` msebor at gcc dot gnu.org
4 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-05-11 20:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Sebor <msebor@gcc.gnu.org>:
https://gcc.gnu.org/g:de09c0ddb81e2dc0e35c2e362532e93ca417200c
commit r12-728-gde09c0ddb81e2dc0e35c2e362532e93ca417200c
Author: Martin Sebor <msebor@redhat.com>
Date: Tue May 11 13:58:48 2021 -0600
Replace unreachable code with an assert.
Resolves:
PR middle-end/21433 - The COMPONENT_REF case of expand_expr_real_1 is
probably wrong
gcc/ChangeLog:
PR middle-end/21433
* expr.c (expand_expr_real_1): Replace unreachable code with an
assert.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/21433] The COMPONENT_REF case of expand_expr_real_1 is probably wrong
[not found] <bug-21433-4@http.gcc.gnu.org/bugzilla/>
2021-02-10 23:34 ` msebor at gcc dot gnu.org
2021-02-11 23:52 ` msebor at gcc dot gnu.org
@ 2021-02-12 0:16 ` msebor at gcc dot gnu.org
2021-05-11 20:00 ` cvs-commit at gcc dot gnu.org
2021-05-11 20:01 ` msebor at gcc dot gnu.org
4 siblings, 0 replies; 7+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-02-12 0:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
Martin Sebor <msebor at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |msebor at gcc dot gnu.org
Keywords| |patch
--- Comment #4 from Martin Sebor <msebor at gcc dot gnu.org> ---
Patch proposed for GCC 12:
https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565211.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/21433] The COMPONENT_REF case of expand_expr_real_1 is probably wrong
[not found] <bug-21433-4@http.gcc.gnu.org/bugzilla/>
2021-02-10 23:34 ` msebor at gcc dot gnu.org
@ 2021-02-11 23:52 ` msebor at gcc dot gnu.org
2021-02-12 0:16 ` msebor at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-02-11 23:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
Created attachment 50171
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50171&action=edit
Proposed patch.
Patched to remove the CONSTRUCTOR code and replace it with an assert that it
doesn't come up. Tested on x86_64-linux.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug middle-end/21433] The COMPONENT_REF case of expand_expr_real_1 is probably wrong
[not found] <bug-21433-4@http.gcc.gnu.org/bugzilla/>
@ 2021-02-10 23:34 ` msebor at gcc dot gnu.org
2021-02-11 23:52 ` msebor at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-02-10 23:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21433
Martin Sebor <msebor at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed|2012-01-19 00:00:00 |2021-2-10
CC| |msebor at gcc dot gnu.org
--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
Instrumenting GCC 11 to print the tree code of the first operand shows the
following:
array_ref
component_ref
mem_ref
parm_decl
result_decl
var_decl
confirming the code is most likely dead.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-11 20:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-07 3:31 [Bug middle-end/21433] New: The COMPONENT_REF case of expand_expr_real_1 is probably wrong kazu at cs dot umass dot edu
2005-05-07 15:52 ` [Bug middle-end/21433] " pinskia at gcc dot gnu dot org
[not found] <bug-21433-4@http.gcc.gnu.org/bugzilla/>
2021-02-10 23:34 ` msebor at gcc dot gnu.org
2021-02-11 23:52 ` msebor at gcc dot gnu.org
2021-02-12 0:16 ` msebor at gcc dot gnu.org
2021-05-11 20:00 ` cvs-commit at gcc dot gnu.org
2021-05-11 20:01 ` msebor at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).