[Bug fortran/21302] New: Max line length in free form mode

[Bug fortran/21302] New: Max line length in free form mode

[pinskia at gcc dot gnu dot org]

I don't know if this is not a bug but I found this will looking into 21300, take the following Fortran free 
formed code:
 if 
(abs(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).gt.999.d0.or.abs(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb).gt.99
9.d0.or.abs(cccccccccccccccccccc).gt.999.d0) THEN
endif
 
 end program

Note the if is all on the same line.
We get an error (and a warning with -Wline-truncation) but I don't think free form should have a line 
lenght limit.

-- 
           Summary: Max line length in free form mode
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[kargl at gcc dot gnu dot org]

------- Additional Comments From kargl at gcc dot gnu dot org  2005-05-01 18:05 -------
(In reply to comment #0)
> We get an error (and a warning with -Wline-truncation) but I don't think
> free form should have a line lenght limit.

See 3.3.1 from the Standard.  "In free source form, each source line may 
contain fomr zero to 132 characters and there are restrictions on where
a statement (or portion of a statement) may appear within a line"

I suppose we could implement a -fline-length=N type option.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-01 18:47 -------
(In reply to comment #1)
> I suppose we could implement a -fline-length=N type option.

Then lets call this an enhancement  but note it blocks compiling OrbFit which works on XLF, Intel's and 
others.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|rejects-valid               |
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-01 18:47:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[tobi at gcc dot gnu dot org]

------- Additional Comments From tobi at gcc dot gnu dot org  2005-05-11 23:05 -------
Actually, we already have this, but only for fixed form.  It should be no
problem to generalize this to free form as well.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[rep dot nop at aon dot at]

------- Additional Comments From rep dot nop at aon dot at  2005-08-08 14:33 -------
(From update of attachment 9444)
correct description: it's about free form, not fixed form.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9444|allow -ffixed-line-length in|allow -ffixed-line-length in
        description|fixed form                  |free form


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[rep dot nop at aon dot at]

------- Comment #6 from rep dot nop at aon dot at  2005-11-09 21:58 -------
Created an attachment (id=10199)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10199&action=view)
add -ffree-line-length-none -ffree-line-length-<n>

http://gcc.gnu.org/ml/fortran/2005-10/msg00559.html

2005-09-11 Bernhard Fischer <rep.nop@aon.at>

        PR fortran/21302
        * lang.opt: New options -ffree-line-length- and
-ffree-line-length-none.
        * gfortran.h: Add free_line_length.
        * c-opts.c (c_common_handle_option): Ignore OPT_ffree_form and
        OPT_ffree_line_length_ when preprocessing.
        * options.c (gfc_init_options, gfc_handle_option): Initialize
        and set free_line_length and fixed_line_length.
        * scanner.c (load_line): Set free_line_length to 132 and
        fixed_line_length to 72 or user requested values. A line either
        starts with '#' thus is a preprocessor-line or is an include, so
        use "else".
        * scanner.c: Typo in comment.
        * invoke.texi: Document -ffree-line-length- and
        -ffree-line-length-none


-- 

rep dot nop at aon dot at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #9444 is|0                           |1
           obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[rep dot nop at aon dot at]

------- Comment #7 from rep dot nop at aon dot at  2005-11-20 20:13 -------
updated patch:
http://gcc.gnu.org/ml/fortran/2005-11/msg00551.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[rep dot nop at aon dot at]

------- Comment #8 from rep dot nop at aon dot at  2005-11-25 19:02 -------

updated patch:

http://gcc.gnu.org/ml/fortran/2005-11/msg00612.html

ACK by stevenb:
http://gcc.gnu.org/ml/fortran/2005-11/msg00631.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[rep dot nop at aon dot at]

------- Comment #9 from rep dot nop at aon dot at  2005-11-27 14:46 -------
(In reply to comment #8)
> updated patch:
> 
> http://gcc.gnu.org/ml/fortran/2005-11/msg00612.html
> 
> ACK by stevenb:
> http://gcc.gnu.org/ml/fortran/2005-11/msg00631.html
> 
And each a testcase for -ffree-line-length-none and -ffixed-line-length-none
here:
http://gcc.gnu.org/ml/fortran/2005-11/msg00676.html

Please apply,
thank you


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[kargl at gcc dot gnu dot org]

------- Comment #10 from kargl at gcc dot gnu dot org  2005-11-30 23:57 -------
Subject: Bug 21302

Author: kargl
Date: Wed Nov 30 23:57:44 2005
New Revision: 107745

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107745
Log:
2005-11-30  Bernhard Fischer <rep.nop@aon.at>
        PR fortran/21302
        * lang.opt: New options -ffree-line-length- and
-ffree-line-length-none.
        * gfortran.h: Add free_line_length and add description of
        free_line_length and fixed_line_length.
        * options.c (gfc_init_options, gfc_handle_option): Initialize
        and set free_line_length and fixed_line_length.
        * scanner.c (load_line): Set free_line_length to 132 and
        fixed_line_length to 72 or user requested values.
        * scanner.c: Typo in comment.
        * invoke.texi: Document -ffree-line-length- and
        -ffree-line-length-none

        gfortran.dg/line_length_1.f: New test:
        gfortran.dg/line_length_2.f90: Ditto.

Added:
    trunk/gcc/testsuite/gfortran.dg/line_length_1.f
    trunk/gcc/testsuite/gfortran.dg/line_length_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/invoke.texi
    trunk/gcc/fortran/lang.opt
    trunk/gcc/fortran/options.c
    trunk/gcc/fortran/scanner.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[kargl at gcc dot gnu dot org]

------- Comment #11 from kargl at gcc dot gnu dot org  2005-12-02 00:35 -------
Subject: Bug 21302

Author: kargl
Date: Fri Dec  2 00:35:41 2005
New Revision: 107850

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107850
Log:
        PR fortran/21302
        * lang.opt: New options -ffree-line-length- and
-ffree-line-length-none.
        * gfortran.h: Add free_line_length and add description of
        free_line_length and fixed_line_length.
        * options.c (gfc_init_options, gfc_handle_option): Initialize
        and set free_line_length and fixed_line_length.
        * scanner.c (load_line): Set free_line_length to 132 and
        fixed_line_length to 72 or user requested values.
        * scanner.c: Typo in comment.
        * invoke.texi: Document -ffree-line-length- and
        -ffree-line-length-none

        PR fortran/21302
        * gfortran.dg/line_length_1.f: New test.
        * gfortran.dg/line_length_2.f90: Ditto.


Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/line_length_1.f
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/line_length_2.f90
Modified:
    branches/gcc-4_1-branch/gcc/fortran/ChangeLog
    branches/gcc-4_1-branch/gcc/fortran/gfortran.h
    branches/gcc-4_1-branch/gcc/fortran/invoke.texi
    branches/gcc-4_1-branch/gcc/fortran/lang.opt
    branches/gcc-4_1-branch/gcc/fortran/options.c
    branches/gcc-4_1-branch/gcc/fortran/scanner.c
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302

[Bug fortran/21302] Max line length in free form mode

[kargl at gcc dot gnu dot org]

------- Comment #12 from kargl at gcc dot gnu dot org  2005-12-02 00:57 -------
Fixed.


-- 

kargl at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21302