[Bug libstdc++/21526] New: libstdc++-v3 testsuite hangs on cygwin

[Bug libstdc++/21526] New: libstdc++-v3 testsuite hangs on cygwin

[billingd at gcc dot gnu dot org]

The libstdc++-v3 testsuite hangs on cygwin on 4.0 and 4.1 branches.  The 
offending test is 27_io/basic_filebuf/showmanyc/char/9533-1.cc.  The following 
patch works around the problem and allows the testsuite to complete.

cygwin fifo support is incomplete, so this may not be a gcc bug.

I will test it on another platform overnight.

Index: 9533-1.cc
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-
v3/testsuite/27_io/basic_filebuf/showmanyc/char/9533-1.cc,v
retrieving revision 1.6
diff -u -r1.6 9533-1.cc
--- 9533-1.cc   6 May 2005 17:03:08 -0000       1.6
+++ 9533-1.cc   12 May 2005 05:49:54 -0000
@@ -1,5 +1,6 @@
 // { dg-require-fork "" }
 // { dg-require-mkfifo "" }
+// { dg-do run { target { ! i?86-pc-cygwin } } }
 
 // Copyright (C) 2003 Free Software Foundation, Inc.
 //

-- 
           Summary: libstdc++-v3 testsuite hangs on cygwin
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: billingd at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-cygwin
  GCC host triplet: i686-pc-cygwin
GCC target triplet: i686-pc-cygwin


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-12 06:26 -------
This is definitely a cygwin bug.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-12 06:27 -------
Shouldn't the dejagnu timeout come into effect anyways?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[david dot billinghurst at comalco dot riotinto dot com dot au]

------- Additional Comments From david dot billinghurst at comalco dot riotinto dot com dot au  2005-05-12 06:34 -------
Subject: RE:  libstdc++-v3 testsuite hangs on cygwin

Yes, it should time out.  It doesn't and I haven't worked out why (yet).
The test sat for many hours without using any CPU time.

Dejugnu timeouts used to work.  All the cases that used to timeout
were fixed, so it hasn't been tested for a while.


NOTICE
This e-mail and any attachments are private and confidential and may contain privileged information. If you are not an authorised recipient, the copying or distribution of this e-mail and any attachments is prohibited and you must not read, print or act in reliance on this e-mail or attachments.
This notice should not be removed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-12 09:41 -------
Hum, this problem appear to imply that something is not completely ok
with the recent try_mkfifo -> dg-require-mkfifo switch. If I understand
correctly, before the latter we effectively skipped at runtime this test
on cygwin (and mingw):

  int
  try_mkfifo (const char* filename, mode_t mode)
  {
#if defined (_NEWLIB_VERSION) || defined (__MINGW32_VERSION)
    /* Newlib and MinGW32 do not have mkfifo.  */
    exit(0);
#else
    return mkfifo(filename, mode);
#endif
  }

Now the compile-type DejaGNU check *enables* the test... Mark?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-12 10:02 -------
In other terms, we should tell DejaGNU that all the tests involving fifos must
be skipped on such platform, because fifos are available but not completely ok.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2005-05-12 15:15 -------
Subject: Re:  libstdc++-v3 testsuite hangs on cygwin

pcarlini at suse dot de wrote:
> ------- Additional Comments From pcarlini at suse dot de  2005-05-12 10:02 -------
> In other terms, we should tell DejaGNU that all the tests involving fifos must
> be skipped on such platform, because fifos are available but not completely ok.

Sorry; I assumed Cygwin must not have mkfifo, given that the test was 
disabled there; I didn't consider has-mkfifo-but-broken!

The fix for this will be to modify target-supports.exp to check the 
platform as well.

If you change check_mkfifo_available in target-supports.exp to do:

proc check_mkfifo_available {} {
     if {[istarget *-*-cygwin*]} {
       # Cygwin has mkfifo, but support is incomplete.
       return 0
     }

     return [check_function_available "mkfifo"]
}

that should fix it.  Would you mind trying that?

Thanks,



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2005-05-12 15:23 -------
Thanks a lot Mark. At this point, since your suggestion is complete as-is,
I would ask David to try it himself. Then, if everything goes well on
cygwin (which I don't have) I will take care of regtesting it on x86-linux
too, and so on. Thanks again.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2005-05-12 15:32 -------
Subject: Re:  libstdc++-v3 testsuite hangs on cygwin

pcarlini at suse dot de wrote:
> ------- Additional Comments From pcarlini at suse dot de  2005-05-12 15:23 -------
> Thanks a lot Mark. At this point, since your suggestion is complete as-is,
> I would ask David to try it himself. Then, if everything goes well on
> cygwin (which I don't have) I will take care of regtesting it on x86-linux
> too, and so on. Thanks again.

If you don't have time to do that, it's certainly my responsibility.

Thanks,



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[david dot billinghurst at comalco dot riotinto dot com dot au]

------- Additional Comments From david dot billinghurst at comalco dot riotinto dot com dot au  2005-05-13 00:32 -------
Subject: RE:  libstdc++-v3 testsuite hangs on cygwin

I can test Mark's patch on cygwin and irix. I assume it is OK 
to commit it to 4.0 and 4.1 once tested.

	David


NOTICE
This e-mail and any attachments are private and confidential and may contain privileged information. If you are not an authorised recipient, the copying or distribution of this e-mail and any attachments is prohibited and you must not read, print or act in reliance on this e-mail or attachments.
This notice should not be removed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2005-05-13 00:37 -------
Subject: Re:  libstdc++-v3 testsuite hangs on cygwin

david dot billinghurst at comalco dot riotinto dot com dot au wrote:
> ------- Additional Comments From david dot billinghurst at comalco dot riotinto dot com dot au  2005-05-13 00:32 -------
> Subject: RE:  libstdc++-v3 testsuite hangs on cygwin
> 
> I can test Mark's patch on cygwin and irix. I assume it is OK 
> to commit it to 4.0 and 4.1 once tested.

Yes, certainly!



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-16 00:51 -------
Subject: Bug 21526

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	billingd@gcc.gnu.org	2005-05-16 00:51:42

Modified files:
	gcc/testsuite/lib: target-supports.exp 
	gcc/testsuite  : ChangeLog 

Log message:
	2005-05-16  David Billinghurst <David.Billinghurst@riotinto.com>
	
	PR libstdc++/21526
	* lib/target-supports.exp (check_mkfifo_available):
	Return 0 for cygwin as mkfifo support incomplete on platform.
	Fix typos in comments.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/lib/target-supports.exp.diff?cvsroot=gcc&r1=1.56&r2=1.57
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5475&r2=1.5476



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-16 00:55 -------
Subject: Bug 21526

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	billingd@gcc.gnu.org	2005-05-16 00:55:29

Modified files:
	gcc/testsuite/lib: target-supports.exp 
	gcc/testsuite  : ChangeLog 

Log message:
	2005-05-16  David Billinghurst <David.Billinghurst@riotinto.com>
	
	PR libstdc++/21526
	* lib/target-supports.exp (check_mkfifo_available):
	Return 0 for cygwin as mkfifo support incomplete on platform.
	Fix typos in comments.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/lib/target-supports.exp.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.40.4.4&r2=1.40.4.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.178&r2=1.5084.2.179



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[billingd at gcc dot gnu dot org]

------- Additional Comments From billingd at gcc dot gnu dot org  2005-05-16 00:58 -------
Fixed by patch to lib/target-supports.exp.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[david dot billinghurst at comalco dot riotinto dot com dot au]

------- Additional Comments From david dot billinghurst at comalco dot riotinto dot com dot au  2005-05-16 00:59 -------
Subject:  Testsuite patch committed

This fix that Mark Mitchell suggested has been tested on cywin and irix.
Committed to 4.0 and HEAD.

2005-05-16  David Billinghurst <David.Billinghurst@riotinto.com>

	PR libstdc++/21526
	* lib/target-supports.exp (check_mkfifo_available):
	Return 0 for cygwin as mkfifo support incomplete on platform.
	Fix typos in comments.

diff -u -r1.56 target-supports.exp
--- lib/target-supports.exp     6 May 2005 17:03:10 -0000       1.56
+++ lib/target-supports.exp     16 May 2005 00:41:59 -0000
@@ -636,15 +636,20 @@
     eval return \$$var
 }
 
-# Returns ture iff "fork" is available on the target system.
+# Returns true iff "fork" is available on the target system.
 
 proc check_fork_available {} {
     return [check_function_available "fork"]
 }
 
-# Returns ture iff "mkfifo" is available on the target system.
+# Returns true iff "mkfifo" is available on the target system.
 
 proc check_mkfifo_available {} {
+    if {[istarget *-*-cygwin*]} {
+       # Cygwin has mkfifo, but support is incomplete.
+       return 0
+     }
+
     return [check_function_available "mkfifo"]
 }


NOTICE
This e-mail and any attachments are private and confidential and may contain privileged information. If you are not an authorised recipient, the copying or distribution of this e-mail and any attachments is prohibited and you must not read, print or act in reliance on this e-mail or attachments.
This notice should not be removed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526

[Bug libstdc++/21526] libstdc++-v3 testsuite hangs on cygwin

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21526