[Bug target/21597] New: libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[Bug target/21597] New: libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[dannysmith at users dot sourceforge dot net]

This change:
2005-05-10  Grigory Zagorodnev  <grigory.zagorodnev@intel.com>
	    H.J. Lu  <hongjiu.lu@intel.com>

	* libgcov.c (create_file_directory): New function. Create
	directory for the given file name.

breaks build on mingw32 with:
../../gcc/gcc/libgcov.c: In function 'create_file_directory':
../../gcc/gcc/libgcov.c:115: error: too many arguments to function 'mkdir'
make[2]: *** [libgcc/./_gcov.o] Error 1
make[1]: *** [libgcc.a] Error 2
make: *** [all-gcc] Error 2

-- 
           Summary: libgcc broken on targets with MKDIR_TAKES_ONE_ARG
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dannysmith at users dot sourceforge dot net
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-mingw32
  GCC host triplet: i686-pc-mingw32
GCC target triplet: i686-pc-mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-16 00:13 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|target                      |middle-end
     Ever Confirmed|                            |1
           Keywords|                            |build
   Last reconfirmed|0000-00-00 00:00:00         |2005-05-16 00:13:54
               date|                            |
            Summary|libgcc broken on targets    |[4.1 Regression] libgcc
                   |with MKDIR_TAKES_ONE_ARG    |broken on targets with
                   |                            |MKDIR_TAKES_ONE_ARG
   Target Milestone|---                         |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[fxcoudert at gmail dot com]

------- Additional Comments From fxcoudert at gmail dot com  2005-05-21 10:03 -------
On i386-mingw32, there is another one of those:

../../gcc/fastjar/jartool.c: In function 'extract_jar':
../../gcc/fastjar/jartool.c:1770: error: too many arguments to function 'mkdir'

Looks like MKDIR_TAKES_ONE_ARG is not defined as it should be.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-30 15:29 -------
(In reply to comment #2)
> Looks like MKDIR_TAKES_ONE_ARG is not defined as it should be.
Which I filed as PR 21826.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[fxcoudert at gcc dot gnu dot org]

------- Additional Comments From fxcoudert at gcc dot gnu dot org  2005-06-09 18:48 -------
With fresh CVS GCC, I get the following errors on libgcov.c:

../../gcc/gcc/libgcov.c: In function 'create_file_directory':
../../gcc/gcc/libgcov.c:110: warning: implicit declaration of function 'access'
../../gcc/gcc/libgcov.c:110: error: 'F_OK' undeclared (first use in this function)
../../gcc/gcc/libgcov.c:110: error: (Each undeclared identifier is reported only
once
../../gcc/gcc/libgcov.c:110: error: for each function it appears in.)
../../gcc/gcc/libgcov.c:111: warning: implicit declaration of function 'mkdir'

All are related to the same problem: mkdir and access functions are defined in
the <io.h> system header, which is not included in libgcov.c (and not included
either when configure tests if MKDIR_TAKES_ONE_ARG should be defined, that's why
we can have "the too many arguments to function 'mkdir'" error when everything
else is fixed).

So what we need is that to test for the presence of <io.h> in configure.ac, and
then include in libgcov.c when it's available.

Can someone confirm whether such an approach is the right thing to do?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[dannysmith at users dot sourceforge dot net]

------- Additional Comments From dannysmith at users dot sourceforge dot net  2005-06-09 20:33 -------
Re; comment #4

There should be no need te test for <io.h> for the sake of mingw
libgcov.c already includes tsystem.h
tsystem.h includes <unistd.h>.
On mingw, unistd.h  includes <io.h>

Danny

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597